loplugin:unnecessaryvirtual

Change-Id: I3a3d4debd83f1a6452721ce704b6b88622b38109
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152004
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

2 files changed, 44 insertions, 32 deletions

diff --git a/compilerplugins/clang/unnecessaryvirtual-dead.results b/compilerplugins/clang/unnecessaryvirtual-dead.results
index 2b75f1e230a0..ae2c471b216c 100644
--- a/compilerplugins/clang/unnecessaryvirtual-dead.results
+++ b/compilerplugins/clang/unnecessaryvirtual-dead.results
@@ -8,10 +8,14 @@ canvas/inc/base/graphicdevicebase.hxx:318
     void canvas::GraphicDeviceBase::removeVetoableChangeListener(const class rtl::OUString &,const class com::sun::star::uno::Reference<class com::sun::star::beans::XVetoableChangeListener> &,)
 include/basegfx/utils/unopolypolygon.hxx:93
     void basegfx::unotools::UnoPolyPolygon::modifying()const
+include/comphelper/propmultiplex2.hxx:54
+    void comphelper::OPropertyChangeListener2::_disposing(const struct com::sun::star::lang::EventObject &,)
 sc/source/core/opencl/opbase.hxx:447
     void sc::opencl::DynamicKernelSlidingArgument::GenSlidingWindowFunction(class sc::opencl::outputstream &,)
 slideshow/source/engine/animationfactory.cxx:617
     void slideshow::internal::(anonymous namespace)::GenericAnimation::prefetch()
+vcl/inc/font/LogicalFontInstance.hxx:126
+    void LogicalFontInstance::ImplInitHbFont(struct hb_font_t *,)
 vcl/inc/salframe.hxx:145
     void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
 vcl/inc/salinst.hxx:204
diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results
index da90969bb3e6..7404a1cffd85 100644
--- a/compilerplugins/clang/unnecessaryvirtual.results
+++ b/compilerplugins/clang/unnecessaryvirtual.results
@@ -230,11 +230,11 @@ extensions/source/propctrlr/commoncontrol.hxx:139
     void pcr::CommonBehaviourControl::notifyModifiedValue()
 extensions/source/propctrlr/commoncontrol.hxx:154
     void pcr::CommonBehaviourControl::disposing()
-forms/source/xforms/datatypes.hxx:215
+forms/source/xforms/datatypes.hxx:217
     class cppu::IPropertyArrayHelper * xforms::ODerivedDataType::createArrayHelper()const
-forms/source/xforms/datatypes.hxx:218
+forms/source/xforms/datatypes.hxx:220
     class com::sun::star::uno::Reference<class com::sun::star::beans::XPropertySetInfo> xforms::ODerivedDataType::getPropertySetInfo()
-forms/source/xforms/datatypes.hxx:219
+forms/source/xforms/datatypes.hxx:221
     class cppu::IPropertyArrayHelper & xforms::ODerivedDataType::getInfoHelper()
 forms/source/xforms/namedcollection.hxx:80
     class com::sun::star::uno::Type NamedCollection::getElementType()
@@ -252,16 +252,18 @@ include/comphelper/interaction.hxx:53
     void comphelper::OInteraction::select()
 include/comphelper/proparrhlp.hxx:83
     class cppu::IPropertyArrayHelper * comphelper::OAggregationArrayUsageHelper::createArrayHelper()const
+include/comphelper/propmultiplex2.hxx:54
+    void comphelper::OPropertyChangeListener2::_disposing(const struct com::sun::star::lang::EventObject &,)
+include/comphelper/propshlp.hxx:173
+    class com::sun::star::uno::Any comphelper::OPropertySetHelper::getPropertyValueImpl(class std::unique_lock<class std::mutex> &,const class rtl::OUString &,)
 include/comphelper/solarmutex.hxx:59
     _Bool comphelper::SolarMutex::tryToAcquire()
 include/comphelper/unique_disposing_ptr.hxx:170
     void comphelper::unique_disposing_solar_mutex_reset_ptr::reset(type-parameter-0-0 *,)
 include/comphelper/weakeventlistener.hxx:121
     void comphelper::OWeakListenerAdapter::disposing(const struct com::sun::star::lang::EventObject &,)
-include/sfx2/tabdlg.hxx:98
-    _Bool SfxTabDialogController::DeactivatePage(const class rtl::OString &,)
-include/sfx2/thumbnailviewitem.hxx:118
-    void ThumbnailViewItem::calculateItemsPosition(const long,const long,unsigned int,const struct ThumbnailItemAttributes *,)
+include/sfx2/AccessibilityIssue.hxx:55
+    void sfx::AccessibilityIssue::setParent(class weld::Window *,)
 include/svl/svdde.hxx:236
     class DdeData * DdeTopic::Get(enum SotClipboardFormatId,)
 include/svl/svdde.hxx:237
@@ -274,13 +276,13 @@ include/svl/svdde.hxx:243
     _Bool DdeTopic::StartAdviseLoop()
 include/svl/svdde.hxx:300
     void DdeService::~DdeService()
-include/svx/svdundo.hxx:753
+include/svx/svdundo.hxx:752
     class std::unique_ptr<class SdrUndoAction> SdrUndoFactory::CreateUndoDiagramModelData(class SdrObject &,class std::shared_ptr<class svx::diagram::DiagramDataState> &,)
 include/vbahelper/vbacollectionimpl.hxx:290
     int ScVbaCollectionBase::getCount()
 include/vbahelper/vbacollectionimpl.hxx:295
     class com::sun::star::uno::Any ScVbaCollectionBase::Item(const class com::sun::star::uno::Any &,const class com::sun::star::uno::Any &,)
-include/vbahelper/vbacollectionimpl.hxx:324
+include/vbahelper/vbacollectionimpl.hxx:333
     unsigned char ScVbaCollectionBase::hasElements()
 include/vbahelper/vbahelperinterface.hxx:75
     int InheritedHelperInterfaceImpl::getCreator()
@@ -300,7 +302,7 @@ include/vbahelper/vbareturntypes.hxx:39
     type-parameter-0-0 ooo::vba::DefaultReturnHelper::getValue()
 include/vcl/customweld.hxx:45
     class rtl::OUString weld::CustomWidgetController::GetHelpText()const
-include/vcl/weld.hxx:108
+include/vcl/weld.hxx:109
     void weld::Widget::set_visible(_Bool,)
 sc/source/core/opencl/opbase.hxx:446
     _Bool sc::opencl::DynamicKernelSlidingArgument::NeedParallelReduction()const
@@ -398,34 +400,40 @@ slideshow/source/engine/animationfactory.cxx:620
     void slideshow::internal::(anonymous namespace)::GenericAnimation::start(const class std::shared_ptr<class slideshow::internal::AnimatableShape> &,const class std::shared_ptr<class slideshow::internal::ShapeAttributeLayer> &,)
 slideshow/source/inc/shape.hxx:221
     void slideshow::internal::Shape::setIsForeground(const _Bool,)
-sw/source/core/inc/bookmark.hxx:277
-    void sw::mark::FieldmarkWithDropDownButton::LaunchPopup()
 toolkit/inc/controls/geometrycontrolmodel.hxx:185
     void OGeometryControlModel::fillProperties(class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,)const
-vcl/inc/jsdialog/jsdialogbuilder.hxx:159
+vcl/inc/font/LogicalFontInstance.hxx:126
+    void LogicalFontInstance::ImplInitHbFont(struct hb_font_t *,)
+vcl/inc/jsdialog/jsdialogbuilder.hxx:165
     void JSDialogSender::sendFullUpdate(_Bool,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:162
-    void JSDialogSender::sendAction(class VclPtr<class vcl::Window>,class std::unique_ptr<class std::unordered_map<class std::basic_string<char>, class rtl::OUString> >,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:164
+vcl/inc/jsdialog/jsdialogbuilder.hxx:168
+    void JSDialogSender::sendAction(class VclPtr<class vcl::Window>,class std::unique_ptr<class std::unordered_map<class rtl::OString, class rtl::OUString> >,)
+vcl/inc/jsdialog/jsdialogbuilder.hxx:170
     void JSDialogSender::sendPopup(class VclPtr<class vcl::Window>,class rtl::OUString,class rtl::OUString,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:165
+vcl/inc/jsdialog/jsdialogbuilder.hxx:171
     void JSDialogSender::sendClosePopup(unsigned int,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:367
+vcl/inc/jsdialog/jsdialogbuilder.hxx:392
     void JSWidget::show()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:380
+vcl/inc/jsdialog/jsdialogbuilder.hxx:405
     void JSWidget::hide()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:394
+vcl/inc/jsdialog/jsdialogbuilder.hxx:419
     void JSWidget::set_sensitive(_Bool,)
-vcl/inc/jsdialog/jsdialogbuilder.hxx:402
+vcl/inc/jsdialog/jsdialogbuilder.hxx:427
     class com::sun::star::uno::Reference<class com::sun::star::datatransfer::dnd::XDropTarget> JSWidget::get_drop_target()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:410
+vcl/inc/jsdialog/jsdialogbuilder.hxx:435
     void JSWidget::freeze()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:416
+vcl/inc/jsdialog/jsdialogbuilder.hxx:441
     void JSWidget::thaw()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:423
+vcl/inc/jsdialog/jsdialogbuilder.hxx:448
     void JSWidget::grab_focus()
-vcl/inc/jsdialog/jsdialogbuilder.hxx:529
+vcl/inc/jsdialog/jsdialogbuilder.hxx:492
+    void JSWidget::set_buildable_name(const class rtl::OUString &,)
+vcl/inc/jsdialog/jsdialogbuilder.hxx:620
     void JSComboBox::set_entry_text_without_notify(const class rtl::OUString &,)
+vcl/inc/qt5/QtAccessibleWidget.hxx:165
+    int QtAccessibleWidget::selectedItemCount()const
+vcl/inc/qt5/QtAccessibleWidget.hxx:166
+    class QList<class QAccessibleInterface *> QtAccessibleWidget::selectedItems()const
 vcl/inc/salframe.hxx:145
     void SalFrame::SetRepresentedURL(const class rtl::OUString &,)
 vcl/inc/salframe.hxx:194
@@ -440,21 +448,21 @@ vcl/inc/salobj.hxx:49
     void SalObject::Enable(_Bool,)
 vcl/inc/salprn.hxx:116
     enum SalPrinterError SalPrinter::GetErrorCode()
-vcl/inc/salvtables.hxx:1625
+vcl/inc/salvtables.hxx:1771
     _Bool SalInstanceTreeView::get_iter_abs_pos(class weld::TreeIter &,int,)const
-vcl/inc/skia/gdiimpl.hxx:229
+vcl/inc/skia/gdiimpl.hxx:230
     void SkiaSalGraphicsImpl::createSurface()
-vcl/inc/skia/gdiimpl.hxx:239
+vcl/inc/skia/gdiimpl.hxx:240
     void SkiaSalGraphicsImpl::flushSurfaceToWindowContext()
-vcl/inc/skia/gdiimpl.hxx:262
+vcl/inc/skia/gdiimpl.hxx:263
     int SkiaSalGraphicsImpl::getWindowScaling()const
-vcl/inc/unx/gtk/gtkdata.hxx:335
+vcl/inc/unx/gtk/gtkdata.hxx:336
     int GtkSalDisplay::CaptureMouse(class SalFrame *,)
 vcl/inc/unx/saldata.hxx:50
     void X11SalData::Init()
-vcl/inc/unx/saldisp.hxx:405
+vcl/inc/unx/saldisp.hxx:385
     void SalX11Display::Yield()
-vcl/inc/unx/salframe.h:209
+vcl/inc/unx/salframe.h:211
     void X11SalFrame::updateGraphics(_Bool,)
 vcl/inc/unx/salinst.h:41
     class SalX11Display * X11SalInstance::CreateDisplay()const