diff options
| author | Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org> | 2023-02-14 23:38:29 +0100 |
|---|---|---|
| committer | Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org> | 2023-02-15 18:56:41 +0000 |
| commit | 4f4f2f0502881fc1a26c600e84c94c62808169eb (patch) | |
| tree | 01e4f96c6d11da046dd06611df926280f90d9b74 /compilerplugins | |
| parent | 259ae22056b34f3477fc7ac0f31666dec41bf8ea (diff) | |
clean up SwRefMarkFieldUpdate a bit
- remove SwRefMarkFieldUpdate:
* it has only one unused field
* replace with a plain SwPtrMsgPoolItem
- hint constness:
* SwUndoFieldFromDoc: make ctor arg hint const
* DocumentFieldsManager: make UpdateField arg hint const
* however, seeing this hint is:
a/ constructed on the stack, but
b/ stored as pointer in undo
likely it would be best to remove it altogether. For now, make it at
least static, so that there is no use after free.
Change-Id: Ica51a2a2ce19e1938c3a367e9b4a9e01bbb75374
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147030
Tested-by: Jenkins
Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
Diffstat (limited to 'compilerplugins')
| -rw-r--r-- | compilerplugins/clang/unusedmethods.results | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results index 1c4f2a4119dd..bdac66f71d72 100644 --- a/compilerplugins/clang/unusedmethods.results +++ b/compilerplugins/clang/unusedmethods.results @@ -1763,8 +1763,6 @@ include/svl/typedwhich.hxx:31 include/svl/typedwhich.hxx:31 TypedWhichId::TypedWhichId(TypedWhichId<type-parameter-?-?>,typename enable_if<std::is_base_of_v<SwPtrMsgPoolItem, derived_type>, int>::type) include/svl/typedwhich.hxx:31 - TypedWhichId::TypedWhichId(TypedWhichId<type-parameter-?-?>,typename enable_if<std::is_base_of_v<SwRefMarkFieldUpdate, derived_type>, int>::type) -include/svl/typedwhich.hxx:31 TypedWhichId::TypedWhichId(TypedWhichId<type-parameter-?-?>,typename enable_if<std::is_base_of_v<SwRegisterItem, derived_type>, int>::type) include/svl/typedwhich.hxx:31 TypedWhichId::TypedWhichId(TypedWhichId<type-parameter-?-?>,typename enable_if<std::is_base_of_v<SwRotationGrf, derived_type>, int>::type) |