compilerplugins: enable loplugin:cppunitassertequals by default

This forces writing a comparision of two variables in the
CPPUNIT_ASSERT_EQUALS(expected, actual) form, rather than
CPPUNIT_ASSERT(actual == expected). The benefit is when the test fail,
it's more clear what are these two values, rather than just seeing that
they are not equal.

In the relatively rare case when the types are not streamable, the
plugin can be silenced using CPPUNIT_ASSERT(bool(it == foo.end())). But
please always first consider making the type streamable instead. See
commit 0e1b831b93048c68735f2e2dbdcee587db4862ef
(CppunitTest_vcl_complextext: fix loplugin:cppunitassertequals warnings,
2016-12-16) for an example.

Change-Id: I564fb0724836b6dbbea9262b53ad646e285a339c

1 files changed, 1 insertions, 1 deletions

diff --git a/compilerplugins/clang/cppunitassertequals.cxx b/compilerplugins/clang/cppunitassertequals.cxx
index e9f4c0256516..858ad9615cbe 100644
--- a/compilerplugins/clang/cppunitassertequals.cxx
+++ b/compilerplugins/clang/cppunitassertequals.cxx
@@ -99,7 +99,7 @@ void CppunitAssertEquals::checkExpr(const Stmt* stmt)
       << stmt->getSourceRange();
 }
 
-loplugin::Plugin::Registration< CppunitAssertEquals > X("cppunitassertequals", false);
+loplugin::Plugin::Registration< CppunitAssertEquals > X("cppunitassertequals");
 
 }