summaryrefslogtreecommitdiff
path: root/compilerplugins
diff options
context:
space:
mode:
authorDaniel Arato (NISZ) <arato.daniel@nisz.hu>2020-09-16 08:48:32 +0200
committerLászló Németh <nemeth@numbertext.org>2020-10-06 12:31:04 +0200
commitaf4e5ee0f93c1ff442d08caed5c875f2b2c1fd43 (patch)
treeacf3133451bec3246d8736268d48513efbe6c324 /compilerplugins
parent94b73fb5e206a8718e5127cf58c826099ae92f5a (diff)
tdf#97128 DOCX import: fix frame direction
Frames used to be imported with zero rotation even if a w:textDirection tag explicitly called for a non-default orientation. I found no other solution to pass the incoming frame direction property on to the SwXFrame about to be created. 1. If you put the property into the GetSectionContext(), it gets overwritten when the next w:pPr tag is parsed, so all three frames will end up having the same direction. 2. If you put the property into the GetTopContextOfType(CONTEXT_PARAGRAPH) that context gets popped off the stack before control even gets to CheckUnregisteredFrameConversion(). 3. If you use PushStyleSheetProperties (which is bad in and of itself), the order will be messed up because the frames are not necessarily created in the same order as they are described in the file, so each frame gets a wrong frame direction in the end. Follow-up of commit 5a5597655a4bf12e4ca07c9c2b6f6221e217f080 (tentative fix for fdo#30474# [DOCX rotated text import failure]). Change-Id: I6e3d68fe60c6e2a5b6684c65a964dd86d0168181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103553 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
Diffstat (limited to 'compilerplugins')
0 files changed, 0 insertions, 0 deletions