lok: calc: fix for rendering issues on in place editing

Our main problem is how to compute the correct output area for the
requested tile zoom level. The old solution was using a fine-tuned
edit rectangle as output area. An edit rectangle is the rectangle
computed according to the range of rows and columns involved in the
text editing. Unfortunately in some cases the edit rectangle can be
enough larger than the output area. For instance that occurs with
centered text.
The new proposed solution is able to scale the output area to the
requested tile zoom level by a few pixels (0 up to 3) offset/size
error. The hope is to reduce the error in some follow-up patch.

The new solution is also able to perform painting of text edited by
different views in the correct order. The last painted text is the one
belonging to the last view where editing occurred.
SfxViewShell::maEditViewHistory keeps track of the last 10 editing
events per document.

Change-Id: I8f1035a730cb2b94b0990f3c8eb6445511b94223
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162196
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163031
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>

1 files changed, 3 insertions, 0 deletions

diff --git a/compilerplugins/clang/badstatics.cxx b/compilerplugins/clang/badstatics.cxx
index 18638695bbeb..1d003acdb8a6 100644
--- a/compilerplugins/clang/badstatics.cxx
+++ b/compilerplugins/clang/badstatics.cxx
@@ -233,6 +233,9 @@ public:
                    // AquaA11yFocusTracker::m_aDocumentWindowList elements symmetrically added and
                    // removed in AquaA11yFocusTracker::window_got_focus and
                    // AquaA11yFocusTracker::WindowEventHandler (TODO: is that guaranteed?)
+                || (loplugin::DeclCheck(pVarDecl).Var("maEditViewHistory")
+                        .Class("LOKEditViewHistory").GlobalNamespace())
+                   // sfx2/lokhelper.hxx, only handling pointers, not owning
                ) // these variables appear unproblematic
             {
                 return true;