summaryrefslogtreecommitdiff
path: root/configmgr/qa
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.com>2019-07-24 14:40:21 +0200
committerMiklos Vajna <vmiklos@collabora.com>2019-07-25 09:21:13 +0200
commit4840880148318dc384e28f9a8df9990b8690a4b6 (patch)
tree2fcbfbb6c012a635ec93e34af9517a31809bf748 /configmgr/qa
parent2de42b53b7c23223c38e64a75eae248d8a0cd4ec (diff)
tdf#107394 sc ui: fix lack of row height update on undo of paste
This is a problem since commit df9243626b39742a9a148bea95796f8824fee68a (fdo#73606: Avoid excessive and unnecessary heap allocation of array objects., 2014-01-14), though it seems this uncovered a problem that was introduced earlier. Reading ScViewFunc::AdjustBlockHeight(), commit 64a36fd4f4085ed05e4c0ee40ac109452ff81a78 (ScUndoPaste to handle multiple ranges., 2011-09-09) changed ScUndoPaste::DoChange(), so that AdjustBlockHeight() is invoked in a loop, but always with the same arguments. In case AdjustBlockHeight() doesn't get a mark data, the function takes the mark data from the view data, which is empty in the "undo of paste" case, so no row height gets updated. Fix the problem by explicitly providing the mark data to AdjustBlockHeight(), probably that was the intention in the second commit. [ Testing this from CppunitTest_sc_copypaste means ScImportExport has to be dllpublic, but that seems still better than having a view shell in CppunitTest_sc_ucalc. ] Change-Id: I140b53588d59d231772152c0e820e5fdedf6894c Reviewed-on: https://gerrit.libreoffice.org/76265 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'configmgr/qa')
0 files changed, 0 insertions, 0 deletions