diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-01-24 17:49:17 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-01-24 17:52:46 +0100 |
| commit | 6935acb053dcc202a7ce72cdd0fc3a30f1161be0 (patch) | |
| tree | 4a9292118cd7334872f4f778ae6125ecc34034c7 /configmgr/source/valueparser.cxx | |
| parent | a0e4c24ecf8c92f3dba91a1b2319ec816ab57016 (diff) | |
Replace "known-good" dynamic_casts with static_casts
...it avoids false warnings about unchecked dynamic_cast results from static
code analyzers, and potentially makes the code a little faster, too. (Most of
these dynamic_casts were kind of a leftover from a very early design that
dispateched on Node type via dynamic_cast instead of a Node::Kind, but which was
much too slow.)
Change-Id: I8db08a1c35783f8ea6c51eed55b11faa2d958807
Diffstat (limited to 'configmgr/source/valueparser.cxx')
| -rw-r--r-- | configmgr/source/valueparser.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/configmgr/source/valueparser.cxx b/configmgr/source/valueparser.cxx index 67a65a63148b..f213d645fde5 100644 --- a/configmgr/source/valueparser.cxx +++ b/configmgr/source/valueparser.cxx @@ -389,7 +389,7 @@ bool ValueParser::endElement() { } switch (node_->kind()) { case Node::KIND_PROPERTY: - dynamic_cast< PropertyNode * >(node_.get())->setValue( + static_cast< PropertyNode * >(node_.get())->setValue( layer_, value); break; case Node::KIND_LOCALIZED_PROPERTY: @@ -402,7 +402,7 @@ bool ValueParser::endElement() { localizedName_, new LocalizedValueNode(layer_, value))); } else { - dynamic_cast< LocalizedValueNode * >(i->second.get())-> + static_cast< LocalizedValueNode * >(i->second.get())-> setValue(layer_, value); } } |