diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2014-01-24 17:49:17 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2014-01-24 17:52:46 +0100 |
| commit | 6935acb053dcc202a7ce72cdd0fc3a30f1161be0 (patch) | |
| tree | 4a9292118cd7334872f4f778ae6125ecc34034c7 /configmgr/source/xcsparser.cxx | |
| parent | a0e4c24ecf8c92f3dba91a1b2319ec816ab57016 (diff) | |
Replace "known-good" dynamic_casts with static_casts
...it avoids false warnings about unchecked dynamic_cast results from static
code analyzers, and potentially makes the code a little faster, too. (Most of
these dynamic_casts were kind of a leftover from a very early design that
dispateched on Node type via dynamic_cast instead of a Node::Kind, but which was
much too slow.)
Change-Id: I8db08a1c35783f8ea6c51eed55b11faa2d958807
Diffstat (limited to 'configmgr/source/xcsparser.cxx')
| -rw-r--r-- | configmgr/source/xcsparser.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/configmgr/source/xcsparser.cxx b/configmgr/source/xcsparser.cxx index ca64e2e68d68..a550240ee3d3 100644 --- a/configmgr/source/xcsparser.cxx +++ b/configmgr/source/xcsparser.cxx @@ -74,7 +74,7 @@ void merge( NodeMap::iterator i1(members.find(i2->first)); if (i1 == members.end()) { if (i2->second->kind() == Node::KIND_PROPERTY && - dynamic_cast< GroupNode * >( + static_cast< GroupNode * >( original.get())->isExtensible()) { members.insert(*i2); @@ -91,7 +91,7 @@ void merge( NodeMap & members = original->getMembers(); NodeMap::iterator i1(members.find(i2->first)); if (i1 == members.end()) { - if (dynamic_cast< SetNode * >(original.get())-> + if (static_cast< SetNode * >(original.get())-> isValidTemplate(i2->second->getTemplateName())) { members.insert(*i2); @@ -235,7 +235,7 @@ bool XcsParser::startElement( { handleSetItem( reader, - dynamic_cast< SetNode * >(elements_.top().node.get())); + static_cast< SetNode * >(elements_.top().node.get())); return true; } break; |