diff options
author | Noel Grandin <noel@peralex.com> | 2016-07-18 09:22:27 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2016-07-27 06:48:25 +0000 |
commit | 508c95f1b655d9cfa6be37a5a9de9aff6fd383bf (patch) | |
tree | d1c8626818cbf26a699875ae2d82f751a1657e92 /configmgr | |
parent | 9f4af777a832d8a0b9a21d793d421fa6228131e0 (diff) |
improve passstuffbyref return analysis
Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'configmgr')
-rw-r--r-- | configmgr/source/lock.cxx | 2 | ||||
-rw-r--r-- | configmgr/source/lock.hxx | 2 | ||||
-rw-r--r-- | configmgr/source/propertynode.cxx | 2 | ||||
-rw-r--r-- | configmgr/source/propertynode.hxx | 2 | ||||
-rw-r--r-- | configmgr/source/rootaccess.cxx | 2 | ||||
-rw-r--r-- | configmgr/source/rootaccess.hxx | 2 |
6 files changed, 6 insertions, 6 deletions
diff --git a/configmgr/source/lock.cxx b/configmgr/source/lock.cxx index 66a2be9eeca6..9258b35bfeb7 100644 --- a/configmgr/source/lock.cxx +++ b/configmgr/source/lock.cxx @@ -25,7 +25,7 @@ namespace configmgr { -std::shared_ptr<osl::Mutex> lock() +std::shared_ptr<osl::Mutex> const & lock() { static std::shared_ptr<osl::Mutex> theLock; if (!theLock.get()) diff --git a/configmgr/source/lock.hxx b/configmgr/source/lock.hxx index d8c050e824e6..ee98efcc365f 100644 --- a/configmgr/source/lock.hxx +++ b/configmgr/source/lock.hxx @@ -26,7 +26,7 @@ namespace configmgr { -std::shared_ptr<osl::Mutex> lock(); +std::shared_ptr<osl::Mutex> const & lock(); } diff --git a/configmgr/source/propertynode.cxx b/configmgr/source/propertynode.cxx index 97c32b21fe4f..041cd50f890d 100644 --- a/configmgr/source/propertynode.cxx +++ b/configmgr/source/propertynode.cxx @@ -48,7 +48,7 @@ rtl::Reference< Node > PropertyNode::clone(bool) const { } -css::uno::Any PropertyNode::getValue(Components & components) { +css::uno::Any const & PropertyNode::getValue(Components & components) { if (!externalDescriptor_.isEmpty()) { css::beans::Optional< css::uno::Any > val( components.getExternalValue(externalDescriptor_)); diff --git a/configmgr/source/propertynode.hxx b/configmgr/source/propertynode.hxx index 7716ae963e34..e1ddb4495d08 100644 --- a/configmgr/source/propertynode.hxx +++ b/configmgr/source/propertynode.hxx @@ -45,7 +45,7 @@ public: bool isNillable() const { return nillable_;} - css::uno::Any getValue(Components & components); + css::uno::Any const & getValue(Components & components); void setValue(int layer, css::uno::Any const & value); css::uno::Any *getValuePtr(int layer); diff --git a/configmgr/source/rootaccess.cxx b/configmgr/source/rootaccess.cxx index a84898df0bbf..3d4bbd5b4345 100644 --- a/configmgr/source/rootaccess.cxx +++ b/configmgr/source/rootaccess.cxx @@ -101,7 +101,7 @@ void RootAccess::release() throw () { Access::release(); } -OUString RootAccess::getAbsolutePathRepresentation() { +OUString const & RootAccess::getAbsolutePathRepresentation() { getNode(); // turn pathRepresentation_ into canonic form return pathRepresentation_; } diff --git a/configmgr/source/rootaccess.hxx b/configmgr/source/rootaccess.hxx index a308ef59b223..8ea6b2025e6d 100644 --- a/configmgr/source/rootaccess.hxx +++ b/configmgr/source/rootaccess.hxx @@ -70,7 +70,7 @@ public: virtual void SAL_CALL release() throw () override; - OUString getAbsolutePathRepresentation(); + OUString const & getAbsolutePathRepresentation(); const OUString& getLocale() const { return locale_;} |