summaryrefslogtreecommitdiff
path: root/configmgr
diff options
context:
space:
mode:
authorJan Holesovsky <kendy@collabora.com>2020-07-23 00:42:42 +0200
committerAndras Timar <andras.timar@collabora.com>2020-07-23 10:40:27 +0200
commitdfc28be2487c13be36a90efd778b8d8f179c589d (patch)
tree1d8236373c8e8d37ad1306fbbe7755128293178f /configmgr
parent7ee6e771e2b267650a3f5042ffc5322069102491 (diff)
configmgr: Use a proper LanguageTag-based locale fallback mechanism.
Without this, zh-Hant-TW locale used via the LibreOfficeKit was reduced to zh-Hant and further to zh, which was interpreted as zh-CN, causing incorrect strings particularly in the sidebar. Change-Id: I58e53f71d13824e422a7b3634f3822d55090f8ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99203 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
Diffstat (limited to 'configmgr')
-rw-r--r--configmgr/source/access.cxx24
1 files changed, 10 insertions, 14 deletions
diff --git a/configmgr/source/access.cxx b/configmgr/source/access.cxx
index e07fc8446f51..0308a0361761 100644
--- a/configmgr/source/access.cxx
+++ b/configmgr/source/access.cxx
@@ -1385,29 +1385,25 @@ rtl::Reference< ChildAccess > Access::getChild(OUString const & name) {
locale = comphelper::LibreOfficeKit::getLanguageTag().getBcp47();
if (!locale.isEmpty()) {
- // Find best match using an adaptation of RFC 4647 lookup matching
- // rules, removing "-" or "_" delimited segments from the end:
- for (;;) {
- rtl::Reference< ChildAccess > child(getChild(locale));
- if (child.is()) {
+ // Find the best match using the LanguageTag fallback mechanism
+ std::vector<OUString> aFallbacks = LanguageTag(locale).getFallbackStrings(true);
+ for (const OUString& rFallback : aFallbacks)
+ {
+ rtl::Reference<ChildAccess> child(getChild(rFallback));
+ if (child.is())
return child;
- }
- sal_Int32 i = locale.getLength() - 1;
- while (i > 0 && locale[i] != '-' && locale[i] != '_') {
- --i;
- }
- if (i <= 0) {
- break;
- }
- locale = locale.copy(0, i);
}
+
// As a workaround for broken xcu data that does not use shortest
// xml:lang attributes, look for the first entry with the same first
// segment as the requested language tag before falling back to
// defaults (see fdo#33638):
+ assert(aFallbacks.size() > 0);
+ locale = aFallbacks[aFallbacks.size() - 1];
assert(
!locale.isEmpty() && locale.indexOf('-') == -1 &&
locale.indexOf('_') == -1);
+
std::vector< rtl::Reference< ChildAccess > > children(
getAllChildren());
for (auto const& child : children)