diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-09-20 08:16:52 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-09-20 07:35:13 +0000 |
| commit | 1ea987f23a4514bcae5a6bd98014ade1af4a0107 (patch) | |
| tree | 3145a0dbb5053af38028cbb25e6bbaee86430073 /configure.ac | |
| parent | 6a00d6e074287d112575b3eba6e575504bd9f069 (diff) | |
Remove HAVE_GCC_VISIBILITY_BROKEN, never true
The check for broken -fvisiblity-inlines-hidden doesn't mention a specific bug.
Its roots date back to 072e89cf68dcf9b6713945e402dd7a9fe5cea48d "INTEGRATION:
CWS newportstl" of the --with(out)-stlport area. Lets assume whatever failure
is long since fixed.
Make this a fatal configure error for now. The check should be removed
completely after LO 5.3 branch-off.
Change-Id: I7c64c2e8b9bd342beec9b84ff71f5712a6155b7d
Reviewed-on: https://gerrit.libreoffice.org/29075
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'configure.ac')
| -rw-r--r-- | configure.ac | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/configure.ac b/configure.ac index e9366b134e0a..4afb8d1d35a9 100644 --- a/configure.ac +++ b/configure.ac @@ -6476,7 +6476,6 @@ AC_SUBST([HAVE_GCC_FNO_SIZED_DEALLOCATION]) dnl =================================================================== dnl system stl sanity tests dnl =================================================================== -HAVE_GCC_VISIBILITY_BROKEN= if test \( "$_os" != "WINNT" -o "$WITH_MINGW" = "yes" \); then AC_LANG_PUSH([C++]) @@ -6518,16 +6517,14 @@ istringstream strm( "test" ); return 0; ]) AC_MSG_RESULT([$gccvisok]) if test "$gccvisok" = "no"; then - AC_MSG_WARN([Your gcc is not -fvisibility-inlines-hidden safe, disabling that.]) - add_warning "Your gcc is not -fvisibility-inlines-hidden safe, disabling that." - HAVE_GCC_VISIBILITY_BROKEN="TRUE" + AC_MSG_ERROR([Your gcc is not -fvisibility-inlines-hidden safe. This is no longer supported.]) fi LDFLAGS=$sharedlink_ldflags_save # As the below test checks things when linking self-compiled dynamic libraries, it presumably is irrelevant # when we don't make any dynamic libraries? - if test "$DISABLE_DYNLOADING" = "" -a "$HAVE_GCC_VISIBILITY_BROKEN" != "TRUE"; then + if test "$DISABLE_DYNLOADING" = ""; then AC_MSG_CHECKING([if gcc is -fvisibility-inlines-hidden safe (Clang bug 11250)]) cat > conftestlib1.cc <<_ACEOF template<typename T> struct S1 { virtual ~S1() {} virtual void f() {} }; @@ -6611,8 +6608,6 @@ _ACEOF AC_LANG_POP([C++]) fi -AC_SUBST(HAVE_GCC_VISIBILITY_BROKEN) - dnl =================================================================== dnl Clang++ tests dnl =================================================================== |