diff options
author | Noel Grandin <noel@peralex.com> | 2014-11-18 10:01:21 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2014-11-18 12:44:28 +0200 |
commit | 0063cf285696951e336b9cec1da8881997b286ce (patch) | |
tree | be70dfd8127c35f9e4a6d18d4db459a587813bf4 /connectivity/qa | |
parent | 250391009aec9930abcc57930ddd4b6f56f4df9c (diff) |
java: make fields final where possible
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
Diffstat (limited to 'connectivity/qa')
5 files changed, 12 insertions, 12 deletions
diff --git a/connectivity/qa/complex/connectivity/hsqldb/DatabaseMetaData.java b/connectivity/qa/complex/connectivity/hsqldb/DatabaseMetaData.java index 457b037c74fb..905ddc1e50e6 100644 --- a/connectivity/qa/complex/connectivity/hsqldb/DatabaseMetaData.java +++ b/connectivity/qa/complex/connectivity/hsqldb/DatabaseMetaData.java @@ -30,8 +30,8 @@ import java.lang.reflect.Method; public class DatabaseMetaData { - private java.sql.DatabaseMetaData m_xMD; - private HsqlDriverTest m_TestCase; + private final java.sql.DatabaseMetaData m_xMD; + private final HsqlDriverTest m_TestCase; /** Creates a new instance of DatabaseMetaData */ public DatabaseMetaData(HsqlDriverTest _testCase,java.sql.DatabaseMetaData _xmd) { diff --git a/connectivity/qa/connectivity/tools/DataSource.java b/connectivity/qa/connectivity/tools/DataSource.java index 6b6048c44a96..748ee61cdefe 100644 --- a/connectivity/qa/connectivity/tools/DataSource.java +++ b/connectivity/qa/connectivity/tools/DataSource.java @@ -36,7 +36,7 @@ public class DataSource { // the service factory - private XDataSource m_dataSource; + private final XDataSource m_dataSource; public DataSource(final XMultiServiceFactory _orb, final String _registeredName) throws Exception { diff --git a/connectivity/qa/connectivity/tools/HsqlColumnDescriptor.java b/connectivity/qa/connectivity/tools/HsqlColumnDescriptor.java index 19fb59ce7427..5d9311882379 100644 --- a/connectivity/qa/connectivity/tools/HsqlColumnDescriptor.java +++ b/connectivity/qa/connectivity/tools/HsqlColumnDescriptor.java @@ -22,12 +22,12 @@ package connectivity.tools; */ public class HsqlColumnDescriptor { - private String Name; - private String TypeName; - private boolean Required; - private boolean PrimaryKey; - private String ForeignTable; - private String ForeignColumn; + private final String Name; + private final String TypeName; + private final boolean Required; + private final boolean PrimaryKey; + private final String ForeignTable; + private final String ForeignColumn; public final String getName() { return Name; } public final String getTypeName() { return TypeName; } diff --git a/connectivity/qa/connectivity/tools/HsqlTableDescriptor.java b/connectivity/qa/connectivity/tools/HsqlTableDescriptor.java index 992619b7c675..626f62eb8321 100644 --- a/connectivity/qa/connectivity/tools/HsqlTableDescriptor.java +++ b/connectivity/qa/connectivity/tools/HsqlTableDescriptor.java @@ -31,8 +31,8 @@ import connectivity.tools.sdb.Connection; */ public class HsqlTableDescriptor { - private String m_name; - private HsqlColumnDescriptor[] m_columns; + private final String m_name; + private final HsqlColumnDescriptor[] m_columns; /** Creates a new instance of HsqlTableDescriptor */ public HsqlTableDescriptor( String _name, HsqlColumnDescriptor[] _columns ) diff --git a/connectivity/qa/connectivity/tools/QueryDefinition.java b/connectivity/qa/connectivity/tools/QueryDefinition.java index ab5fe513988f..b939fdbb22e3 100644 --- a/connectivity/qa/connectivity/tools/QueryDefinition.java +++ b/connectivity/qa/connectivity/tools/QueryDefinition.java @@ -26,7 +26,7 @@ import com.sun.star.lang.IllegalArgumentException; public class QueryDefinition { - private XPropertySet m_queryDef; + private final XPropertySet m_queryDef; public QueryDefinition( XPropertySet _queryDef ) { |