diff options
| author | Radu Ioan <ioan.radu.g@gmail.com> | 2015-02-14 00:31:54 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2015-02-17 06:15:54 +0000 |
| commit | a8e6f0bea0e8bc028ee64d0b4d9046e52de94eda (patch) | |
| tree | 49a2e34d88c5a0eb9d8a6a74e818d6597482fe36 /connectivity/source/drivers/jdbc/PreparedStatement.cxx | |
| parent | a30e2cb912c6bae240ced35a392151e34090665b (diff) | |
tdf#39440 - cppcheck cleanliness
Fixed some cppcheck defects
Change-Id: I25fd6aba9d76df98d20b9a1bb4c9d3c1bf6f84bb
Reviewed-on: https://gerrit.libreoffice.org/14487
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'connectivity/source/drivers/jdbc/PreparedStatement.cxx')
| -rw-r--r-- | connectivity/source/drivers/jdbc/PreparedStatement.cxx | 28 |
1 files changed, 18 insertions, 10 deletions
diff --git a/connectivity/source/drivers/jdbc/PreparedStatement.cxx b/connectivity/source/drivers/jdbc/PreparedStatement.cxx index 427931e2b2e8..5b14f1d52c2d 100644 --- a/connectivity/source/drivers/jdbc/PreparedStatement.cxx +++ b/connectivity/source/drivers/jdbc/PreparedStatement.cxx @@ -470,13 +470,15 @@ void SAL_CALL java_sql_PreparedStatement::setCharacterStream( sal_Int32 paramete args2[0].l = pByteArray; args2[1].i = 0; args2[2].i = actualLength; - // initialize temporary variable - const char * cSignatureStream = "([BII)V"; // Java-Call jclass aClass = t.pEnv->FindClass("java/io/CharArrayInputStream"); static jmethodID mID2 = NULL; - if ( !mID2 ) + if ( !mID2 ) + { + // initialize temporary variable + const char * cSignatureStream = "([BII)V"; mID2 = t.pEnv->GetMethodID( aClass, "<init>", cSignatureStream ); + } jobject tempObj = NULL; if(mID2) tempObj = t.pEnv->NewObjectA( aClass, mID2, args2 ); @@ -519,13 +521,15 @@ void SAL_CALL java_sql_PreparedStatement::setBinaryStream( sal_Int32 parameterIn args2[1].i = 0; args2[2].i = (sal_Int32)actualLength; - // initialize temporary variable - const char * cSignatureStream = "([BII)V"; // Java-Call jclass aClass = t.pEnv->FindClass("java/io/ByteArrayInputStream"); static jmethodID mID2 = NULL; - if ( !mID2 ) + if ( !mID2 ) + { + // initialize temporary variable + const char * cSignatureStream = "([BII)V"; mID2 = t.pEnv->GetMethodID( aClass, "<init>", cSignatureStream ); + } jobject tempObj = NULL; if(mID2) tempObj = t.pEnv->NewObjectA( aClass, mID2, args2 ); @@ -629,7 +633,6 @@ void java_sql_PreparedStatement::createStatement(JNIEnv* _pEnv) if( !object && _pEnv ){ // initialize temporary variable - static const char * cSignature = "(Ljava/lang/String;II)Ljava/sql/PreparedStatement;"; static const char * cMethodName = "prepareStatement"; jvalue args[1]; @@ -638,18 +641,23 @@ void java_sql_PreparedStatement::createStatement(JNIEnv* _pEnv) // Java-Call jobject out = NULL; static jmethodID mID(NULL); - if ( !mID ) + if ( !mID ) + { + static const char * cSignature = "(Ljava/lang/String;II)Ljava/sql/PreparedStatement;"; mID = _pEnv->GetMethodID( m_pConnection->getMyClass(), cMethodName, cSignature ); + } if( mID ) { out = _pEnv->CallObjectMethod( m_pConnection->getJavaObject(), mID, args[0].l ,m_nResultSetType,m_nResultSetConcurrency); } else { - static const char * cSignature2 = "(Ljava/lang/String;)Ljava/sql/PreparedStatement;"; static jmethodID mID2 = NULL; - if ( !mID2) + if ( !mID2 ) + { + static const char * cSignature2 = "(Ljava/lang/String;)Ljava/sql/PreparedStatement;"; mID2 = _pEnv->GetMethodID( m_pConnection->getMyClass(), cMethodName, cSignature2 ); + } if ( mID2 ) out = _pEnv->CallObjectMethod( m_pConnection->getJavaObject(), mID2, args[0].l ); } |