summaryrefslogtreecommitdiff
path: root/connectivity/source
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2019-10-14 14:27:57 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2019-10-15 14:33:57 +0200
commitf13c6ad5f020a196a0e3aa6f28bda3dc185d465b (patch)
treef9aaab122974d36c134fb1723ec3c1c8df51eeef /connectivity/source
parent9270f74466d0eb841babaa24997f608631c70341 (diff)
new loplugin:bufferadd
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'connectivity/source')
-rw-r--r--connectivity/source/drivers/hsqldb/HConnection.cxx8
-rw-r--r--connectivity/source/drivers/hsqldb/HView.cxx13
-rw-r--r--connectivity/source/drivers/postgresql/pq_xcolumns.cxx11
-rw-r--r--connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx7
-rw-r--r--connectivity/source/drivers/postgresql/pq_xindexes.cxx11
-rw-r--r--connectivity/source/drivers/postgresql/pq_xkeycolumns.cxx11
6 files changed, 25 insertions, 36 deletions
diff --git a/connectivity/source/drivers/hsqldb/HConnection.cxx b/connectivity/source/drivers/hsqldb/HConnection.cxx
index 22fcdaa466e2..af6f49afee17 100644
--- a/connectivity/source/drivers/hsqldb/HConnection.cxx
+++ b/connectivity/source/drivers/hsqldb/HConnection.cxx
@@ -316,13 +316,11 @@ namespace connectivity { namespace hsqldb
xProvider.set( GraphicProvider::create(m_xContext) );
// assemble the image URL
- OUStringBuffer aImageURL;
+ OUString sImageURL =
// load the graphic from the global graphic repository
- aImageURL.append( "private:graphicrepository/" );
+ "private:graphicrepository/"
// the relative path within the images.zip
- aImageURL.append( LINKED_TEXT_TABLE_IMAGE_RESOURCE );
- // the name of the graphic to use
- OUString sImageURL( aImageURL.makeStringAndClear() );
+ LINKED_TEXT_TABLE_IMAGE_RESOURCE;
// ask the provider to obtain a graphic
Sequence< PropertyValue > aMediaProperties( 1 );
diff --git a/connectivity/source/drivers/hsqldb/HView.cxx b/connectivity/source/drivers/hsqldb/HView.cxx
index 810acdf08561..0eb3fd9439e4 100644
--- a/connectivity/source/drivers/hsqldb/HView.cxx
+++ b/connectivity/source/drivers/hsqldb/HView.cxx
@@ -102,18 +102,13 @@ namespace connectivity { namespace hsqldb
try
{
// drop the existing view
- OUStringBuffer aCommand;
- aCommand.append( "DROP VIEW " );
- aCommand.append ( sQualifiedName );
- xStatement->execute( aCommand.makeStringAndClear() );
+ OUString aCommand ="DROP VIEW " + sQualifiedName;
+ xStatement->execute( aCommand );
bDropSucceeded = true;
// create a new one with the same name
- aCommand.append( "CREATE VIEW " );
- aCommand.append ( sQualifiedName );
- aCommand.append( " AS " );
- aCommand.append ( _rNewCommand );
- xStatement->execute( aCommand.makeStringAndClear() );
+ aCommand = "CREATE VIEW " + sQualifiedName + " AS " + _rNewCommand;
+ xStatement->execute( aCommand );
}
catch( const SQLException& )
{
diff --git a/connectivity/source/drivers/postgresql/pq_xcolumns.cxx b/connectivity/source/drivers/postgresql/pq_xcolumns.cxx
index b5fcd1d0261a..95332e360522 100644
--- a/connectivity/source/drivers/postgresql/pq_xcolumns.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xcolumns.cxx
@@ -280,12 +280,11 @@ void Columns::refresh()
{
if (isLog(m_pSettings, LogLevel::Info))
{
- OStringBuffer buf;
- buf.append( "sdbcx.Columns get refreshed for table " );
- buf.append( OUStringToOString( m_schemaName, ConnectionSettings::encoding ) );
- buf.append( "." );
- buf.append( OUStringToOString( m_tableName, ConnectionSettings::encoding ) );
- log( m_pSettings, LogLevel::Info, buf.makeStringAndClear().getStr() );
+ OString buf = "sdbcx.Columns get refreshed for table " +
+ OUStringToOString( m_schemaName, ConnectionSettings::encoding ) +
+ "." +
+ OUStringToOString( m_tableName, ConnectionSettings::encoding );
+ log( m_pSettings, LogLevel::Info, buf.getStr() );
}
osl::MutexGuard guard( m_xMutex->GetMutex() );
diff --git a/connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx b/connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx
index 5717c03dcd17..a80c3952b255 100644
--- a/connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx
@@ -104,10 +104,9 @@ void IndexColumns::refresh()
{
if (isLog(m_pSettings, LogLevel::Info))
{
- OStringBuffer buf;
- buf.append( "sdbcx.IndexColumns get refreshed for index " );
- buf.append( OUStringToOString( m_indexName, ConnectionSettings::encoding ) );
- log( m_pSettings, LogLevel::Info, buf.makeStringAndClear().getStr() );
+ OString buf = "sdbcx.IndexColumns get refreshed for index " +
+ OUStringToOString( m_indexName, ConnectionSettings::encoding );
+ log( m_pSettings, LogLevel::Info, buf.getStr() );
}
osl::MutexGuard guard( m_xMutex->GetMutex() );
diff --git a/connectivity/source/drivers/postgresql/pq_xindexes.cxx b/connectivity/source/drivers/postgresql/pq_xindexes.cxx
index 705ffefa818e..aa8d3036b9a9 100644
--- a/connectivity/source/drivers/postgresql/pq_xindexes.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xindexes.cxx
@@ -96,12 +96,11 @@ void Indexes::refresh()
{
if (isLog(m_pSettings, LogLevel::Info))
{
- OStringBuffer buf;
- buf.append( "sdbcx.Indexes get refreshed for table " );
- buf.append( OUStringToOString( m_schemaName, ConnectionSettings::encoding ) );
- buf.append( "." );
- buf.append( OUStringToOString( m_tableName, ConnectionSettings::encoding ) );
- log( m_pSettings, LogLevel::Info, buf.makeStringAndClear().getStr() );
+ OString buf = "sdbcx.Indexes get refreshed for table " +
+ OUStringToOString( m_schemaName, ConnectionSettings::encoding ) +
+ "." +
+ OUStringToOString( m_tableName, ConnectionSettings::encoding );
+ log( m_pSettings, LogLevel::Info, buf.getStr() );
}
osl::MutexGuard guard( m_xMutex->GetMutex() );
diff --git a/connectivity/source/drivers/postgresql/pq_xkeycolumns.cxx b/connectivity/source/drivers/postgresql/pq_xkeycolumns.cxx
index fdc74afd6e45..39a2c292da33 100644
--- a/connectivity/source/drivers/postgresql/pq_xkeycolumns.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xkeycolumns.cxx
@@ -92,12 +92,11 @@ void KeyColumns::refresh()
{
if (isLog(m_pSettings, LogLevel::Info))
{
- OStringBuffer buf;
- buf.append( "sdbcx.KeyColumns get refreshed for table " );
- buf.append( OUStringToOString( m_schemaName, ConnectionSettings::encoding ) );
- buf.append( "." );
- buf.append( OUStringToOString( m_tableName, ConnectionSettings::encoding ) );
- log( m_pSettings, LogLevel::Info, buf.makeStringAndClear().getStr() );
+ OString buf = "sdbcx.KeyColumns get refreshed for table " +
+ OUStringToOString( m_schemaName, ConnectionSettings::encoding ) +
+ "." +
+ OUStringToOString( m_tableName, ConnectionSettings::encoding );
+ log( m_pSettings, LogLevel::Info, buf.getStr() );
}
osl::MutexGuard guard( m_xMutex->GetMutex() );