diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-28 13:48:31 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-12-29 08:00:29 +0100 |
| commit | 31f71635a136daf36d554e0c20db9ae0d1686c23 (patch) | |
| tree | ba4150e1c999a15362faa18863a4a5105bd5a8d7 /connectivity/source | |
| parent | 38f5e768b0f858f8f990a8f297396821c75d45dc (diff) | |
loplugin:passstuffbyref improved return in ucb,connectivity
Change-Id: Ib2590648c9dced87693a58a506cb62d04e37b18d
Reviewed-on: https://gerrit.libreoffice.org/47149
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'connectivity/source')
4 files changed, 8 insertions, 8 deletions
diff --git a/connectivity/source/commontools/RowFunctionParser.cxx b/connectivity/source/commontools/RowFunctionParser.cxx index 2b3fa75b324c..afdbac9c9a52 100644 --- a/connectivity/source/commontools/RowFunctionParser.cxx +++ b/connectivity/source/commontools/RowFunctionParser.cxx @@ -400,7 +400,7 @@ const ParserContextSharedPtr& getParserContext() } -std::shared_ptr<ExpressionNode> FunctionParser::parseFunction( const OUString& _sFunction) +std::shared_ptr<ExpressionNode> const & FunctionParser::parseFunction( const OUString& _sFunction) { // TODO(Q1): Check if a combination of the RTL_UNICODETOTEXT_FLAGS_* // gives better conversion robustness here (we might want to map space diff --git a/connectivity/source/commontools/TTableHelper.cxx b/connectivity/source/commontools/TTableHelper.cxx index a30a19985394..2124e3366b08 100644 --- a/connectivity/source/commontools/TTableHelper.cxx +++ b/connectivity/source/commontools/TTableHelper.cxx @@ -594,27 +594,27 @@ OUString OTableHelper::getTypeCreatePattern() const return OUString(); } -Reference< XConnection> OTableHelper::getConnection() const +Reference< XConnection> const & OTableHelper::getConnection() const { return m_pImpl->m_xConnection; } -Reference< css::sdb::tools::XTableRename> OTableHelper::getRenameService() const +Reference< css::sdb::tools::XTableRename> const & OTableHelper::getRenameService() const { return m_pImpl->m_xRename; } -Reference< css::sdb::tools::XTableAlteration> OTableHelper::getAlterService() const +Reference< css::sdb::tools::XTableAlteration> const & OTableHelper::getAlterService() const { return m_pImpl->m_xAlter; } -Reference< css::sdb::tools::XKeyAlteration> OTableHelper::getKeyService() const +Reference< css::sdb::tools::XKeyAlteration> const & OTableHelper::getKeyService() const { return m_pImpl->m_xKeyAlter; } -Reference< css::sdb::tools::XIndexAlteration> OTableHelper::getIndexService() const +Reference< css::sdb::tools::XIndexAlteration> const & OTableHelper::getIndexService() const { return m_pImpl->m_xIndexAlter; } diff --git a/connectivity/source/commontools/statementcomposer.cxx b/connectivity/source/commontools/statementcomposer.cxx index f72afe40f2c1..499e7f167e39 100644 --- a/connectivity/source/commontools/statementcomposer.cxx +++ b/connectivity/source/commontools/statementcomposer.cxx @@ -266,7 +266,7 @@ namespace dbtools } - Reference< XSingleSelectQueryComposer > StatementComposer::getComposer() + Reference< XSingleSelectQueryComposer > const & StatementComposer::getComposer() { lcl_ensureUpToDateComposer_nothrow( *m_pData ); return m_pData->xComposer; diff --git a/connectivity/source/inc/RowFunctionParser.hxx b/connectivity/source/inc/RowFunctionParser.hxx index df2c7ba2bf4e..b338d34e2cfe 100644 --- a/connectivity/source/inc/RowFunctionParser.hxx +++ b/connectivity/source/inc/RowFunctionParser.hxx @@ -97,7 +97,7 @@ public: @return the generated function object. */ - static std::shared_ptr<ExpressionNode> parseFunction( const OUString& _sFunction); + static std::shared_ptr<ExpressionNode> const & parseFunction( const OUString& _sFunction); private: // disabled constructor/destructor, since this is |