diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-11-24 13:11:22 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-11-24 13:56:23 +0100 |
| commit | dc4ee83823d6cb94a507e2ebb9cc8eb56a6a3fa6 (patch) | |
| tree | 78a51a6a1cbc2d95366acaa7db4f28c9c516435b /connectivity/source | |
| parent | 1f106552e07dfdaf6262cef731ff301683a43570 (diff) | |
loplugin:stringliteraldefine in connectivity
Change-Id: I6b2528c684fe56a114959a1d26101a882eee2106
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125759
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'connectivity/source')
| -rw-r--r-- | connectivity/source/commontools/dbtools2.cxx | 7 | ||||
| -rw-r--r-- | connectivity/source/drivers/evoab2/NDriver.hxx | 2 | ||||
| -rw-r--r-- | connectivity/source/inc/dbase/DIndex.hxx | 2 |
3 files changed, 8 insertions, 3 deletions
diff --git a/connectivity/source/commontools/dbtools2.cxx b/connectivity/source/commontools/dbtools2.cxx index 5f07a272cec2..a04015754374 100644 --- a/connectivity/source/commontools/dbtools2.cxx +++ b/connectivity/source/commontools/dbtools2.cxx @@ -574,6 +574,11 @@ Reference<XPropertySet> createSDBCXColumn(const Reference<XPropertySet>& _xTable bool getBooleanDataSourceSetting( const Reference< XConnection >& _rxConnection, const char* _pAsciiSettingName ) { + return getBooleanDataSourceSetting(_rxConnection, OUString::createFromAscii( _pAsciiSettingName )); +} + +bool getBooleanDataSourceSetting( const Reference< XConnection >& _rxConnection, const OUString & rSettingName ) +{ bool bValue( false ); try { @@ -585,7 +590,7 @@ bool getBooleanDataSourceSetting( const Reference< XConnection >& _rxConnection, xDataSourceProperties->getPropertyValue("Settings"), UNO_QUERY_THROW ); - OSL_VERIFY( xSettings->getPropertyValue( OUString::createFromAscii( _pAsciiSettingName ) ) >>= bValue ); + OSL_VERIFY( xSettings->getPropertyValue( rSettingName ) >>= bValue ); } } catch( const Exception& ) diff --git a/connectivity/source/drivers/evoab2/NDriver.hxx b/connectivity/source/drivers/evoab2/NDriver.hxx index 9015add76be8..9d3b57fa7988 100644 --- a/connectivity/source/drivers/evoab2/NDriver.hxx +++ b/connectivity/source/drivers/evoab2/NDriver.hxx @@ -28,7 +28,7 @@ #include <cppuhelper/compbase.hxx> #include <connectivity/CommonTools.hxx> -#define EVOAB_DRIVER_IMPL_NAME "com.sun.star.comp.sdbc.evoab.OEvoabDriver" +inline constexpr OUStringLiteral EVOAB_DRIVER_IMPL_NAME = u"com.sun.star.comp.sdbc.evoab.OEvoabDriver"; namespace connectivity::evoab { diff --git a/connectivity/source/inc/dbase/DIndex.hxx b/connectivity/source/inc/dbase/DIndex.hxx index e936a7e37c65..a75ce918ff6c 100644 --- a/connectivity/source/inc/dbase/DIndex.hxx +++ b/connectivity/source/inc/dbase/DIndex.hxx @@ -23,7 +23,7 @@ #include <dbase/DTable.hxx> #include <dbase/dindexnode.hxx> -#define dBASE_III_GROUP "dBase III" +inline constexpr OStringLiteral dBASE_III_GROUP = "dBase III"; namespace connectivity::dbase { |