loplugin:unusedfields look for classes where we can make all the..

fields private

Change-Id: Id3c6b123f06ab5dcf87628de4c347626110d2d27
Reviewed-on: https://gerrit.libreoffice.org/68302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

7 files changed, 6 insertions, 10 deletions

diff --git a/connectivity/source/drivers/firebird/Catalog.hxx b/connectivity/source/drivers/firebird/Catalog.hxx
index 351069c80a72..a8ee9c69b466 100644
--- a/connectivity/source/drivers/firebird/Catalog.hxx
+++ b/connectivity/source/drivers/firebird/Catalog.hxx
@@ -18,7 +18,6 @@ namespace connectivity
     {
         class Catalog: public ::connectivity::sdbcx::OCatalog
         {
-        protected:
             css::uno::Reference< css::sdbc::XConnection >
                 m_xConnection;
 
diff --git a/connectivity/source/drivers/firebird/Statement.hxx b/connectivity/source/drivers/firebird/Statement.hxx
index 56b1ae7edde5..83add5821100 100644
--- a/connectivity/source/drivers/firebird/Statement.hxx
+++ b/connectivity/source/drivers/firebird/Statement.hxx
@@ -37,11 +37,10 @@ namespace connectivity
                             public css::sdbc::XBatchExecution,
                             public css::lang::XServiceInfo
         {
+            XSQLDA* m_pSqlda;
         protected:
             virtual ~OStatement() override {}
 
-            XSQLDA* m_pSqlda;
-
         public:
             // a constructor, which is required for returning objects:
             explicit OStatement( Connection* _pConnection)
diff --git a/connectivity/source/drivers/firebird/Users.hxx b/connectivity/source/drivers/firebird/Users.hxx
index 69cf571154cb..9112d12a7c75 100644
--- a/connectivity/source/drivers/firebird/Users.hxx
+++ b/connectivity/source/drivers/firebird/Users.hxx
@@ -24,9 +24,9 @@ namespace connectivity
          */
         class Users: public ::connectivity::sdbcx::OCollection
         {
-        protected:
             css::uno::Reference< css::sdbc::XDatabaseMetaData >
                 m_xMetaData;
+        protected:
 
             // OCollection
             virtual void impl_refresh() override;
diff --git a/connectivity/source/inc/file/fcode.hxx b/connectivity/source/inc/file/fcode.hxx
index da0670f4e1da..77bc2a199ee1 100644
--- a/connectivity/source/inc/file/fcode.hxx
+++ b/connectivity/source/inc/file/fcode.hxx
@@ -76,9 +76,9 @@ namespace connectivity
         class OOO_DLLPUBLIC_FILE OOperandRow : public OOperand
         {
             sal_uInt16  m_nRowPos;
-        protected:
             OValueRefRow    m_pRow;
 
+        protected:
             OOperandRow(sal_uInt16 _nPos, sal_Int32 _rType);
         public:
             virtual const ORowSetValue& getValue() const override;
@@ -230,8 +230,6 @@ namespace connectivity
 
         class OOO_DLLPUBLIC_FILE OOp_LIKE : public OBoolOperator
         {
-        public:
-        protected:
             const sal_Unicode cEscape;
 
         public:
diff --git a/connectivity/source/inc/hsqldb/HUser.hxx b/connectivity/source/inc/hsqldb/HUser.hxx
index 4e1e98c92290..6b93707ee06b 100644
--- a/connectivity/source/inc/hsqldb/HUser.hxx
+++ b/connectivity/source/inc/hsqldb/HUser.hxx
@@ -59,8 +59,8 @@ namespace connectivity
         class OUserExtend : public OHSQLUser,
                             public OUserExtend_PROP
         {
-        protected:
             OUString m_Password;
+        protected:
             // OPropertyArrayUsageHelper
             virtual ::cppu::IPropertyArrayHelper* createArrayHelper() const override;
             // OPropertySetHelper
diff --git a/connectivity/source/inc/mysql/YUser.hxx b/connectivity/source/inc/mysql/YUser.hxx
index 58589f414c64..d05fb8ea6053 100644
--- a/connectivity/source/inc/mysql/YUser.hxx
+++ b/connectivity/source/inc/mysql/YUser.hxx
@@ -59,8 +59,8 @@ namespace connectivity
         class OUserExtend : public OMySQLUser,
                             public OUserExtend_PROP
         {
-        protected:
             OUString m_Password;
+        protected:
             // OPropertyArrayUsageHelper
             virtual ::cppu::IPropertyArrayHelper* createArrayHelper() const override;
             // OPropertySetHelper
diff --git a/connectivity/source/inc/odbc/OBoundParam.hxx b/connectivity/source/inc/odbc/OBoundParam.hxx
index 5eeeda4ae947..41ddf5076ae4 100644
--- a/connectivity/source/inc/odbc/OBoundParam.hxx
+++ b/connectivity/source/inc/odbc/OBoundParam.hxx
@@ -102,7 +102,7 @@ namespace connectivity
             }
 
 
-        protected:
+        private:
 
             // Data attributes