diff options
| author | Tamas Bunth <tamas.bunth@collabora.co.uk> | 2017-12-09 00:47:13 +0100 |
|---|---|---|
| committer | Andras Timar <andras.timar@collabora.com> | 2018-03-19 14:56:17 +0100 |
| commit | 5f19a29d3a2bf78ea39d9c759e15c2274235b012 (patch) | |
| tree | 03ba596fa95f42ce6ed68f707ccffef485a5c630 /connectivity | |
| parent | 5a5fce18871dac91cf485030b915d674948cd95e (diff) | |
tdf#70425 do not close cursor explicitly
A cursor need only be closed in this manner if it was previously
opened and associated with stmt_handle by isc_dsql_set_cursor_name()
See Interbase API Guide: isc_dsql_free_statement
Reviewed-on: https://gerrit.libreoffice.org/46132
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Bunth <btomi96@gmail.com>
(cherry picked from commit 9585521c28b74dec36522a6501ca670b8e14c7ca)
Change-Id: Iadb0dcf83ee58b6196112c44d922528a3f56f7ea
Diffstat (limited to 'connectivity')
| -rw-r--r-- | connectivity/source/drivers/firebird/PreparedStatement.cxx | 15 |
1 files changed, 0 insertions, 15 deletions
diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx b/connectivity/source/drivers/firebird/PreparedStatement.cxx index 74969278b16f..926810783e67 100644 --- a/connectivity/source/drivers/firebird/PreparedStatement.cxx +++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx @@ -250,21 +250,6 @@ sal_Bool SAL_CALL OPreparedStatement::execute() if (m_xResultSet.is()) // Checks whether we have already run the statement. { disposeResultSet(); - // Closes the cursor from the last run. - // This doesn't actually free the statement -- using DSQL_close closes - // the cursor and keeps the statement, using DSQL_drop frees the statement - // (and associated cursors). - aErr = isc_dsql_free_statement(m_statusVector, - &m_aStatementHandle, - DSQL_close); - if (aErr) - { - // Do not throw error. Trying to close a closed cursor is not a - // critical mistake. - OUString sErrMsg = StatusVectorToString(m_statusVector, - "isc_dsql_free_statement: close cursor"); - SAL_WARN("connectivity.firebird", sErrMsg); - } } aErr = isc_dsql_execute(m_statusVector, |