improve passstuffbyref return analysis

Change-Id: I4258bcc97273d8bb7a8c4879fac02a427f76e18c
Reviewed-on: https://gerrit.libreoffice.org/27317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

15 files changed, 43 insertions, 43 deletions

diff --git a/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx b/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
index 3337bd12ad79..3e68e4a1c8e8 100644
--- a/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
+++ b/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
@@ -666,82 +666,82 @@ const ORowSetValue& ODatabaseMetaDataResultSet::getValue(sal_Int32 columnIndex)
 }
 
 /// return an empty ORowSetValueDecorator
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getEmptyValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getEmptyValue()
 {
     static ORowSetValueDecoratorRef aEmptyValueRef = new ORowSetValueDecorator();
     return aEmptyValueRef;
 }
 
 /// return an ORowSetValueDecorator with 0 as value
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::get0Value()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::get0Value()
 {
     static ORowSetValueDecoratorRef a0ValueRef = new ORowSetValueDecorator((sal_Int32)0);
     return a0ValueRef;
 }
 
 /// return an ORowSetValueDecorator with 1 as value
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::get1Value()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::get1Value()
 {
     static ORowSetValueDecoratorRef a1ValueRef = new ORowSetValueDecorator((sal_Int32)1);
     return a1ValueRef;
 }
 
 /// return an ORowSetValueDecorator with ColumnSearch::BASIC as value
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getBasicValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getBasicValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(ColumnSearch::BASIC);
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getSelectValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getSelectValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("SELECT"));
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getInsertValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getInsertValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("INSERT"));
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getDeleteValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getDeleteValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("DELETE"));
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getUpdateValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getUpdateValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("UPDATE"));
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getCreateValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getCreateValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("CREATE"));
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getReadValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getReadValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("READ"));
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getAlterValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getAlterValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("ALTER"));
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getDropValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getDropValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("DROP"));
     return aValueRef;
 }
 
-ORowSetValueDecoratorRef ODatabaseMetaDataResultSet::getQuoteValue()
+ORowSetValueDecoratorRef const & ODatabaseMetaDataResultSet::getQuoteValue()
 {
     static ORowSetValueDecoratorRef aValueRef = new ORowSetValueDecorator(OUString("'"));
     return aValueRef;
diff --git a/connectivity/source/commontools/dbconversion.cxx b/connectivity/source/commontools/dbconversion.cxx
index 1646b64ce255..63dc30858339 100644
--- a/connectivity/source/commontools/dbconversion.cxx
+++ b/connectivity/source/commontools/dbconversion.cxx
@@ -58,7 +58,7 @@ namespace dbtools
     using namespace ::com::sun::star::beans;
 
 
-    css::util::Date DBTypeConversion::getStandardDate()
+    css::util::Date const & DBTypeConversion::getStandardDate()
     {
         static css::util::Date STANDARD_DB_DATE(1,1,1900);
         return STANDARD_DB_DATE;
diff --git a/connectivity/source/cpool/ZPoolCollection.cxx b/connectivity/source/cpool/ZPoolCollection.cxx
index 9dd861d33854..ad462ea596b6 100644
--- a/connectivity/source/cpool/ZPoolCollection.cxx
+++ b/connectivity/source/cpool/ZPoolCollection.cxx
@@ -249,7 +249,7 @@ bool OPoolCollection::isPoolingEnabled()
     return bEnabled;
 }
 
-Reference<XInterface> OPoolCollection::getConfigPoolRoot()
+Reference<XInterface> const & OPoolCollection::getConfigPoolRoot()
 {
     if(!m_xConfigNode.is())
         m_xConfigNode = createWithServiceFactory(getConnectionPoolNodeName());
diff --git a/connectivity/source/cpool/ZPoolCollection.hxx b/connectivity/source/cpool/ZPoolCollection.hxx
index ff31c6c38435..25c3f5a934d1 100644
--- a/connectivity/source/cpool/ZPoolCollection.hxx
+++ b/connectivity/source/cpool/ZPoolCollection.hxx
@@ -86,7 +86,7 @@ namespace connectivity
 
         // some configuration helper methods
         css::uno::Reference< css::uno::XInterface > createWithServiceFactory(const OUString& _rPath) const;
-        css::uno::Reference< css::uno::XInterface > getConfigPoolRoot();
+        css::uno::Reference< css::uno::XInterface > const & getConfigPoolRoot();
         static css::uno::Reference< css::uno::XInterface > createWithProvider(   const css::uno::Reference< css::lang::XMultiServiceFactory >& _rxConfProvider,
                                                                                                     const OUString& _rPath);
         static css::uno::Reference< css::uno::XInterface > openNode( const OUString& _rPath,
diff --git a/connectivity/source/drivers/calc/CConnection.cxx b/connectivity/source/drivers/calc/CConnection.cxx
index f2cfdf2c41f7..0d32d31a7bb0 100644
--- a/connectivity/source/drivers/calc/CConnection.cxx
+++ b/connectivity/source/drivers/calc/CConnection.cxx
@@ -101,7 +101,7 @@ void OCalcConnection::construct(const OUString& url,const Sequence< PropertyValu
     acquireDoc();
 }
 
-Reference< XSpreadsheetDocument> OCalcConnection::acquireDoc()
+Reference< XSpreadsheetDocument> const & OCalcConnection::acquireDoc()
 {
     if ( m_xDoc.is() )
     {
diff --git a/connectivity/source/drivers/dbase/DIndex.cxx b/connectivity/source/drivers/dbase/DIndex.cxx
index f384a89b1da7..f5f4c4993906 100644
--- a/connectivity/source/drivers/dbase/DIndex.cxx
+++ b/connectivity/source/drivers/dbase/DIndex.cxx
@@ -130,7 +130,7 @@ sal_Int64 ODbaseIndex::getSomething( const Sequence< sal_Int8 > & rId ) throw (R
                 : ODbaseIndex_BASE::getSomething(rId);
 }
 
-ONDXPagePtr ODbaseIndex::getRoot()
+ONDXPagePtr const & ODbaseIndex::getRoot()
 {
     openIndexFile();
     if (!m_aRoot.Is())
diff --git a/connectivity/source/drivers/hsqldb/HDriver.cxx b/connectivity/source/drivers/hsqldb/HDriver.cxx
index 1a0ef32a0551..3da41939886d 100644
--- a/connectivity/source/drivers/hsqldb/HDriver.cxx
+++ b/connectivity/source/drivers/hsqldb/HDriver.cxx
@@ -124,7 +124,7 @@ namespace connectivity
         cppu::WeakComponentImplHelperBase::disposing();
     }
 
-    Reference< XDriver > ODriverDelegator::loadDriver( )
+    Reference< XDriver > const & ODriverDelegator::loadDriver( )
     {
         if ( !m_xDriver.is() )
         {
diff --git a/connectivity/source/drivers/hsqldb/HStorageMap.cxx b/connectivity/source/drivers/hsqldb/HStorageMap.cxx
index cad5fbde4beb..e79718a18f65 100644
--- a/connectivity/source/drivers/hsqldb/HStorageMap.cxx
+++ b/connectivity/source/drivers/hsqldb/HStorageMap.cxx
@@ -79,21 +79,21 @@ namespace connectivity
             }
         }
 
-        Reference< XInputStream> StreamHelper::getInputStream()
+        Reference< XInputStream> const & StreamHelper::getInputStream()
         {
             if ( !m_xInputStream.is() )
                 m_xInputStream = m_xStream->getInputStream();
             return m_xInputStream;
         }
 
-        Reference< XOutputStream> StreamHelper::getOutputStream()
+        Reference< XOutputStream> const & StreamHelper::getOutputStream()
         {
             if ( !m_xOutputStream.is() )
                 m_xOutputStream = m_xStream->getOutputStream();
             return m_xOutputStream;
         }
 
-        Reference< XSeekable> StreamHelper::getSeek()
+        Reference< XSeekable> const & StreamHelper::getSeek()
         {
             if ( !m_xSeek.is() )
                 m_xSeek.set(m_xStream,UNO_QUERY);
diff --git a/connectivity/source/drivers/jdbc/Object.cxx b/connectivity/source/drivers/jdbc/Object.cxx
index e7666cc39a31..068b1ed3991d 100644
--- a/connectivity/source/drivers/jdbc/Object.cxx
+++ b/connectivity/source/drivers/jdbc/Object.cxx
@@ -40,7 +40,7 @@ using namespace ::com::sun::star::container;
 using namespace ::com::sun::star::lang;
 
 
-::rtl::Reference< jvmaccess::VirtualMachine > getJavaVM2(const ::rtl::Reference< jvmaccess::VirtualMachine >& _rVM = ::rtl::Reference< jvmaccess::VirtualMachine >(),
+::rtl::Reference< jvmaccess::VirtualMachine > const & getJavaVM2(const ::rtl::Reference< jvmaccess::VirtualMachine >& _rVM = ::rtl::Reference< jvmaccess::VirtualMachine >(),
                                                         bool _bSet = false)
 {
     static ::rtl::Reference< jvmaccess::VirtualMachine > s_VM;
diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx b/connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx
index d3410ba6123d..c2c4c3906a49 100644
--- a/connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx
+++ b/connectivity/source/drivers/mozab/bootstrap/MNSFolders.cxx
@@ -90,7 +90,7 @@ namespace
     };
 
 
-    OUString lcl_guessProfileRoot( MozillaProductType _product )
+    OUString const & lcl_guessProfileRoot( MozillaProductType _product )
     {
         size_t productIndex = _product - 1;
 
diff --git a/connectivity/source/inc/FDatabaseMetaDataResultSet.hxx b/connectivity/source/inc/FDatabaseMetaDataResultSet.hxx
index 006266c78e5d..6d491ed34ee9 100644
--- a/connectivity/source/inc/FDatabaseMetaDataResultSet.hxx
+++ b/connectivity/source/inc/FDatabaseMetaDataResultSet.hxx
@@ -245,31 +245,31 @@ namespace connectivity
         // some methods to get already defined ORowSetValues
         // this increase the reuse of ORowSetValues
         /// return an empty ORowSetValueDecorator
-        static ORowSetValueDecoratorRef getEmptyValue();
+        static ORowSetValueDecoratorRef const & getEmptyValue();
         /// return an ORowSetValueDecorator with 0 as value
-        static ORowSetValueDecoratorRef get0Value();
+        static ORowSetValueDecoratorRef const & get0Value();
         /// return an ORowSetValueDecorator with 1 as value
-        static ORowSetValueDecoratorRef get1Value();
+        static ORowSetValueDecoratorRef const & get1Value();
         /// return an ORowSetValueDecorator with ColumnSearch::BASIC as value
-        static ORowSetValueDecoratorRef getBasicValue();
+        static ORowSetValueDecoratorRef const & getBasicValue();
         /// return an ORowSetValueDecorator with string SELECT as value
-        static ORowSetValueDecoratorRef getSelectValue();
+        static ORowSetValueDecoratorRef const & getSelectValue();
         /// return an ORowSetValueDecorator with string INSERT as value
-        static ORowSetValueDecoratorRef getInsertValue();
+        static ORowSetValueDecoratorRef const & getInsertValue();
         /// return an ORowSetValueDecorator with string DELETE as value
-        static ORowSetValueDecoratorRef getDeleteValue();
+        static ORowSetValueDecoratorRef const & getDeleteValue();
         /// return an ORowSetValueDecorator with string UPDATE as value
-        static ORowSetValueDecoratorRef getUpdateValue();
+        static ORowSetValueDecoratorRef const & getUpdateValue();
         /// return an ORowSetValueDecorator with string CREATE as value
-        static ORowSetValueDecoratorRef getCreateValue();
+        static ORowSetValueDecoratorRef const & getCreateValue();
         /// return an ORowSetValueDecorator with string READ as value
-        static ORowSetValueDecoratorRef getReadValue();
+        static ORowSetValueDecoratorRef const & getReadValue();
         /// return an ORowSetValueDecorator with string ALTER as value
-        static ORowSetValueDecoratorRef getAlterValue();
+        static ORowSetValueDecoratorRef const & getAlterValue();
         /// return an ORowSetValueDecorator with string DROP as value
-        static ORowSetValueDecoratorRef getDropValue();
+        static ORowSetValueDecoratorRef const & getDropValue();
         /// return an ORowSetValueDecorator with string ' as value
-        static ORowSetValueDecoratorRef getQuoteValue();
+        static ORowSetValueDecoratorRef const & getQuoteValue();
 
     };
 }
diff --git a/connectivity/source/inc/calc/CConnection.hxx b/connectivity/source/inc/calc/CConnection.hxx
index b8b734a13114..63b1d4ab084d 100644
--- a/connectivity/source/inc/calc/CConnection.hxx
+++ b/connectivity/source/inc/calc/CConnection.hxx
@@ -70,7 +70,7 @@ namespace connectivity
             virtual css::uno::Reference< css::sdbc::XPreparedStatement > SAL_CALL prepareCall( const OUString& sql ) throw(css::sdbc::SQLException, css::uno::RuntimeException, std::exception) override;
 
             // no interface methods
-            css::uno::Reference< css::sheet::XSpreadsheetDocument> acquireDoc();
+            css::uno::Reference< css::sheet::XSpreadsheetDocument> const & acquireDoc();
             void releaseDoc();
 
             class ODocHolder
diff --git a/connectivity/source/inc/dbase/DIndex.hxx b/connectivity/source/inc/dbase/DIndex.hxx
index 5396e6475d48..afe45a478708 100644
--- a/connectivity/source/inc/dbase/DIndex.hxx
+++ b/connectivity/source/inc/dbase/DIndex.hxx
@@ -125,7 +125,7 @@ namespace connectivity
 
             ONDXPage* CreatePage(sal_uInt32 nPagePos, ONDXPage* pParent = nullptr, bool bLoad = false);
             void Collect(ONDXPage*);
-            ONDXPagePtr getRoot();
+            ONDXPagePtr const & getRoot();
 
             bool isUnique() const { return m_IsUnique; }
             bool UseCollector() const {return m_bUseCollector;}
diff --git a/connectivity/source/inc/hsqldb/HDriver.hxx b/connectivity/source/inc/hsqldb/HDriver.hxx
index 21bc04459b93..255c6609b5d3 100644
--- a/connectivity/source/inc/hsqldb/HDriver.hxx
+++ b/connectivity/source/inc/hsqldb/HDriver.hxx
@@ -72,7 +72,7 @@ namespace connectivity
                 @return
                     The driver which was currently selected.
             */
-            css::uno::Reference< css::sdbc::XDriver > loadDriver( );
+            css::uno::Reference< css::sdbc::XDriver > const & loadDriver( );
 
             /** shut down the connection and revoke the storage from the map
                 @param  _aIter
diff --git a/connectivity/source/inc/hsqldb/HStorageMap.hxx b/connectivity/source/inc/hsqldb/HStorageMap.hxx
index f0bbe98e24d2..62ae7ec3d233 100644
--- a/connectivity/source/inc/hsqldb/HStorageMap.hxx
+++ b/connectivity/source/inc/hsqldb/HStorageMap.hxx
@@ -48,9 +48,9 @@ namespace connectivity
             StreamHelper(const css::uno::Reference< css::io::XStream>& _xStream);
             ~StreamHelper();
 
-            css::uno::Reference< css::io::XInputStream>   getInputStream();
-            css::uno::Reference< css::io::XOutputStream>  getOutputStream();
-            css::uno::Reference< css::io::XSeekable>      getSeek();
+            css::uno::Reference< css::io::XInputStream> const &   getInputStream();
+            css::uno::Reference< css::io::XOutputStream> const &  getOutputStream();
+            css::uno::Reference< css::io::XSeekable> const &      getSeek();
         };