address a few compiler warnings

3 files changed, 8 insertions, 5 deletions

diff --git a/connectivity/source/drivers/postgresql/pq_statics.cxx b/connectivity/source/drivers/postgresql/pq_statics.cxx
index 71fbbffcd859..711aedb5a55d 100644
--- a/connectivity/source/drivers/postgresql/pq_statics.cxx
+++ b/connectivity/source/drivers/postgresql/pq_statics.cxx
@@ -635,6 +635,7 @@ Statics & getStatics()
             statics.resultSetArrayColumnNames =
                 createStringSequence( resultSetArrayColumnNames );
 
+            // LEM TODO see if a refresh is needed; obtain automatically from pg_catalog.pg_type?
             BaseTypeDef baseTypeDefs[] =
             {
                 { "bool" , com::sun::star::sdbc::DataType::BIT },
@@ -708,6 +709,8 @@ Statics & getStatics()
                            baseTypeDefs[i].value;
             }
 
+            // LEM TODO: this bears a passing resemblance with the structure of pg_catalog.pg_type
+            // LEM TODO: isSigned (last field) is not initialised
             DefColumnMetaData defTypeInfoMetaData[] =
                 {
                     { "TYPE_NAME", "TYPEINFO", "pg_catalog", "", com::sun::star::sdbc::DataType::VARCHAR, 0,50,0,0,0,0 },  // 0
diff --git a/connectivity/source/drivers/postgresql/pq_tools.cxx b/connectivity/source/drivers/postgresql/pq_tools.cxx
index 1f91984a13c6..eeeb779b6da3 100644
--- a/connectivity/source/drivers/postgresql/pq_tools.cxx
+++ b/connectivity/source/drivers/postgresql/pq_tools.cxx
@@ -760,7 +760,7 @@ void fillAttnum2attnameMap(
 ::rtl::OString extractSingleTableFromSelect( const OStringVector &vec )
 {
     rtl::OString ret;
-    int token = 0;
+    size_t token = 0;
 
     if( 0 == rtl_str_shortenedCompareIgnoreAsciiCase_WithLength(
             vec[0].pData->buffer, vec[0].pData->length, "select" , 6 , 6 ) )
diff --git a/connectivity/source/drivers/postgresql/pq_xtable.cxx b/connectivity/source/drivers/postgresql/pq_xtable.cxx
index 50871a176f2a..43839ecb0f1c 100644
--- a/connectivity/source/drivers/postgresql/pq_xtable.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xtable.cxx
@@ -217,11 +217,11 @@ void Table::rename( const ::rtl::OUString& newName )
     {
         // maintain view list (really strange API !)
         Any a = m_pSettings->pViewsImpl->getByName( fullOldName );
-        Reference< com::sun::star::sdbcx::XRename > rename;
-        a >>= rename;
-        if( rename.is() )
+        Reference< com::sun::star::sdbcx::XRename > Xrename;
+        a >>= Xrename;
+        if( Xrename.is() )
         {
-            rename->rename( newName );
+            Xrename->rename( newName );
             setPropertyValue_NoBroadcast_public( st.SCHEMA_NAME, makeAny(newSchemaName) );
         }
     }