teach passstuffbyref plugin to check for..

unnecessarily passing primitives by const ref.

Suggested by Tor Lillqvist

Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6
Reviewed-on: https://gerrit.libreoffice.org/24672
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

2 files changed, 14 insertions, 14 deletions

diff --git a/connectivity/source/commontools/FValue.cxx b/connectivity/source/commontools/FValue.cxx
index f7473f539823..4a8f02c8fb80 100644
--- a/connectivity/source/commontools/FValue.cxx
+++ b/connectivity/source/commontools/FValue.cxx
@@ -533,7 +533,7 @@ ORowSetValue& ORowSetValue::operator=(const OUString& _rRH)
 }
 
 
-ORowSetValue& ORowSetValue::operator=(const double& _rRH)
+ORowSetValue& ORowSetValue::operator=(double _rRH)
 {
     if(m_eTypeKind != DataType::DOUBLE)
         free();
@@ -545,7 +545,7 @@ ORowSetValue& ORowSetValue::operator=(const double& _rRH)
     return *this;
 }
 
-ORowSetValue& ORowSetValue::operator=(const float& _rRH)
+ORowSetValue& ORowSetValue::operator=(float _rRH)
 {
     if(m_eTypeKind != DataType::FLOAT)
         free();
@@ -558,7 +558,7 @@ ORowSetValue& ORowSetValue::operator=(const float& _rRH)
 }
 
 
-ORowSetValue& ORowSetValue::operator=(const sal_Int8& _rRH)
+ORowSetValue& ORowSetValue::operator=(sal_Int8 _rRH)
 {
     if(m_eTypeKind != DataType::TINYINT )
         free();
@@ -571,7 +571,7 @@ ORowSetValue& ORowSetValue::operator=(const sal_Int8& _rRH)
 }
 
 
-ORowSetValue& ORowSetValue::operator=(const sal_uInt8& _rRH)
+ORowSetValue& ORowSetValue::operator=(sal_uInt8 _rRH)
 {
     if(m_eTypeKind != DataType::TINYINT )
         free();
@@ -584,7 +584,7 @@ ORowSetValue& ORowSetValue::operator=(const sal_uInt8& _rRH)
 }
 
 
-ORowSetValue& ORowSetValue::operator=(const sal_Int16& _rRH)
+ORowSetValue& ORowSetValue::operator=(sal_Int16 _rRH)
 {
     if(m_eTypeKind != DataType::SMALLINT )
         free();
@@ -598,7 +598,7 @@ ORowSetValue& ORowSetValue::operator=(const sal_Int16& _rRH)
 }
 
 
-ORowSetValue& ORowSetValue::operator=(const sal_uInt16& _rRH)
+ORowSetValue& ORowSetValue::operator=(sal_uInt16 _rRH)
 {
     if(m_eTypeKind != DataType::SMALLINT )
         free();
@@ -612,7 +612,7 @@ ORowSetValue& ORowSetValue::operator=(const sal_uInt16& _rRH)
 }
 
 
-ORowSetValue& ORowSetValue::operator=(const sal_Int32& _rRH)
+ORowSetValue& ORowSetValue::operator=(sal_Int32 _rRH)
 {
     if(m_eTypeKind != DataType::INTEGER )
         free();
@@ -627,7 +627,7 @@ ORowSetValue& ORowSetValue::operator=(const sal_Int32& _rRH)
 }
 
 
-ORowSetValue& ORowSetValue::operator=(const sal_uInt32& _rRH)
+ORowSetValue& ORowSetValue::operator=(sal_uInt32 _rRH)
 {
     if(m_eTypeKind != DataType::INTEGER )
         free();
@@ -654,7 +654,7 @@ ORowSetValue& ORowSetValue::operator=(const bool _rRH)
     return *this;
 }
 
-ORowSetValue& ORowSetValue::operator=(const sal_Int64& _rRH)
+ORowSetValue& ORowSetValue::operator=(sal_Int64 _rRH)
 {
     if ( DataType::BIGINT != m_eTypeKind)
         free();
@@ -667,7 +667,7 @@ ORowSetValue& ORowSetValue::operator=(const sal_Int64& _rRH)
     return *this;
 }
 
-ORowSetValue& ORowSetValue::operator=(const sal_uInt64& _rRH)
+ORowSetValue& ORowSetValue::operator=(sal_uInt64 _rRH)
 {
     if ( DataType::BIGINT != m_eTypeKind)
         free();
diff --git a/connectivity/source/commontools/sqlerror.cxx b/connectivity/source/commontools/sqlerror.cxx
index 6dc468187417..1febff0a796a 100644
--- a/connectivity/source/commontools/sqlerror.cxx
+++ b/connectivity/source/commontools/sqlerror.cxx
@@ -67,11 +67,11 @@ namespace connectivity
     private:
         /// returns the basic error message associated with the given error condition, without any parameter replacements
         OUString
-                impl_getErrorMessage( const ErrorCondition& _eCondition );
+                impl_getErrorMessage( ErrorCondition _eCondition );
 
         /// returns the SQLState associated with the given error condition
         OUString
-                impl_getSQLState( const ErrorCondition& _eCondition );
+                impl_getSQLState( ErrorCondition _eCondition );
 
         /// returns an SQLException describing the given error condition
         SQLException
@@ -224,7 +224,7 @@ namespace connectivity
     }
 
 
-    OUString SQLError_Impl::impl_getErrorMessage( const ErrorCondition& _eCondition )
+    OUString SQLError_Impl::impl_getErrorMessage( ErrorCondition _eCondition )
     {
         OUStringBuffer aMessage;
 
@@ -239,7 +239,7 @@ namespace connectivity
     }
 
 
-    OUString SQLError_Impl::impl_getSQLState( const ErrorCondition& _eCondition )
+    OUString SQLError_Impl::impl_getSQLState( ErrorCondition _eCondition )
     {
         OUString sState;