loplugin:countusersofdefaultparams in connectivity

Change-Id: Ia613257f2de1395c6629c1c37026ed48d4b927c8
Reviewed-on: https://gerrit.libreoffice.org/45854
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

11 files changed, 31 insertions, 30 deletions

diff --git a/connectivity/source/cpool/ZConnectionPool.cxx b/connectivity/source/cpool/ZConnectionPool.cxx
index d6d1c8f3ee13..ddb80da0c02c 100644
--- a/connectivity/source/cpool/ZConnectionPool.cxx
+++ b/connectivity/source/cpool/ZConnectionPool.cxx
@@ -82,7 +82,7 @@ struct TRemoveEventListenerFunctor
     OConnectionPool* m_pConnectionPool;
     bool m_bDispose;
 
-    TRemoveEventListenerFunctor(OConnectionPool* _pConnectionPool,bool _bDispose = false)
+    TRemoveEventListenerFunctor(OConnectionPool* _pConnectionPool, bool _bDispose)
         : m_pConnectionPool(_pConnectionPool)
         ,m_bDispose(_bDispose)
     {
diff --git a/connectivity/source/drivers/evoab2/NTable.hxx b/connectivity/source/drivers/evoab2/NTable.hxx
index c3e984ce78b6..eb1159847d20 100644
--- a/connectivity/source/drivers/evoab2/NTable.hxx
+++ b/connectivity/source/drivers/evoab2/NTable.hxx
@@ -38,9 +38,9 @@ namespace connectivity
                     OEvoabConnection* _pConnection,
                     const OUString& Name,
                     const OUString& Type,
-                    const OUString& Description = OUString(),
-                    const OUString& SchemaName = OUString(),
-                    const OUString& CatalogName = OUString()
+                    const OUString& Description,
+                    const OUString& SchemaName,
+                    const OUString& CatalogName
                 );
 
             OEvoabConnection* getConnection() { return m_pConnection;}
diff --git a/connectivity/source/drivers/evoab2/NTables.cxx b/connectivity/source/drivers/evoab2/NTables.cxx
index 652ac07030e1..7beaffdca6d6 100644
--- a/connectivity/source/drivers/evoab2/NTables.cxx
+++ b/connectivity/source/drivers/evoab2/NTables.cxx
@@ -63,6 +63,7 @@ ObjectType OEvoabTables::createObject(const OUString& aName)
                     aName,
                     xRow->getString(4),
                     xRow->getString(5),
+                    "",
                     "");
                     xRet = pRet;
         }
diff --git a/connectivity/source/drivers/firebird/Columns.cxx b/connectivity/source/drivers/firebird/Columns.cxx
index d418026ce6c2..8089cab8c965 100644
--- a/connectivity/source/drivers/firebird/Columns.cxx
+++ b/connectivity/source/drivers/firebird/Columns.cxx
@@ -29,7 +29,8 @@ Columns::Columns(Table& rTable,
     OColumnsHelper(rTable,
                    true, // TODO: is this case sensitivity?
                    rMutex,
-                   rVector)
+                   rVector,
+                   /*bUseHardRef*/true)
 {
     OColumnsHelper::setParent(&rTable);
 }
diff --git a/connectivity/source/inc/OColumn.hxx b/connectivity/source/inc/OColumn.hxx
index fb087a859853..e0d86d7e9497 100644
--- a/connectivity/source/inc/OColumn.hxx
+++ b/connectivity/source/inc/OColumn.hxx
@@ -71,12 +71,11 @@ namespace connectivity
 
         OColumn(const OUString &_aTableName,
                 const OUString &_aColumnName,
-
-                sal_Int32       _aNullable=0,
-                sal_Int32       _aColumnDisplaySize=0,
-                sal_Int32       _aPrecision=0,
-                sal_Int32       _aScale=0,
-                sal_Int32       _aColumnType=0)
+                sal_Int32       _aNullable,
+                sal_Int32       _aColumnDisplaySize,
+                sal_Int32       _aPrecision,
+                sal_Int32       _aScale,
+                sal_Int32       _aColumnType)
         :   m_TableName(_aTableName),
             m_ColumnName(_aColumnName),
             m_ColumnLabel(),
diff --git a/connectivity/source/inc/component/CTable.hxx b/connectivity/source/inc/component/CTable.hxx
index f1daff08633c..8bd55668f4e7 100644
--- a/connectivity/source/inc/component/CTable.hxx
+++ b/connectivity/source/inc/component/CTable.hxx
@@ -49,9 +49,9 @@ namespace connectivity
             OComponentTable( sdbcx::OCollection* _pTables,file::OConnection* _pConnection,
                     const OUString& Name,
                     const OUString& Type,
-                    const OUString& Description = OUString(),
-                    const OUString& SchemaName = OUString(),
-                    const OUString& CatalogName = OUString()
+                    const OUString& Description,
+                    const OUString& SchemaName,
+                    const OUString& CatalogName
                 );
 
             virtual void refreshColumns() override;
diff --git a/connectivity/source/inc/dbase/dindexnode.hxx b/connectivity/source/inc/dbase/dindexnode.hxx
index 01b45ddde646..481faa1ccbf5 100644
--- a/connectivity/source/inc/dbase/dindexnode.hxx
+++ b/connectivity/source/inc/dbase/dindexnode.hxx
@@ -51,8 +51,8 @@ namespace connectivity
         public:
             ONDXKey();
             ONDXKey(const ORowSetValue& rVal, sal_Int32 eType, sal_uInt32 nRec);
-            ONDXKey(const OUString& aStr, sal_uInt32 nRec = 0);
-            ONDXKey(double aVal, sal_uInt32 nRec = 0);
+            ONDXKey(const OUString& aStr, sal_uInt32 nRec);
+            ONDXKey(double aVal, sal_uInt32 nRec);
 
             inline ONDXKey(const ONDXKey& rKey);
 
@@ -177,7 +177,7 @@ namespace connectivity
             void   SearchAndReplace(const ONDXKey& rSearch, ONDXKey const & rReplace);
 
         protected:
-            ONDXPage(ODbaseIndex& rIndex, sal_uInt32 nPos, ONDXPage* = nullptr);
+            ONDXPage(ODbaseIndex& rIndex, sal_uInt32 nPos, ONDXPage*);
             ~ONDXPage();
 
             void ReleaseRef();
diff --git a/connectivity/source/inc/file/FTable.hxx b/connectivity/source/inc/file/FTable.hxx
index 60270ff2dead..3a234674b620 100644
--- a/connectivity/source/inc/file/FTable.hxx
+++ b/connectivity/source/inc/file/FTable.hxx
@@ -58,9 +58,9 @@ namespace connectivity
             OFileTable( sdbcx::OCollection* _pTables,OConnection* _pConnection,
                     const OUString& Name,
                     const OUString& Type,
-                    const OUString& Description = OUString(),
-                    const OUString& SchemaName = OUString(),
-                    const OUString& CatalogName = OUString()
+                    const OUString& Description,
+                    const OUString& SchemaName,
+                    const OUString& CatalogName
                 );
 
             //XInterface
diff --git a/connectivity/source/inc/file/fcode.hxx b/connectivity/source/inc/file/fcode.hxx
index c9fe37efdecc..6993a799a180 100644
--- a/connectivity/source/inc/file/fcode.hxx
+++ b/connectivity/source/inc/file/fcode.hxx
@@ -245,7 +245,7 @@ namespace connectivity
             const sal_Unicode cEscape;
 
         public:
-            OOp_LIKE(const sal_Unicode cEsc = L'\0'):cEscape(cEsc){};
+            OOp_LIKE(const sal_Unicode cEsc):cEscape(cEsc){};
 
             virtual bool operate(const OOperand*, const OOperand*) const override;
         };
@@ -254,7 +254,7 @@ namespace connectivity
         {
         public:
         public:
-            OOp_NOTLIKE(const sal_Unicode cEsc = L'\0'):OOp_LIKE(cEsc){};
+            OOp_NOTLIKE(const sal_Unicode cEsc):OOp_LIKE(cEsc){};
 
             virtual bool operate(const OOperand*, const OOperand*) const override;
         };
diff --git a/connectivity/source/inc/hsqldb/HTable.hxx b/connectivity/source/inc/hsqldb/HTable.hxx
index 4048ac845cac..f642d39a35d8 100644
--- a/connectivity/source/inc/hsqldb/HTable.hxx
+++ b/connectivity/source/inc/hsqldb/HTable.hxx
@@ -77,10 +77,10 @@ namespace connectivity
                             const css::uno::Reference< css::sdbc::XConnection >& _xConnection,
                             const OUString& Name,
                             const OUString& Type,
-                            const OUString& Description = OUString(),
-                            const OUString& SchemaName = OUString(),
-                            const OUString& CatalogName = OUString(),
-                            sal_Int32 _nPrivileges = 0
+                            const OUString& Description,
+                            const OUString& SchemaName,
+                            const OUString& CatalogName,
+                            sal_Int32 _nPrivileges
                 );
 
             // ODescriptor
diff --git a/connectivity/source/inc/mysql/YTable.hxx b/connectivity/source/inc/mysql/YTable.hxx
index 9648d29411c6..a692b03ea8f6 100644
--- a/connectivity/source/inc/mysql/YTable.hxx
+++ b/connectivity/source/inc/mysql/YTable.hxx
@@ -84,10 +84,10 @@ namespace connectivity
                             const css::uno::Reference< css::sdbc::XConnection >& _xConnection,
                             const OUString& Name,
                             const OUString& Type,
-                            const OUString& Description = OUString(),
-                            const OUString& SchemaName = OUString(),
-                            const OUString& CatalogName = OUString(),
-                            sal_Int32 _nPrivileges = 0
+                            const OUString& Description,
+                            const OUString& SchemaName,
+                            const OUString& CatalogName,
+                            sal_Int32 _nPrivileges
                 );
 
             // ODescriptor