summaryrefslogtreecommitdiff
path: root/connectivity
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@collabora.com>2019-08-01 15:31:10 +0200
committerMiklos Vajna <vmiklos@collabora.com>2019-08-02 09:58:39 +0200
commitaf9e212f84ba5148fac09bb44bf1ea6bb2d57983 (patch)
tree23789327a057bd62c24fa564ca234b21c18398a6 /connectivity
parent6cd885243952bec4b71aa95d77820b08d70a94dc (diff)
sw comments on frames: improve doc coordinates -> doc model pos conversion
In case an as-char image at the end of a paragraph was commented and the user clicked past the end of the paragraph, we defaulted to extending that comment, rather appending content. (The cursor was placed between the as-char image and the comment anchor, not past the comment anchor.) This doesn't seem to be useful, probably the expectation is that if the user clicks before the comment anchor then we extend the comment range, and if the click is after the comment anchor, then we don't. In both cases we used to *select* the comment anchor, so typing a character deleted the comment instead. This commit is a step in the direction of never selecting the comment anchor: now if you click past the comment anchor, then we place the cursor after the comment anchor. (But clicking before the comment anchor results in unchanged behavior for now.) (cherry picked from commit 27c46ecf34b32bae1806d3fc0e1684179301feb8) Conflicts: sw/qa/extras/layout/layout.cxx sw/source/core/text/itrcrsr.cxx Change-Id: I6c36ec4344591fdf330a73bcd3cdd6fd0610e339 Reviewed-on: https://gerrit.libreoffice.org/76832 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Diffstat (limited to 'connectivity')
0 files changed, 0 insertions, 0 deletions