diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-06-08 16:17:45 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-06-08 17:35:00 +0100 |
commit | a941df0f89ab8222ebd22c697e23fb539a3730ed (patch) | |
tree | e65d56ab54abbf76d7176e49bab2929d06055433 /connectivity | |
parent | 883ebe0283dc6bdf62f08191dede2a249f777f63 (diff) |
cppcheck: noExplicitConstructor
Change-Id: Ie2ae923ad4c1a66e779711de6ff05328ef144dac
Diffstat (limited to 'connectivity')
18 files changed, 25 insertions, 25 deletions
diff --git a/connectivity/source/commontools/FValue.cxx b/connectivity/source/commontools/FValue.cxx index 16402507eaba..2981c027eb58 100644 --- a/connectivity/source/commontools/FValue.cxx +++ b/connectivity/source/commontools/FValue.cxx @@ -2200,7 +2200,7 @@ namespace detail class ColumnValue : public IValueSource { public: - ColumnValue( const Reference< XColumn >& _rxColumn ) + explicit ColumnValue( const Reference< XColumn >& _rxColumn ) :m_xColumn( _rxColumn ) { } diff --git a/connectivity/source/commontools/RowFunctionParser.cxx b/connectivity/source/commontools/RowFunctionParser.cxx index c296337b4f80..b6045c479bba 100644 --- a/connectivity/source/commontools/RowFunctionParser.cxx +++ b/connectivity/source/commontools/RowFunctionParser.cxx @@ -58,7 +58,7 @@ class ConstantValueExpression : public ExpressionNode public: - ConstantValueExpression( ORowSetValueDecoratorRef rValue ) : + explicit ConstantValueExpression( ORowSetValueDecoratorRef rValue ) : maValue( rValue ) { } @@ -171,7 +171,7 @@ class ConstantFunctor public: - ConstantFunctor( const ParserContextSharedPtr& rContext ) : + explicit ConstantFunctor( const ParserContextSharedPtr& rContext ) : mpContext( rContext ) { } @@ -189,7 +189,7 @@ class IntConstantFunctor ParserContextSharedPtr mpContext; public: - IntConstantFunctor( const ParserContextSharedPtr& rContext ) : + explicit IntConstantFunctor( const ParserContextSharedPtr& rContext ) : mpContext( rContext ) { } @@ -326,7 +326,7 @@ public: @param rParserContext Contains context info for the parser */ - ExpressionGrammar( const ParserContextSharedPtr& rParserContext ) : + explicit ExpressionGrammar( const ParserContextSharedPtr& rParserContext ) : mpParserContext( rParserContext ) { } @@ -335,7 +335,7 @@ public: { public: // grammar definition - definition( const ExpressionGrammar& self ) + explicit definition( const ExpressionGrammar& self ) { using ::boost::spirit::str_p; using ::boost::spirit::space_p; diff --git a/connectivity/source/commontools/TColumnsHelper.cxx b/connectivity/source/commontools/TColumnsHelper.cxx index a4b3daff2d15..cf349818fc01 100644 --- a/connectivity/source/commontools/TColumnsHelper.cxx +++ b/connectivity/source/commontools/TColumnsHelper.cxx @@ -50,7 +50,7 @@ namespace connectivity class OColumnsHelperImpl { public: - OColumnsHelperImpl(bool _bCase) + explicit OColumnsHelperImpl(bool _bCase) : m_aColumnInfo(_bCase) { } diff --git a/connectivity/source/commontools/TSortIndex.cxx b/connectivity/source/commontools/TSortIndex.cxx index a48ccc69af74..ffe258aaa048 100644 --- a/connectivity/source/commontools/TSortIndex.cxx +++ b/connectivity/source/commontools/TSortIndex.cxx @@ -30,7 +30,7 @@ struct TKeyValueFunc : ::std::binary_function<OSortIndex::TIntValuePairVector::v { OSortIndex* pIndex; - TKeyValueFunc(OSortIndex* _pIndex) : pIndex(_pIndex) + explicit TKeyValueFunc(OSortIndex* _pIndex) : pIndex(_pIndex) { } // return false if compared values are equal otherwise true diff --git a/connectivity/source/commontools/TTableHelper.cxx b/connectivity/source/commontools/TTableHelper.cxx index 1a84f0cb3483..2ddf19a8f3fb 100644 --- a/connectivity/source/commontools/TTableHelper.cxx +++ b/connectivity/source/commontools/TTableHelper.cxx @@ -62,7 +62,7 @@ class OTableContainerListener: protected: virtual ~OTableContainerListener(){} public: - OTableContainerListener(OTableHelper* _pComponent) : m_pComponent(_pComponent){} + explicit OTableContainerListener(OTableHelper* _pComponent) : m_pComponent(_pComponent){} virtual void SAL_CALL elementInserted( const ::com::sun::star::container::ContainerEvent& /*Event*/ ) throw (RuntimeException, std::exception) SAL_OVERRIDE { } @@ -114,7 +114,7 @@ namespace connectivity Reference< ::com::sun::star::sdbc::XConnection > m_xConnection; rtl::Reference<OTableContainerListener> m_xTablePropertyListener; ::std::vector< ColumnDesc > m_aColumnDesc; - OTableHelperImpl(const Reference< ::com::sun::star::sdbc::XConnection >& _xConnection) + explicit OTableHelperImpl(const Reference< ::com::sun::star::sdbc::XConnection >& _xConnection) : m_xConnection(_xConnection) { try diff --git a/connectivity/source/commontools/sqlerror.cxx b/connectivity/source/commontools/sqlerror.cxx index f5318f80cba2..58ad8660c738 100644 --- a/connectivity/source/commontools/sqlerror.cxx +++ b/connectivity/source/commontools/sqlerror.cxx @@ -56,7 +56,7 @@ namespace connectivity class SQLError_Impl { public: - SQLError_Impl( const Reference<XComponentContext> & _rxContext ); + explicit SQLError_Impl( const Reference<XComponentContext> & _rxContext ); ~SQLError_Impl(); // versions of the public SQLError methods which are just delegated to this impl-class diff --git a/connectivity/source/commontools/statementcomposer.cxx b/connectivity/source/commontools/statementcomposer.cxx index 5057aaf158f9..376811c5833a 100644 --- a/connectivity/source/commontools/statementcomposer.cxx +++ b/connectivity/source/commontools/statementcomposer.cxx @@ -64,7 +64,7 @@ namespace dbtools bool bComposerDirty; bool bDisposeComposer; - StatementComposer_Data( const Reference< XConnection >& _rxConnection ) + explicit StatementComposer_Data( const Reference< XConnection >& _rxConnection ) :xConnection( _rxConnection ) ,sCommand() ,sFilter() diff --git a/connectivity/source/cpool/ZConnectionPool.cxx b/connectivity/source/cpool/ZConnectionPool.cxx index 2c200325963c..9eb953c5fc37 100644 --- a/connectivity/source/cpool/ZConnectionPool.cxx +++ b/connectivity/source/cpool/ZConnectionPool.cxx @@ -117,7 +117,7 @@ struct TConnectionPoolFunctor : ::std::unary_function<TConnectionMap::value_type { OConnectionPool* m_pConnectionPool; - TConnectionPoolFunctor(OConnectionPool* _pConnectionPool) + explicit TConnectionPoolFunctor(OConnectionPool* _pConnectionPool) : m_pConnectionPool(_pConnectionPool) { OSL_ENSURE(m_pConnectionPool,"No connection pool!"); diff --git a/connectivity/source/cpool/ZConnectionWrapper.hxx b/connectivity/source/cpool/ZConnectionWrapper.hxx index 7905455cc0bb..f15487f8d77f 100644 --- a/connectivity/source/cpool/ZConnectionWrapper.hxx +++ b/connectivity/source/cpool/ZConnectionWrapper.hxx @@ -45,7 +45,7 @@ namespace connectivity virtual void SAL_CALL disposing() SAL_OVERRIDE; virtual ~OConnectionWeakWrapper(); public: - OConnectionWeakWrapper(::com::sun::star::uno::Reference< ::com::sun::star::uno::XAggregation >& _xConnection); + explicit OConnectionWeakWrapper(::com::sun::star::uno::Reference< ::com::sun::star::uno::XAggregation >& _xConnection); // XServiceInfo DECLARE_SERVICE_INFO(); diff --git a/connectivity/source/cpool/ZPoolCollection.hxx b/connectivity/source/cpool/ZPoolCollection.hxx index 94594ec5a526..758a5cd76235 100644 --- a/connectivity/source/cpool/ZPoolCollection.hxx +++ b/connectivity/source/cpool/ZPoolCollection.hxx @@ -80,7 +80,7 @@ namespace connectivity OPoolCollection(const OPoolCollection&) SAL_DELETED_FUNCTION; int operator= (const OPoolCollection&) SAL_DELETED_FUNCTION; - OPoolCollection( + explicit OPoolCollection( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext); // some configuration helper methods diff --git a/connectivity/source/drivers/evoab2/NCatalog.hxx b/connectivity/source/drivers/evoab2/NCatalog.hxx index 96b74154de7c..5353a5854e6b 100644 --- a/connectivity/source/drivers/evoab2/NCatalog.hxx +++ b/connectivity/source/drivers/evoab2/NCatalog.hxx @@ -32,7 +32,7 @@ namespace connectivity OEvoabConnection *m_pConnection; ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XDatabaseMetaData > m_xMetaData; public: - OEvoabCatalog(OEvoabConnection *_pCon); + explicit OEvoabCatalog(OEvoabConnection *_pCon); inline OEvoabConnection* getConnection() const { return m_pConnection; } virtual void refreshTables() SAL_OVERRIDE; virtual void refreshViews() SAL_OVERRIDE {} diff --git a/connectivity/source/drivers/evoab2/NConnection.hxx b/connectivity/source/drivers/evoab2/NConnection.hxx index 32b808df1b2a..e30e6f8903a1 100644 --- a/connectivity/source/drivers/evoab2/NConnection.hxx +++ b/connectivity/source/drivers/evoab2/NConnection.hxx @@ -64,7 +64,7 @@ namespace connectivity virtual ~OEvoabConnection(); public: - OEvoabConnection( OEvoabDriver& _rDriver ); + explicit OEvoabConnection( OEvoabDriver& _rDriver ); virtual void construct(const OUString& _rUrl,const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& _rInfo ) throw( ::com::sun::star::sdbc::SQLException); inline OString getPassword() { return m_aPassword; } diff --git a/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx b/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx index 4945f937511a..6a9624127992 100644 --- a/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx +++ b/connectivity/source/drivers/evoab2/NDatabaseMetaData.hxx @@ -87,7 +87,7 @@ namespace connectivity public: inline OEvoabConnection* getOwnConnection() const { return m_pConnection; } - OEvoabDatabaseMetaData(OEvoabConnection* _pCon); + explicit OEvoabDatabaseMetaData(OEvoabConnection* _pCon); // as I mentioned before this interface is really BIG // XDatabaseMetaData diff --git a/connectivity/source/drivers/evoab2/NDriver.hxx b/connectivity/source/drivers/evoab2/NDriver.hxx index f7827132a2f6..0d47a7954865 100644 --- a/connectivity/source/drivers/evoab2/NDriver.hxx +++ b/connectivity/source/drivers/evoab2/NDriver.hxx @@ -50,7 +50,7 @@ namespace connectivity ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory > m_xFactory; public: - OEvoabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory); + explicit OEvoabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory); virtual ~OEvoabDriver(); // OComponentHelper diff --git a/connectivity/source/drivers/evoab2/NPreparedStatement.hxx b/connectivity/source/drivers/evoab2/NPreparedStatement.hxx index 515ffd453ac5..ddf604132c52 100644 --- a/connectivity/source/drivers/evoab2/NPreparedStatement.hxx +++ b/connectivity/source/drivers/evoab2/NPreparedStatement.hxx @@ -73,7 +73,7 @@ namespace connectivity virtual ~OEvoabPreparedStatement(); public: - OEvoabPreparedStatement( OEvoabConnection* _pConnection ); + explicit OEvoabPreparedStatement( OEvoabConnection* _pConnection ); void construct( const OUString& _sql ); diff --git a/connectivity/source/drivers/evoab2/NResultSetMetaData.hxx b/connectivity/source/drivers/evoab2/NResultSetMetaData.hxx index b6ddc6d74f05..11ce298b821f 100644 --- a/connectivity/source/drivers/evoab2/NResultSetMetaData.hxx +++ b/connectivity/source/drivers/evoab2/NResultSetMetaData.hxx @@ -42,7 +42,7 @@ namespace connectivity protected: virtual ~OEvoabResultSetMetaData(); public: - OEvoabResultSetMetaData(const OUString& _aTableName); + explicit OEvoabResultSetMetaData(const OUString& _aTableName); void setEvoabFields(const ::rtl::Reference<connectivity::OSQLColumns> &xColumns) throw(::com::sun::star::sdbc::SQLException); inline sal_uInt32 fieldAtColumn(sal_Int32 columnIndex) const { return m_aEvoabFields[columnIndex - 1]; } diff --git a/connectivity/source/drivers/evoab2/NStatement.hxx b/connectivity/source/drivers/evoab2/NStatement.hxx index 9634ae8f8c1b..f1665d57c8c1 100644 --- a/connectivity/source/drivers/evoab2/NStatement.hxx +++ b/connectivity/source/drivers/evoab2/NStatement.hxx @@ -189,7 +189,7 @@ namespace connectivity using OCommonStatement_IBase::operator ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >; protected: - OCommonStatement( OEvoabConnection* _pConnection ); + explicit OCommonStatement( OEvoabConnection* _pConnection ); // OComponentHelper virtual void SAL_CALL disposing() SAL_OVERRIDE; @@ -242,7 +242,7 @@ namespace connectivity virtual ~OStatement(){} public: - OStatement( OEvoabConnection* _pConnection) + explicit OStatement( OEvoabConnection* _pConnection) :OCommonStatement( _pConnection) { } diff --git a/connectivity/source/drivers/firebird/Catalog.hxx b/connectivity/source/drivers/firebird/Catalog.hxx index 559986384cb7..5dc341b9b2fa 100644 --- a/connectivity/source/drivers/firebird/Catalog.hxx +++ b/connectivity/source/drivers/firebird/Catalog.hxx @@ -23,7 +23,7 @@ namespace connectivity m_xConnection; public: - Catalog(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection >& rConnection); + explicit Catalog(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection >& rConnection); // OCatalog virtual void refreshTables() SAL_OVERRIDE; @@ -40,4 +40,4 @@ namespace connectivity #endif // INCLUDED_CONNECTIVITY_SOURCE_DRIVERS_FIREBIRD_CATALOG_HXX -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ |