summaryrefslogtreecommitdiff
path: root/connectivity
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2018-08-28 11:15:47 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2018-08-29 09:00:52 +0200
commit6dbae37b8d2d2d1ecad85c772fd684803b5a52cb (patch)
treecb6637327913a5f9641c2c0065de4c6a00983947 /connectivity
parentdc06c8f4989fc28d0c31ebd333e53dfe0e0f5f66 (diff)
loplugin:constantparam (1)
Change-Id: I25077e391ecca1b678062d261a83d88daadf0a58 Reviewed-on: https://gerrit.libreoffice.org/59701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'connectivity')
-rw-r--r--connectivity/source/commontools/ConnectionWrapper.cxx2
-rw-r--r--connectivity/source/commontools/dbtools2.cxx6
2 files changed, 4 insertions, 4 deletions
diff --git a/connectivity/source/commontools/ConnectionWrapper.cxx b/connectivity/source/commontools/ConnectionWrapper.cxx
index ff966e65bbee..bd62d64990be 100644
--- a/connectivity/source/commontools/ConnectionWrapper.cxx
+++ b/connectivity/source/commontools/ConnectionWrapper.cxx
@@ -120,7 +120,7 @@ css::uno::Sequence< OUString > SAL_CALL OConnectionWrapper::getSupportedServiceN
// append our own service, if necessary
OUString sConnectionService( "com.sun.star.sdbc.Connection" );
- if ( 0 == ::comphelper::findValue( aSupported, sConnectionService, true ).getLength() )
+ if ( ::comphelper::findValue( aSupported, sConnectionService ) == -1 )
{
sal_Int32 nLen = aSupported.getLength();
aSupported.realloc( nLen + 1 );
diff --git a/connectivity/source/commontools/dbtools2.cxx b/connectivity/source/commontools/dbtools2.cxx
index 5e1296adbbc6..535baadb49d1 100644
--- a/connectivity/source/commontools/dbtools2.cxx
+++ b/connectivity/source/commontools/dbtools2.cxx
@@ -997,10 +997,10 @@ bool isAggregateColumn(const Reference< XSingleSelectQueryComposer > &_xParser,
if (xColumnsSupplier.is())
xCols = xColumnsSupplier->getColumns();
- return isAggregateColumn(xCols, sName, false/*whenNotFound*/);
+ return isAggregateColumn(xCols, sName);
}
-bool isAggregateColumn(const Reference< XNameAccess > &_xColumns, const OUString &_sName, bool whenNotFound)
+bool isAggregateColumn(const Reference< XNameAccess > &_xColumns, const OUString &_sName)
{
if ( _xColumns.is() && _xColumns->hasByName(_sName) )
{
@@ -1008,7 +1008,7 @@ bool isAggregateColumn(const Reference< XNameAccess > &_xColumns, const OUString
assert(xProp.is());
return isAggregateColumn( xProp );
}
- return whenNotFound;
+ return false;
}
bool isAggregateColumn( const Reference< XPropertySet > &_xColumn )