diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-02-14 13:01:42 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-02-15 11:52:41 +0100 |
| commit | e132e781d8b01684d8ef51f060e90d465a21c677 (patch) | |
| tree | f18331549fdc95416a748c7792f804a39ab0a30f /connectivity | |
| parent | 58a2473d6672eb4ae4f55c3fe4c25ea23d932db5 (diff) | |
loplugin:simplifybool extend to !(a == b) where comparison an overloaded op
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7
Reviewed-on: https://gerrit.libreoffice.org/67816
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'connectivity')
| -rw-r--r-- | connectivity/source/drivers/hsqldb/HCatalog.cxx | 2 | ||||
| -rw-r--r-- | connectivity/source/drivers/mork/MResultSet.cxx | 2 | ||||
| -rw-r--r-- | connectivity/source/drivers/mysql_jdbc/YCatalog.cxx | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/connectivity/source/drivers/hsqldb/HCatalog.cxx b/connectivity/source/drivers/hsqldb/HCatalog.cxx index 9824ead35dc8..029e60f9450a 100644 --- a/connectivity/source/drivers/hsqldb/HCatalog.cxx +++ b/connectivity/source/drivers/hsqldb/HCatalog.cxx @@ -138,7 +138,7 @@ Sequence< Type > SAL_CALL OHCatalog::getTypes( ) const Type* pEnd = pBegin + aTypes.getLength(); for(;pBegin != pEnd;++pBegin) { - if ( !(*pBegin == cppu::UnoType<XGroupsSupplier>::get())) + if ( *pBegin != cppu::UnoType<XGroupsSupplier>::get()) { aOwnTypes.push_back(*pBegin); } diff --git a/connectivity/source/drivers/mork/MResultSet.cxx b/connectivity/source/drivers/mork/MResultSet.cxx index 9f3d2e38f33a..880c035dbf6a 100644 --- a/connectivity/source/drivers/mork/MResultSet.cxx +++ b/connectivity/source/drivers/mork/MResultSet.cxx @@ -1001,7 +1001,7 @@ static bool matchRow( OValueRow const & row1, OValueRow const & row2 ) if ( row1Iter->isBound()) { // Compare values, if at anytime there's a mismatch return false - if ( !( (*row1Iter) == (*row2Iter) ) ) + if ( *row1Iter != *row2Iter ) return false; } } diff --git a/connectivity/source/drivers/mysql_jdbc/YCatalog.cxx b/connectivity/source/drivers/mysql_jdbc/YCatalog.cxx index 2c84d204f2bc..7255642dadda 100644 --- a/connectivity/source/drivers/mysql_jdbc/YCatalog.cxx +++ b/connectivity/source/drivers/mysql_jdbc/YCatalog.cxx @@ -122,7 +122,7 @@ Sequence<Type> SAL_CALL OMySQLCatalog::getTypes() const Type* pEnd = pBegin + aTypes.getLength(); for (; pBegin != pEnd; ++pBegin) { - if (!(*pBegin == cppu::UnoType<XGroupsSupplier>::get())) + if (*pBegin != cppu::UnoType<XGroupsSupplier>::get()) { aOwnTypes.push_back(*pBegin); } |