diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2015-12-31 10:26:43 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-01-04 14:44:33 +0000 |
| commit | f14d64fa71565e86c98348f9c54cc6cab53649d8 (patch) | |
| tree | 830034b8c4ac9e9bf83f049fabb3138f9a854486 /connectivity | |
| parent | 549e900b4b0047b8cb6c236ea50a3fc046e5fb51 (diff) | |
these fields can be static constants
Change-Id: Id56e219782d7f858cdeb26232c7aabd4f643c9d9
Reviewed-on: https://gerrit.libreoffice.org/21020
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'connectivity')
| -rw-r--r-- | connectivity/qa/connectivity/commontools/FValue_test.cxx | 17 |
1 files changed, 6 insertions, 11 deletions
diff --git a/connectivity/qa/connectivity/commontools/FValue_test.cxx b/connectivity/qa/connectivity/commontools/FValue_test.cxx index 2e6e326db960..1db73c687d85 100644 --- a/connectivity/qa/connectivity/commontools/FValue_test.cxx +++ b/connectivity/qa/connectivity/commontools/FValue_test.cxx @@ -339,46 +339,41 @@ void FValueTest::test_bit_getString() void FValueTest::test_bool_creation() { - OUString s1("1"); - OUString s0("0"); - OUString sTrue("true"); - OUString sTrUe("tRuE"); - OUString sFalse("false"); ORowSetValue vTrue(true); ORowSetValue vFalse(false); { - ORowSetValue v(s1); + ORowSetValue v(OUString("1")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vTrue); } { - ORowSetValue v(s0); + ORowSetValue v(OUString("0")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vFalse); } { - ORowSetValue v(sTrue); + ORowSetValue v(OUString("true")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vTrue); } { - ORowSetValue v(sTrUe); + ORowSetValue v(OUString("tRuE")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vTrue); } { - ORowSetValue v(sFalse); + ORowSetValue v(OUString("false")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vFalse); } { - ORowSetValue v(s0); + ORowSetValue v(OUString("0")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vFalse); } |