diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-06-14 20:57:16 +0100 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-06-15 11:11:42 +0100 |
commit | 8066c73940a30e97d8634655ea39d73fa8cf3c20 (patch) | |
tree | 030b5b52d9d7e67fd21c75f8b49defb4296d3e1e /connectivity | |
parent | 101b616c7a2ee90b6d09eedd7a7543a63f237c97 (diff) |
cppcheck: noExplicitConstructor
Change-Id: I2b5fba9cdd950349a8e8d22bbd7bb6e17f008920
Diffstat (limited to 'connectivity')
51 files changed, 68 insertions, 69 deletions
diff --git a/connectivity/source/drivers/firebird/Connection.cxx b/connectivity/source/drivers/firebird/Connection.cxx index 6ba3b1c644d5..6e3fc1518e27 100644 --- a/connectivity/source/drivers/firebird/Connection.cxx +++ b/connectivity/source/drivers/firebird/Connection.cxx @@ -112,7 +112,7 @@ void SAL_CALL Connection::release() throw() struct ConnectionGuard { oslInterlockedCount& m_refCount; - ConnectionGuard(oslInterlockedCount& refCount) + explicit ConnectionGuard(oslInterlockedCount& refCount) : m_refCount(refCount) { osl_atomic_increment(&m_refCount); diff --git a/connectivity/source/drivers/firebird/Connection.hxx b/connectivity/source/drivers/firebird/Connection.hxx index 5ce33878a791..1e90581ba755 100644 --- a/connectivity/source/drivers/firebird/Connection.hxx +++ b/connectivity/source/drivers/firebird/Connection.hxx @@ -171,7 +171,7 @@ namespace connectivity OUString transformPreparedStatement(const OUString& _sSQL); public: - Connection(FirebirdDriver* _pDriver); + explicit Connection(FirebirdDriver* _pDriver); virtual ~Connection(); void construct( const ::rtl::OUString& url, diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.hxx b/connectivity/source/drivers/firebird/DatabaseMetaData.hxx index abb4c1d75eaf..fb43242bb9d0 100644 --- a/connectivity/source/drivers/firebird/DatabaseMetaData.hxx +++ b/connectivity/source/drivers/firebird/DatabaseMetaData.hxx @@ -40,7 +40,7 @@ namespace connectivity ::rtl::Reference<Connection> m_pConnection; public: - ODatabaseMetaData(Connection* _pCon); + explicit ODatabaseMetaData(Connection* _pCon); virtual ~ODatabaseMetaData(); // as I mentioned before this interface is really BIG diff --git a/connectivity/source/drivers/firebird/Driver.hxx b/connectivity/source/drivers/firebird/Driver.hxx index d8785e874fd9..34bfb97b5655 100644 --- a/connectivity/source/drivers/firebird/Driver.hxx +++ b/connectivity/source/drivers/firebird/Driver.hxx @@ -63,7 +63,7 @@ namespace connectivity public: - FirebirdDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext); + explicit FirebirdDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext); virtual ~FirebirdDriver(); const css::uno::Reference<css::uno::XComponentContext>& getContext() const { return m_aContext; } diff --git a/connectivity/source/drivers/firebird/Statement.hxx b/connectivity/source/drivers/firebird/Statement.hxx index cf785b612cde..f8673cf4e052 100644 --- a/connectivity/source/drivers/firebird/Statement.hxx +++ b/connectivity/source/drivers/firebird/Statement.hxx @@ -44,7 +44,7 @@ namespace connectivity public: // a constructor, which is required for returning objects: - OStatement( Connection* _pConnection) + explicit OStatement( Connection* _pConnection) : OStatementCommonBase( _pConnection), m_pSqlda(0) {} diff --git a/connectivity/source/drivers/firebird/StatementCommonBase.hxx b/connectivity/source/drivers/firebird/StatementCommonBase.hxx index 8ebbad6251d9..29c4b2860427 100644 --- a/connectivity/source/drivers/firebird/StatementCommonBase.hxx +++ b/connectivity/source/drivers/firebird/StatementCommonBase.hxx @@ -104,7 +104,7 @@ namespace connectivity public: ::cppu::OBroadcastHelper& rBHelper; - OStatementCommonBase(Connection* _pConnection); + explicit OStatementCommonBase(Connection* _pConnection); using OStatementCommonBase_Base::operator ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >; // OComponentHelper diff --git a/connectivity/source/drivers/firebird/User.hxx b/connectivity/source/drivers/firebird/User.hxx index 775cf9c1f604..89133ff5997a 100644 --- a/connectivity/source/drivers/firebird/User.hxx +++ b/connectivity/source/drivers/firebird/User.hxx @@ -29,7 +29,7 @@ namespace connectivity /** * Create a "new" descriptor, which isn't yet in the database. */ - User(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection >& rConnection); + explicit User(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XConnection >& rConnection); /** * For a user that already exists in the db. */ @@ -46,4 +46,4 @@ namespace connectivity #endif // INCLUDED_CONNECTIVITY_SOURCE_DRIVERS_FIREBIRD_USER_HXX -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/connectivity/source/drivers/hsqldb/HTerminateListener.hxx b/connectivity/source/drivers/hsqldb/HTerminateListener.hxx index a5424039880c..1eded7b15567 100644 --- a/connectivity/source/drivers/hsqldb/HTerminateListener.hxx +++ b/connectivity/source/drivers/hsqldb/HTerminateListener.hxx @@ -37,7 +37,7 @@ namespace connectivity protected: virtual ~OConnectionController() {m_pDriver = NULL;} public: - OConnectionController(ODriverDelegator* _pDriver) : m_pDriver(_pDriver){} + explicit OConnectionController(ODriverDelegator* _pDriver) : m_pDriver(_pDriver){} // XEventListener virtual void SAL_CALL disposing( const ::com::sun::star::lang::EventObject& Source ) diff --git a/connectivity/source/drivers/kab/KCatalog.hxx b/connectivity/source/drivers/kab/KCatalog.hxx index 682f66a8cb35..abcc26fc0974 100644 --- a/connectivity/source/drivers/kab/KCatalog.hxx +++ b/connectivity/source/drivers/kab/KCatalog.hxx @@ -34,7 +34,7 @@ namespace connectivity ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XDatabaseMetaData > m_xMetaData; // just to make things easier public: - KabCatalog(KabConnection* _pCon); + explicit KabCatalog(KabConnection* _pCon); inline KabConnection* getConnection() const { return m_pConnection; } diff --git a/connectivity/source/drivers/kab/KDatabaseMetaData.hxx b/connectivity/source/drivers/kab/KDatabaseMetaData.hxx index d3de2e4307d2..21c51eb48be6 100644 --- a/connectivity/source/drivers/kab/KDatabaseMetaData.hxx +++ b/connectivity/source/drivers/kab/KDatabaseMetaData.hxx @@ -41,7 +41,7 @@ namespace connectivity public: - KabDatabaseMetaData(KabConnection* _pCon); + explicit KabDatabaseMetaData(KabConnection* _pCon); static const OUString & getAddressBookTableName(); virtual ~KabDatabaseMetaData(); diff --git a/connectivity/source/drivers/kab/KDriver.hxx b/connectivity/source/drivers/kab/KDriver.hxx index 429b9f8e0242..42cea307acbb 100644 --- a/connectivity/source/drivers/kab/KDriver.hxx +++ b/connectivity/source/drivers/kab/KDriver.hxx @@ -65,7 +65,7 @@ namespace connectivity KDEVersionCheckFunction m_pKDEVersionCheckFunc; public: - KabImplModule( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext ); + explicit KabImplModule( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext ); /** determines whether there is a KDE present in the environment */ @@ -155,7 +155,7 @@ namespace connectivity static OUString impl_getConfigurationSettingsPath(); protected: - KabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext); + explicit KabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext); // OComponentHelper virtual void SAL_CALL disposing() SAL_OVERRIDE; diff --git a/connectivity/source/drivers/kab/KResultSet.hxx b/connectivity/source/drivers/kab/KResultSet.hxx index 78fbffe14cc8..fc347d485ef5 100644 --- a/connectivity/source/drivers/kab/KResultSet.hxx +++ b/connectivity/source/drivers/kab/KResultSet.hxx @@ -91,7 +91,7 @@ namespace connectivity public: DECLARE_SERVICE_INFO(); - KabResultSet(KabCommonStatement *pStmt); + explicit KabResultSet(KabCommonStatement *pStmt); ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface > operator *() { diff --git a/connectivity/source/drivers/kab/KStatement.hxx b/connectivity/source/drivers/kab/KStatement.hxx index 9c45ea1fa380..bd01eaf88437 100644 --- a/connectivity/source/drivers/kab/KStatement.hxx +++ b/connectivity/source/drivers/kab/KStatement.hxx @@ -93,7 +93,7 @@ namespace connectivity public: ::cppu::OBroadcastHelper& rBHelper; - KabCommonStatement(KabConnection *_pConnection); + explicit KabCommonStatement(KabConnection *_pConnection); using KabCommonStatement_BASE::operator ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >; // OComponentHelper @@ -151,7 +151,7 @@ namespace connectivity virtual ~KabStatement() { } public: - KabStatement(KabConnection* _pConnection); + explicit KabStatement(KabConnection* _pConnection); DECLARE_SERVICE_INFO(); }; } diff --git a/connectivity/source/drivers/kab/kcondition.hxx b/connectivity/source/drivers/kab/kcondition.hxx index 7d1a3031295d..bc088d7e1dde 100644 --- a/connectivity/source/drivers/kab/kcondition.hxx +++ b/connectivity/source/drivers/kab/kcondition.hxx @@ -44,7 +44,7 @@ class KabConditionConstant : public KabCondition bool m_bValue; public: - KabConditionConstant(const bool bValue); + explicit KabConditionConstant(const bool bValue); virtual bool isAlwaysTrue() const SAL_OVERRIDE; virtual bool isAlwaysFalse() const SAL_OVERRIDE; virtual bool eval(const ::KABC::Addressee &aAddressee) const SAL_OVERRIDE; @@ -58,7 +58,7 @@ class KabConditionColumn : public KabCondition QString value(const ::KABC::Addressee &aAddressee) const; public: - KabConditionColumn( + explicit KabConditionColumn( const OUString &sColumnName) throw(::com::sun::star::sdbc::SQLException); virtual bool isAlwaysTrue() const SAL_OVERRIDE; virtual bool isAlwaysFalse() const SAL_OVERRIDE; @@ -67,7 +67,7 @@ class KabConditionColumn : public KabCondition class KabConditionNull : public KabConditionColumn { public: - KabConditionNull( + explicit KabConditionNull( const OUString &sColumnName) throw(::com::sun::star::sdbc::SQLException); virtual bool eval(const ::KABC::Addressee &aAddressee) const SAL_OVERRIDE; }; @@ -75,7 +75,7 @@ class KabConditionNull : public KabConditionColumn class KabConditionNotNull : public KabConditionColumn { public: - KabConditionNotNull( + explicit KabConditionNotNull( const OUString &sColumnName) throw(::com::sun::star::sdbc::SQLException); virtual bool eval(const ::KABC::Addressee &aAddressee) const SAL_OVERRIDE; }; diff --git a/connectivity/source/drivers/macab/MacabCatalog.hxx b/connectivity/source/drivers/macab/MacabCatalog.hxx index c02251dfcad1..0a4c7b9f2b9f 100644 --- a/connectivity/source/drivers/macab/MacabCatalog.hxx +++ b/connectivity/source/drivers/macab/MacabCatalog.hxx @@ -34,7 +34,7 @@ namespace connectivity ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XDatabaseMetaData > m_xMetaData; // just to make things easier public: - MacabCatalog(MacabConnection* _pCon); + explicit MacabCatalog(MacabConnection* _pCon); inline MacabConnection* getConnection() const { return m_pConnection; } diff --git a/connectivity/source/drivers/macab/MacabConnection.hxx b/connectivity/source/drivers/macab/MacabConnection.hxx index f0e6d514a942..36ed86ea7d3a 100644 --- a/connectivity/source/drivers/macab/MacabConnection.hxx +++ b/connectivity/source/drivers/macab/MacabConnection.hxx @@ -67,7 +67,7 @@ namespace connectivity public: virtual void construct( const OUString& url,const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& info) throw(::com::sun::star::sdbc::SQLException); - MacabConnection(MacabDriver* _pDriver); + explicit MacabConnection(MacabDriver* _pDriver); virtual ~MacabConnection(); void closeAllStatements () throw( ::com::sun::star::sdbc::SQLException); diff --git a/connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx b/connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx index eddecd809ba7..691da30f79dc 100644 --- a/connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx +++ b/connectivity/source/drivers/macab/MacabDatabaseMetaData.hxx @@ -43,7 +43,7 @@ namespace connectivity inline MacabConnection* getOwnConnection() const { return m_xConnection.get(); } - MacabDatabaseMetaData(MacabConnection* _pCon); + explicit MacabDatabaseMetaData(MacabConnection* _pCon); virtual ~MacabDatabaseMetaData(); // this interface is really BIG diff --git a/connectivity/source/drivers/macab/MacabDriver.hxx b/connectivity/source/drivers/macab/MacabDriver.hxx index 0c667e5a155a..508cae0d83d8 100644 --- a/connectivity/source/drivers/macab/MacabDriver.hxx +++ b/connectivity/source/drivers/macab/MacabDriver.hxx @@ -132,7 +132,7 @@ namespace connectivity static OUString impl_getConfigurationSettingsPath(); protected: - MacabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext); + explicit MacabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext); // OComponentHelper virtual void SAL_CALL disposing() SAL_OVERRIDE; diff --git a/connectivity/source/drivers/macab/MacabRecord.hxx b/connectivity/source/drivers/macab/MacabRecord.hxx index 3e8cf7a1dbc3..0f84bc98c43c 100644 --- a/connectivity/source/drivers/macab/MacabRecord.hxx +++ b/connectivity/source/drivers/macab/MacabRecord.hxx @@ -49,7 +49,7 @@ namespace connectivity void releaseFields(); public: MacabRecord(); - MacabRecord(const sal_Int32 _size); + explicit MacabRecord(const sal_Int32 _size); virtual ~MacabRecord(); void insertAtColumn (CFTypeRef _value, ABPropertyType _type, const sal_Int32 _column); bool contains(const macabfield *_field) const; diff --git a/connectivity/source/drivers/macab/MacabRecords.hxx b/connectivity/source/drivers/macab/MacabRecords.hxx index 5a5035258990..615c8ba313c1 100644 --- a/connectivity/source/drivers/macab/MacabRecords.hxx +++ b/connectivity/source/drivers/macab/MacabRecords.hxx @@ -78,8 +78,8 @@ namespace connectivity void insertPropertyIntoMacabRecord(const ABPropertyType _propertyType, MacabRecord *_abrecord, const MacabHeader *_header, const OUString& _propertyName, const CFTypeRef _propertyValue) const; public: MacabRecords(const ABAddressBookRef _addressBook, MacabHeader *_header, MacabRecord **_records, sal_Int32 _numRecords); - MacabRecords(const MacabRecords *_copy); - MacabRecords(const ABAddressBookRef _addressBook); + explicit MacabRecords(const MacabRecords *_copy); + explicit MacabRecords(const ABAddressBookRef _addressBook); ~MacabRecords(); void initialize(); diff --git a/connectivity/source/drivers/macab/MacabResultSet.hxx b/connectivity/source/drivers/macab/MacabResultSet.hxx index 747b6a192e3e..61b4cb0746f2 100644 --- a/connectivity/source/drivers/macab/MacabResultSet.hxx +++ b/connectivity/source/drivers/macab/MacabResultSet.hxx @@ -91,7 +91,7 @@ namespace connectivity public: DECLARE_SERVICE_INFO(); - MacabResultSet(MacabCommonStatement *pStmt); + explicit MacabResultSet(MacabCommonStatement *pStmt); ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface > operator *() { diff --git a/connectivity/source/drivers/macab/MacabStatement.hxx b/connectivity/source/drivers/macab/MacabStatement.hxx index fc3a1d1752af..79d420e38518 100644 --- a/connectivity/source/drivers/macab/MacabStatement.hxx +++ b/connectivity/source/drivers/macab/MacabStatement.hxx @@ -96,7 +96,7 @@ namespace connectivity public: ::cppu::OBroadcastHelper& rBHelper; - MacabCommonStatement(MacabConnection *_pConnection); + explicit MacabCommonStatement(MacabConnection *_pConnection); using MacabCommonStatement_BASE::operator ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >; // OComponentHelper @@ -157,7 +157,7 @@ namespace connectivity virtual ~MacabStatement() { } public: - MacabStatement(MacabConnection* _pConnection); + explicit MacabStatement(MacabConnection* _pConnection); DECLARE_SERVICE_INFO(); }; } diff --git a/connectivity/source/drivers/macab/macabcondition.hxx b/connectivity/source/drivers/macab/macabcondition.hxx index 6ee7d5eac687..9ecfb42a13fe 100644 --- a/connectivity/source/drivers/macab/macabcondition.hxx +++ b/connectivity/source/drivers/macab/macabcondition.hxx @@ -46,7 +46,7 @@ class MacabConditionConstant : public MacabCondition bool m_bValue; public: - MacabConditionConstant(const bool bValue); + explicit MacabConditionConstant(const bool bValue); virtual bool isAlwaysTrue() const SAL_OVERRIDE; virtual bool isAlwaysFalse() const SAL_OVERRIDE; virtual bool eval(const MacabRecord *aRecord) const SAL_OVERRIDE; diff --git a/connectivity/source/drivers/mork/MCatalog.hxx b/connectivity/source/drivers/mork/MCatalog.hxx index 30947278b8da..4c0f9d0973e8 100644 --- a/connectivity/source/drivers/mork/MCatalog.hxx +++ b/connectivity/source/drivers/mork/MCatalog.hxx @@ -41,7 +41,7 @@ namespace connectivity virtual void refreshUsers() SAL_OVERRIDE ; virtual ::com::sun::star::uno::Reference< ::com::sun::star::container::XNameAccess > SAL_CALL getTables( ) throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; public: - OCatalog(OConnection* _pCon); + explicit OCatalog(OConnection* _pCon); OConnection* getConnection() const { return m_pConnection; } sdbcx::OCollection* getPrivateTables() const { return m_pTables;} diff --git a/connectivity/source/drivers/mork/MColumnAlias.hxx b/connectivity/source/drivers/mork/MColumnAlias.hxx index f45453bfd159..742451dd191d 100644 --- a/connectivity/source/drivers/mork/MColumnAlias.hxx +++ b/connectivity/source/drivers/mork/MColumnAlias.hxx @@ -56,7 +56,7 @@ namespace connectivity AliasMap m_aAliasMap; public: - OColumnAlias( const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory > & ); + explicit OColumnAlias( const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory > & ); inline bool hasAlias( const OUString& _rAlias ) const { diff --git a/connectivity/source/drivers/mork/MConnection.hxx b/connectivity/source/drivers/mork/MConnection.hxx index f843f8eabb48..ac4616be9785 100644 --- a/connectivity/source/drivers/mork/MConnection.hxx +++ b/connectivity/source/drivers/mork/MConnection.hxx @@ -59,7 +59,7 @@ namespace connectivity public: void construct( const OUString& url,const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& info) throw(::com::sun::star::sdbc::SQLException); - OConnection(MorkDriver* const driver); + explicit OConnection(MorkDriver* const driver); virtual ~OConnection(); MorkDriver* getDriver() {return m_pDriver;}; diff --git a/connectivity/source/drivers/mork/MDatabaseMetaData.hxx b/connectivity/source/drivers/mork/MDatabaseMetaData.hxx index f9b693010b8b..d67b177dc1b8 100644 --- a/connectivity/source/drivers/mork/MDatabaseMetaData.hxx +++ b/connectivity/source/drivers/mork/MDatabaseMetaData.hxx @@ -45,7 +45,7 @@ namespace connectivity inline OConnection* getOwnConnection() const { return m_pConnection; } - ODatabaseMetaData(OConnection* _pCon); + explicit ODatabaseMetaData(OConnection* _pCon); private: virtual ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XResultSet > impl_getTypeInfo_throw() SAL_OVERRIDE; diff --git a/connectivity/source/drivers/mork/MDriver.hxx b/connectivity/source/drivers/mork/MDriver.hxx index 9aa9e1b2a4ab..4c832948e702 100644 --- a/connectivity/source/drivers/mork/MDriver.hxx +++ b/connectivity/source/drivers/mork/MDriver.hxx @@ -51,7 +51,7 @@ class MorkDriver: private boost::noncopyable { public: - MorkDriver(css::uno::Reference< css::uno::XComponentContext > const context); + explicit MorkDriver(css::uno::Reference< css::uno::XComponentContext > const context); static OUString getImplementationName_Static() throw(css::uno::RuntimeException); static css::uno::Sequence< OUString > getSupportedServiceNames_Static() diff --git a/connectivity/source/drivers/mork/MNSINIParser.hxx b/connectivity/source/drivers/mork/MNSINIParser.hxx index 3dbbaa6ded13..fd3c518b190f 100644 --- a/connectivity/source/drivers/mork/MNSINIParser.hxx +++ b/connectivity/source/drivers/mork/MNSINIParser.hxx @@ -60,7 +60,7 @@ class IniParser IniSectionMap mAllSection; public: IniSectionMap& getAllSection() { return mAllSection; } - IniParser(OUString const & rIniName) throw(com::sun::star::io::IOException); + explicit IniParser(OUString const & rIniName) throw(com::sun::star::io::IOException); }; #endif diff --git a/connectivity/source/drivers/mork/MQueryHelper.hxx b/connectivity/source/drivers/mork/MQueryHelper.hxx index cdf6043ecd8b..23cffe295140 100644 --- a/connectivity/source/drivers/mork/MQueryHelper.hxx +++ b/connectivity/source/drivers/mork/MQueryHelper.hxx @@ -64,7 +64,7 @@ namespace connectivity node_type m_eNodeType; MQueryExpressionBase() : m_eNodeType( Unknown ) {} - MQueryExpressionBase( node_type _eNodeType ) : m_eNodeType( _eNodeType ) {} + explicit MQueryExpressionBase( node_type _eNodeType ) : m_eNodeType( _eNodeType ) {} public: virtual ~MQueryExpressionBase() {} @@ -193,7 +193,7 @@ namespace connectivity sal_Int32 doQueryListTable(OConnection* xConnection, OString& ouStringTable); public: - MQueryHelper(const OColumnAlias& _ca); + explicit MQueryHelper(const OColumnAlias& _ca); virtual ~MQueryHelper(); void reset(); diff --git a/connectivity/source/drivers/mork/MResultSet.hxx b/connectivity/source/drivers/mork/MResultSet.hxx index 7a18d3aa3f7f..6be1c27e4e78 100644 --- a/connectivity/source/drivers/mork/MResultSet.hxx +++ b/connectivity/source/drivers/mork/MResultSet.hxx @@ -345,7 +345,7 @@ public: class ResultSetEntryGuard : public ::osl::MutexGuard { public: - ResultSetEntryGuard( OResultSet& _rRS ) : ::osl::MutexGuard( _rRS.getMutex() ) + explicit ResultSetEntryGuard( OResultSet& _rRS ) : ::osl::MutexGuard( _rRS.getMutex() ) { _rRS.methodEntry(); } diff --git a/connectivity/source/drivers/mork/MStatement.hxx b/connectivity/source/drivers/mork/MStatement.hxx index b5eaffc6fdea..2818aeb439b3 100644 --- a/connectivity/source/drivers/mork/MStatement.hxx +++ b/connectivity/source/drivers/mork/MStatement.hxx @@ -149,7 +149,7 @@ namespace connectivity // other methods OConnection* getOwnConnection() const { return m_pConnection;} - OCommonStatement(OConnection* _pConnection ); + explicit OCommonStatement(OConnection* _pConnection ); using OCommonStatement_IBASE::operator ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >; // OComponentHelper @@ -187,7 +187,7 @@ namespace connectivity virtual ~OStatement(){} public: // a constructor, for when the object needs to be returned: - OStatement( OConnection* _pConnection); + explicit OStatement( OConnection* _pConnection); DECLARE_SERVICE_INFO(); virtual ::com::sun::star::uno::Any SAL_CALL queryInterface( const ::com::sun::star::uno::Type & rType ) throw(::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/connectivity/source/drivers/mork/MorkParser.hxx b/connectivity/source/drivers/mork/MorkParser.hxx index d73acc85d338..01d47e343962 100644 --- a/connectivity/source/drivers/mork/MorkParser.hxx +++ b/connectivity/source/drivers/mork/MorkParser.hxx @@ -83,7 +83,7 @@ class LO_DLLPUBLIC_MORK MorkParser { public: - MorkParser( int defaultScope = 0x80 ); + explicit MorkParser( int defaultScope = 0x80 ); /// Open and parse mork file diff --git a/connectivity/source/drivers/mozab/MCatalog.hxx b/connectivity/source/drivers/mozab/MCatalog.hxx index 6ebfcb67f573..3df1ab852f83 100644 --- a/connectivity/source/drivers/mozab/MCatalog.hxx +++ b/connectivity/source/drivers/mozab/MCatalog.hxx @@ -41,7 +41,7 @@ namespace connectivity virtual void refreshUsers() ; virtual ::com::sun::star::uno::Reference< ::com::sun::star::container::XNameAccess > SAL_CALL getTables( ) throw(::com::sun::star::uno::RuntimeException); public: - OCatalog(OConnection* _pCon); + explicit OCatalog(OConnection* _pCon); OConnection* getConnection() const { return m_pConnection; } sdbcx::OCollection* getPrivateTables() const { return m_pTables;} diff --git a/connectivity/source/drivers/mozab/MColumnAlias.hxx b/connectivity/source/drivers/mozab/MColumnAlias.hxx index 4067fd621ca6..807cb112862a 100644 --- a/connectivity/source/drivers/mozab/MColumnAlias.hxx +++ b/connectivity/source/drivers/mozab/MColumnAlias.hxx @@ -56,7 +56,7 @@ namespace connectivity AliasMap m_aAliasMap; public: - OColumnAlias( const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory > & ); + explicit OColumnAlias( const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory > & ); inline bool hasAlias( const OUString& _rAlias ) const { diff --git a/connectivity/source/drivers/mozab/MConnection.hxx b/connectivity/source/drivers/mozab/MConnection.hxx index ec7d017b6a44..597b73b4f249 100644 --- a/connectivity/source/drivers/mozab/MConnection.hxx +++ b/connectivity/source/drivers/mozab/MConnection.hxx @@ -128,7 +128,7 @@ namespace connectivity public: virtual void construct( const OUString& url,const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& info) throw(::com::sun::star::sdbc::SQLException); - OConnection(MozabDriver* _pDriver); + explicit OConnection(MozabDriver* _pDriver); virtual ~OConnection(); void closeAllStatements () throw( ::com::sun::star::sdbc::SQLException); diff --git a/connectivity/source/drivers/mozab/MDatabaseMetaData.hxx b/connectivity/source/drivers/mozab/MDatabaseMetaData.hxx index 553aff56e7b1..4c9410517bf8 100644 --- a/connectivity/source/drivers/mozab/MDatabaseMetaData.hxx +++ b/connectivity/source/drivers/mozab/MDatabaseMetaData.hxx @@ -45,7 +45,7 @@ namespace connectivity inline OConnection* getOwnConnection() const { return m_pConnection; } - ODatabaseMetaData(OConnection* _pCon); + explicit ODatabaseMetaData(OConnection* _pCon); private: virtual ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XResultSet > impl_getTypeInfo_throw(); diff --git a/connectivity/source/drivers/mozab/MDriver.hxx b/connectivity/source/drivers/mozab/MDriver.hxx index 37545c83aa0c..fc2555cd1f08 100644 --- a/connectivity/source/drivers/mozab/MDriver.hxx +++ b/connectivity/source/drivers/mozab/MDriver.hxx @@ -71,7 +71,7 @@ namespace connectivity virtual ~MozabDriver(); public: - MozabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory); + explicit MozabDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory); // OComponentHelper virtual void SAL_CALL disposing(); diff --git a/connectivity/source/drivers/mozab/MResultSet.hxx b/connectivity/source/drivers/mozab/MResultSet.hxx index 22e30ec1d783..3c1ac243af18 100644 --- a/connectivity/source/drivers/mozab/MResultSet.hxx +++ b/connectivity/source/drivers/mozab/MResultSet.hxx @@ -346,7 +346,7 @@ public: class ResultSetEntryGuard : public ::osl::MutexGuard { public: - ResultSetEntryGuard( OResultSet& _rRS ) : ::osl::MutexGuard( _rRS.getMutex() ) + explicit ResultSetEntryGuard( OResultSet& _rRS ) : ::osl::MutexGuard( _rRS.getMutex() ) { _rRS.methodEntry(); } diff --git a/connectivity/source/drivers/mozab/MStatement.hxx b/connectivity/source/drivers/mozab/MStatement.hxx index 59b30fb3ad7e..b6ce3eb82e8e 100644 --- a/connectivity/source/drivers/mozab/MStatement.hxx +++ b/connectivity/source/drivers/mozab/MStatement.hxx @@ -151,7 +151,7 @@ namespace connectivity // other methods OConnection* getOwnConnection() const { return m_pConnection;} - OCommonStatement(OConnection* _pConnection ); + explicit OCommonStatement(OConnection* _pConnection ); using OCommonStatement_IBASE::operator ::com::sun::star::uno::Reference< ::com::sun::star::uno::XInterface >; // OComponentHelper @@ -189,7 +189,7 @@ namespace connectivity ~OStatement(){} public: // a constructor, for when the object needs to be returned: - OStatement( OConnection* _pConnection) : OCommonStatement( _pConnection){} + expliit OStatement( OConnection* _pConnection) : OCommonStatement( _pConnection){} DECLARE_SERVICE_INFO(); virtual ::com::sun::star::uno::Any SAL_CALL queryInterface( const ::com::sun::star::uno::Type & rType ) throw(::com::sun::star::uno::RuntimeException); diff --git a/connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.hxx b/connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.hxx index 58ff8fd3cffb..81637f4f8c27 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.hxx +++ b/connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.hxx @@ -48,7 +48,7 @@ namespace connectivity public: void Init(); - MozillaBootstrap(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory); + explicit MozillaBootstrap(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory); // OComponentHelper virtual void SAL_CALL disposing() SAL_OVERRIDE; diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx b/connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx index b901156ebcb1..dc3e2749d011 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx +++ b/connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx @@ -59,7 +59,7 @@ class IniParser IniSectionMap mAllSection; public: IniSectionMap& getAllSection() { return mAllSection; } - IniParser(OUString const & rIniName) throw(com::sun::star::io::IOException); + explicit IniParser(OUString const & rIniName) throw(com::sun::star::io::IOException); }; #endif diff --git a/connectivity/source/drivers/mozab/mozillasrc/MQuery.hxx b/connectivity/source/drivers/mozab/mozillasrc/MQuery.hxx index 524fe5e0014b..523e37628af6 100644 --- a/connectivity/source/drivers/mozab/mozillasrc/MQuery.hxx +++ b/connectivity/source/drivers/mozab/mozillasrc/MQuery.hxx @@ -63,7 +63,7 @@ namespace connectivity node_type m_eNodeType; MQueryExpressionBase() : m_eNodeType( Unknown ) {} - MQueryExpressionBase( node_type _eNodeType ) : m_eNodeType( _eNodeType ) {} + explicit MQueryExpressionBase( node_type _eNodeType ) : m_eNodeType( _eNodeType ) {} public: sal_Bool isUnknown( ) const { return m_eNodeType == Unknown; } @@ -254,8 +254,7 @@ namespace connectivity inline const ErrorDescriptor& getError() const { return m_aError; } public: -// MQuery(); - MQuery( const OColumnAlias& _ca ); + explicit MQuery( const OColumnAlias& _ca ); virtual ~MQuery(); static MNameMapper* CreateNameMapper(); static void FreeNameMapper( MNameMapper* _ptr ); diff --git a/connectivity/source/drivers/odbc/ORealDriver.cxx b/connectivity/source/drivers/odbc/ORealDriver.cxx index 27b23ff7d047..f5f4f2e20a00 100644 --- a/connectivity/source/drivers/odbc/ORealDriver.cxx +++ b/connectivity/source/drivers/odbc/ORealDriver.cxx @@ -97,7 +97,7 @@ namespace connectivity virtual oslGenericFunction getOdbcFunction(ODBC3SQLFunctionId _nIndex) const SAL_OVERRIDE; virtual SQLHANDLE EnvironmentHandle(OUString &_rPath) SAL_OVERRIDE; public: - ORealObdcDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory) : ODBCDriver(_rxFactory) {} + explicit ORealObdcDriver(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory >& _rxFactory) : ODBCDriver(_rxFactory) {} }; diff --git a/connectivity/source/drivers/postgresql/pq_driver.hxx b/connectivity/source/drivers/postgresql/pq_driver.hxx index 0751184d6336..b10077656135 100644 --- a/connectivity/source/drivers/postgresql/pq_driver.hxx +++ b/connectivity/source/drivers/postgresql/pq_driver.hxx @@ -74,7 +74,7 @@ class Driver : public MutexHolder, public DriverBase com::sun::star::uno::Reference< com::sun::star::lang::XMultiComponentFactory > m_smgr; public: - Driver ( const com::sun::star::uno::Reference < com::sun::star::uno::XComponentContext > & ctx ) + explicit Driver ( const com::sun::star::uno::Reference < com::sun::star::uno::XComponentContext > & ctx ) : DriverBase( this->m_mutex ), m_ctx( ctx ), m_smgr( ctx->getServiceManager() ) diff --git a/connectivity/source/drivers/postgresql/pq_tools.hxx b/connectivity/source/drivers/postgresql/pq_tools.hxx index 00a385893efa..f08cebcd16d3 100644 --- a/connectivity/source/drivers/postgresql/pq_tools.hxx +++ b/connectivity/source/drivers/postgresql/pq_tools.hxx @@ -146,7 +146,7 @@ class DisposeGuard { com::sun::star::uno::Reference< com::sun::star::uno::XInterface > d; public: - DisposeGuard(const com::sun::star::uno::Reference< com::sun::star::uno::XInterface > & r ); + explicit DisposeGuard(const com::sun::star::uno::Reference< com::sun::star::uno::XInterface > & r ); ~DisposeGuard(); }; @@ -157,7 +157,7 @@ class TransactionGuard bool m_commited; public: /// takes over ownership of given statemet - TransactionGuard( const com::sun::star::uno::Reference< com::sun::star::sdbc::XStatement > &stmt ); + explicit TransactionGuard( const com::sun::star::uno::Reference< com::sun::star::sdbc::XStatement > &stmt ); ~TransactionGuard( ); void commit(); diff --git a/connectivity/source/drivers/postgresql/pq_xcontainer.cxx b/connectivity/source/drivers/postgresql/pq_xcontainer.cxx index a5d8f86bbb5e..66f917e1869c 100644 --- a/connectivity/source/drivers/postgresql/pq_xcontainer.cxx +++ b/connectivity/source/drivers/postgresql/pq_xcontainer.cxx @@ -240,7 +240,7 @@ class ContainerEnumeration : public ::cppu::WeakImplHelper1< XEnumeration > com::sun::star::uno::Sequence< com::sun::star::uno::Any > m_vec; sal_Int32 m_index; public: - ContainerEnumeration( const com::sun::star::uno::Sequence< com::sun::star::uno::Any > &vec ) + explicit ContainerEnumeration( const com::sun::star::uno::Sequence< com::sun::star::uno::Any > &vec ) : m_vec( vec ), m_index( -1 ) {} diff --git a/connectivity/source/drivers/postgresql/pq_xcontainer.hxx b/connectivity/source/drivers/postgresql/pq_xcontainer.hxx index c585489e1ec6..1fe97dc4c44c 100644 --- a/connectivity/source/drivers/postgresql/pq_xcontainer.hxx +++ b/connectivity/source/drivers/postgresql/pq_xcontainer.hxx @@ -70,7 +70,7 @@ class RefreshedBroadcaster : public EventBroadcastHelper { com::sun::star::lang::EventObject m_event; public: - RefreshedBroadcaster(const com::sun::star::uno::Reference< com::sun::star::uno::XInterface > & source ) : + explicit RefreshedBroadcaster(const com::sun::star::uno::Reference< com::sun::star::uno::XInterface > & source ) : m_event( source ) {} diff --git a/connectivity/source/manager/mdrivermanager.cxx b/connectivity/source/manager/mdrivermanager.cxx index b64e935374da..7f2e7f02c533 100644 --- a/connectivity/source/manager/mdrivermanager.cxx +++ b/connectivity/source/manager/mdrivermanager.cxx @@ -68,7 +68,7 @@ class ODriverEnumeration : public ::cppu::WeakImplHelper1< XEnumeration > protected: virtual ~ODriverEnumeration(); public: - ODriverEnumeration(const DriverArray& _rDriverSequence); + explicit ODriverEnumeration(const DriverArray& _rDriverSequence); // XEnumeration virtual sal_Bool SAL_CALL hasMoreElements( ) throw(RuntimeException, std::exception) SAL_OVERRIDE; @@ -106,7 +106,7 @@ Any SAL_CALL ODriverEnumeration::nextElement( ) throw(NoSuchElementException, W /// an STL functor which ensures that a SdbcDriver described by a DriverAccess is loaded struct EnsureDriver : public ::std::unary_function< DriverAccess, DriverAccess > { - EnsureDriver( const Reference< XComponentContext > &rxContext ) + explicit EnsureDriver( const Reference< XComponentContext > &rxContext ) : mxContext( rxContext ) {} const DriverAccess& operator()( const DriverAccess& _rDescriptor ) const @@ -151,7 +151,7 @@ Any SAL_CALL ODriverEnumeration::nextElement( ) throw(NoSuchElementException, W /// an STL functor which loads a driver described by a DriverAccess, and extracts the SdbcDriver struct ExtractAfterLoad : public ExtractAfterLoad_BASE { - ExtractAfterLoad( const Reference< XComponentContext > &rxContext ) + explicit ExtractAfterLoad( const Reference< XComponentContext > &rxContext ) : ExtractAfterLoad_BASE( ExtractDriverFromAccess(), EnsureDriver( rxContext ) ) {} }; @@ -171,7 +171,7 @@ Any SAL_CALL ODriverEnumeration::nextElement( ) throw(NoSuchElementException, W public: // ctor - AcceptsURL( const OUString& _rURL ) : m_rURL( _rURL ) { } + explicit AcceptsURL( const OUString& _rURL ) : m_rURL( _rURL ) { } bool operator()( const Reference<XDriver>& _rDriver ) const @@ -241,7 +241,7 @@ Any SAL_CALL ODriverEnumeration::nextElement( ) throw(NoSuchElementException, W struct EqualDriverAccessToName : public ::std::binary_function< DriverAccess, OUString, bool > { OUString m_sImplName; - EqualDriverAccessToName(const OUString& _sImplName) : m_sImplName(_sImplName){} + explicit EqualDriverAccessToName(const OUString& _sImplName) : m_sImplName(_sImplName){} bool operator()( const DriverAccess& lhs) { diff --git a/connectivity/source/manager/mdrivermanager.hxx b/connectivity/source/manager/mdrivermanager.hxx index ec4dea8baeb2..0f40800d2250 100644 --- a/connectivity/source/manager/mdrivermanager.hxx +++ b/connectivity/source/manager/mdrivermanager.hxx @@ -77,7 +77,7 @@ namespace drivermanager sal_Int32 m_nLoginTimeout; private: - OSDBCDriverManager( + explicit OSDBCDriverManager( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxContext ); virtual ~OSDBCDriverManager(); diff --git a/connectivity/workben/iniParser/main.cxx b/connectivity/workben/iniParser/main.cxx index e562e065ef1b..1ac73c547d11 100644 --- a/connectivity/workben/iniParser/main.cxx +++ b/connectivity/workben/iniParser/main.cxx @@ -64,7 +64,7 @@ public: return &mAllSection[secName]; return NULL; } - IniParser(OUString const & rIniName) throw(com::sun::star::io::IOException ) + explicit IniParser(OUString const & rIniName) throw(com::sun::star::io::IOException ) { OUString curDirPth; OUString iniUrl; |