diff options
| author | Julien Nabet <serval2412@yahoo.fr> | 2020-03-09 18:59:29 +0100 |
|---|---|---|
| committer | Julien Nabet <serval2412@yahoo.fr> | 2020-03-09 20:54:03 +0100 |
| commit | 2ede753a8b7adecbf6ca78745e43e23c7498e289 (patch) | |
| tree | ac6c40e5fa5126b6bc5f798e9a1ff4f6e17d9619 /connectivity | |
| parent | 6340984c367a69d9e29f7198c4bed089e91bcd42 (diff) | |
tdf#130334: Firebird deal with array fields
See https://bugs.documentfoundation.org/show_bug.cgi?id=130334#c11
See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes-bnrytypes.html#fblangref25-datatypes-array
Change-Id: I27c53b9c771fcdb3b89e66af325a8234c7de08bb
Change-Id: I7b9d27f78e351eda611d13f5a07ef3c80ff00e3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90239
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Diffstat (limited to 'connectivity')
| -rw-r--r-- | connectivity/source/drivers/firebird/Util.cxx | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/connectivity/source/drivers/firebird/Util.cxx b/connectivity/source/drivers/firebird/Util.cxx index 020dffbf2076..090e34ca2781 100644 --- a/connectivity/source/drivers/firebird/Util.cxx +++ b/connectivity/source/drivers/firebird/Util.cxx @@ -306,12 +306,12 @@ void firebird::mallocSQLVAR(XSQLDA* pSqlda) case SQL_TIMESTAMP: pVar->sqldata = static_cast<char*>(malloc(sizeof(ISC_TIMESTAMP))); break; + // an ARRAY is in fact a BLOB of a specialized type + // See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes-bnrytypes.html#fblangref25-datatypes-array + case SQL_ARRAY: case SQL_BLOB: pVar->sqldata = static_cast<char*>(malloc(sizeof(ISC_QUAD))); break; - case SQL_ARRAY: - assert(false); // TODO: implement - break; case SQL_TYPE_TIME: pVar->sqldata = static_cast<char*>(malloc(sizeof(ISC_TIME))); break; @@ -355,6 +355,9 @@ void firebird::freeSQLVAR(XSQLDA* pSqlda) case SQL_DOUBLE: case SQL_D_FLOAT: case SQL_TIMESTAMP: + // an ARRAY is in fact a BLOB of a specialized type + // See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes-bnrytypes.html#fblangref25-datatypes-array + case SQL_ARRAY: case SQL_BLOB: case SQL_INT64: case SQL_TYPE_TIME: @@ -366,9 +369,6 @@ void firebird::freeSQLVAR(XSQLDA* pSqlda) pVar->sqldata = nullptr; } break; - case SQL_ARRAY: - assert(false); // TODO: implement - break; case SQL_NULL: assert(false); // TODO: implement break; |