diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-29 08:15:20 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-29 09:35:30 +0200 |
commit | 497e40ad03c27837978551ba15491c3fb2a0bf53 (patch) | |
tree | baa53156ae5234b65f645e11e590c64e569c6284 /connectivity | |
parent | 71112060e0930fc58087c3762e836b1e12b60f75 (diff) |
improve refcounting loplugin
to find ref-counted classes being managed via other smart pointer
classes.
Hopefully prevent needing fixes like
642ae256ea5b8083ba0b3c097ca8ea52304b9cdb
"ChangedUIEventListener is refcounted, mustn't be helt by unique_ptr"
Change-Id: I6b0c5f8f87ce3546a8a1104ce1000470c09459bd
Reviewed-on: https://gerrit.libreoffice.org/39378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'connectivity')
-rw-r--r-- | connectivity/source/commontools/TIndex.cxx | 4 | ||||
-rw-r--r-- | connectivity/source/commontools/TKey.cxx | 2 | ||||
-rw-r--r-- | connectivity/source/drivers/ado/AGroup.cxx | 2 | ||||
-rw-r--r-- | connectivity/source/drivers/ado/AIndex.cxx | 2 | ||||
-rw-r--r-- | connectivity/source/drivers/ado/AKey.cxx | 2 | ||||
-rw-r--r-- | connectivity/source/drivers/ado/AUser.cxx | 2 | ||||
-rw-r--r-- | connectivity/source/drivers/dbase/DIndex.cxx | 2 |
7 files changed, 8 insertions, 8 deletions
diff --git a/connectivity/source/commontools/TIndex.cxx b/connectivity/source/commontools/TIndex.cxx index 28c1827075eb..539687696c0a 100644 --- a/connectivity/source/commontools/TIndex.cxx +++ b/connectivity/source/commontools/TIndex.cxx @@ -37,7 +37,7 @@ OIndexHelper::OIndexHelper( OTableHelper* _pTable) : connectivity::sdbcx::OIndex { construct(); std::vector< OUString> aVector; - m_pColumns.reset( new OIndexColumns(this,m_aMutex,aVector) ); + m_pColumns = new OIndexColumns(this,m_aMutex,aVector); } OIndexHelper::OIndexHelper( OTableHelper* _pTable, @@ -93,7 +93,7 @@ void OIndexHelper::refreshColumns() if(m_pColumns) m_pColumns->reFill(aVector); else - m_pColumns.reset( new OIndexColumns(this,m_aMutex,aVector) ); + m_pColumns = new OIndexColumns(this,m_aMutex,aVector); } diff --git a/connectivity/source/commontools/TKey.cxx b/connectivity/source/commontools/TKey.cxx index 89d5bf44b3f1..815e025602bb 100644 --- a/connectivity/source/commontools/TKey.cxx +++ b/connectivity/source/commontools/TKey.cxx @@ -100,7 +100,7 @@ void OTableKeyHelper::refreshColumns() if ( m_pColumns ) m_pColumns->reFill(aVector); else - m_pColumns.reset( new OKeyColumnsHelper(this,m_aMutex,aVector) ); + m_pColumns = new OKeyColumnsHelper(this,m_aMutex,aVector); } diff --git a/connectivity/source/drivers/ado/AGroup.cxx b/connectivity/source/drivers/ado/AGroup.cxx index b9687d7823bc..274402b61744 100644 --- a/connectivity/source/drivers/ado/AGroup.cxx +++ b/connectivity/source/drivers/ado/AGroup.cxx @@ -79,7 +79,7 @@ void OAdoGroup::refreshUsers() if(m_pUsers) m_pUsers->reFill(aVector); else - m_pUsers.reset( new OUsers(m_pCatalog,m_aMutex,aVector,aUsers,isCaseSensitive()) ); + m_pUsers = new OUsers(m_pCatalog,m_aMutex,aVector,aUsers,isCaseSensitive()); } Sequence< sal_Int8 > OAdoGroup::getUnoTunnelImplementationId() diff --git a/connectivity/source/drivers/ado/AIndex.cxx b/connectivity/source/drivers/ado/AIndex.cxx index c4ad0bb22273..3f5cffc26487 100644 --- a/connectivity/source/drivers/ado/AIndex.cxx +++ b/connectivity/source/drivers/ado/AIndex.cxx @@ -68,7 +68,7 @@ void OAdoIndex::refreshColumns() if ( m_pColumns ) m_pColumns->reFill(aVector); else - m_pColumns.reset( new OColumns(*this,m_aMutex,aVector,aColumns,isCaseSensitive(),m_pConnection) ); + m_pColumns = new OColumns(*this,m_aMutex,aVector,aColumns,isCaseSensitive(),m_pConnection); } diff --git a/connectivity/source/drivers/ado/AKey.cxx b/connectivity/source/drivers/ado/AKey.cxx index f8797f779a85..d5686893f184 100644 --- a/connectivity/source/drivers/ado/AKey.cxx +++ b/connectivity/source/drivers/ado/AKey.cxx @@ -64,7 +64,7 @@ void OAdoKey::refreshColumns() if(m_pColumns) m_pColumns->reFill(aVector); else - m_pColumns.reset( new OColumns(*this,m_aMutex,aVector,aColumns,isCaseSensitive(),m_pConnection) ); + m_pColumns = new OColumns(*this,m_aMutex,aVector,aColumns,isCaseSensitive(),m_pConnection); } Sequence< sal_Int8 > OAdoKey::getUnoTunnelImplementationId() diff --git a/connectivity/source/drivers/ado/AUser.cxx b/connectivity/source/drivers/ado/AUser.cxx index 30e5d5164607..ded62ae2840c 100644 --- a/connectivity/source/drivers/ado/AUser.cxx +++ b/connectivity/source/drivers/ado/AUser.cxx @@ -63,7 +63,7 @@ void OAdoUser::refreshGroups() if(m_pGroups) m_pGroups->reFill(aVector); else - m_pGroups.reset( new OGroups(m_pCatalog,m_aMutex,aVector,aGroups,isCaseSensitive()) ); + m_pGroups = new OGroups(m_pCatalog,m_aMutex,aVector,aGroups,isCaseSensitive()); } Sequence< sal_Int8 > OAdoUser::getUnoTunnelImplementationId() diff --git a/connectivity/source/drivers/dbase/DIndex.cxx b/connectivity/source/drivers/dbase/DIndex.cxx index 575b195ca834..2d147b08b181 100644 --- a/connectivity/source/drivers/dbase/DIndex.cxx +++ b/connectivity/source/drivers/dbase/DIndex.cxx @@ -103,7 +103,7 @@ void ODbaseIndex::refreshColumns() if(m_pColumns) m_pColumns->reFill(aVector); else - m_pColumns.reset( new ODbaseIndexColumns(this,m_aMutex,aVector) ); + m_pColumns = new ODbaseIndexColumns(this,m_aMutex,aVector); } Sequence< sal_Int8 > ODbaseIndex::getUnoTunnelImplementationId() |