loplugin:stringviewparam whitelist some more functions

for which we have o3tl:: equivalents

Change-Id: I4670fd8b703ac47214be213f41e88d1c6ede7032
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132913
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 39 insertions, 30 deletions

diff --git a/connectivity/source/drivers/mysqlc/mysqlc_general.cxx b/connectivity/source/drivers/mysqlc/mysqlc_general.cxx
index 17b118c531a9..bc57770413f5 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_general.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_general.cxx
@@ -20,6 +20,7 @@
 
 #include <sal/log.hxx>
 #include <rtl/ustring.hxx>
+#include <o3tl/string_view.hxx>
 
 #include <com/sun/star/sdbc/DataType.hpp>
 
@@ -192,50 +193,58 @@ sal_Int32 mysqlToOOOType(int eType, int charsetnr) noexcept
     return css::sdbc::DataType::VARCHAR;
 }
 
-sal_Int32 mysqlStrToOOOType(const OUString& sType)
+sal_Int32 mysqlStrToOOOType(std::u16string_view sType)
 {
     // TODO other types.
-    if (sType.equalsIgnoreAsciiCase("tiny") || sType.equalsIgnoreAsciiCase("tinyint"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"tiny")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"tinyint"))
         return css::sdbc::DataType::TINYINT;
-    if (sType.equalsIgnoreAsciiCase("smallint") || sType.equalsIgnoreAsciiCase("year"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"smallint")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"year"))
         return css::sdbc::DataType::SMALLINT;
-    if (sType.equalsIgnoreAsciiCase("int") || sType.equalsIgnoreAsciiCase("mediumint"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"int")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"mediumint"))
         return css::sdbc::DataType::INTEGER;
-    if (sType.equalsIgnoreAsciiCase("varchar") || sType.equalsIgnoreAsciiCase("set")
-        || sType.equalsIgnoreAsciiCase("enum"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"varchar") || o3tl::equalsIgnoreAsciiCase(sType, u"set")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"enum"))
         return css::sdbc::DataType::VARCHAR;
-    if (sType.equalsIgnoreAsciiCase("bigint"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"bigint"))
         return css::sdbc::DataType::BIGINT;
-    if (sType.equalsIgnoreAsciiCase("blob") || sType.equalsIgnoreAsciiCase("longblob")
-        || sType.equalsIgnoreAsciiCase("tinyblob") || sType.equalsIgnoreAsciiCase("mediumblob"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"blob")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"longblob")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"tinyblob")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"mediumblob"))
         return css::sdbc::DataType::BLOB;
-    if (sType.equalsIgnoreAsciiCase("varbinary"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"varbinary"))
         return css::sdbc::DataType::VARBINARY;
-    if (sType.equalsIgnoreAsciiCase("char"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"char"))
         return css::sdbc::DataType::CHAR;
-    if (sType.equalsIgnoreAsciiCase("tinytext"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"tinytext"))
         return css::sdbc::DataType::VARCHAR;
-    if (sType.equalsIgnoreAsciiCase("text"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"text"))
         return css::sdbc::DataType::LONGVARCHAR;
-    if (sType.equalsIgnoreAsciiCase("mediumtext") || sType.equalsIgnoreAsciiCase("longtext"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"mediumtext")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"longtext"))
         return css::sdbc::DataType::CLOB;
-    if (sType.equalsIgnoreAsciiCase("binary"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"binary"))
         return css::sdbc::DataType::BINARY;
-    if (sType.equalsIgnoreAsciiCase("time"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"time"))
         return css::sdbc::DataType::TIME;
-    if (sType.equalsIgnoreAsciiCase("date"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"date"))
         return css::sdbc::DataType::DATE;
-    if (sType.equalsIgnoreAsciiCase("datetime") || sType.equalsIgnoreAsciiCase("timestamp"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"datetime")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"timestamp"))
         return css::sdbc::DataType::TIMESTAMP;
-    if (sType.equalsIgnoreAsciiCase("decimal"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"decimal"))
         return css::sdbc::DataType::DECIMAL;
-    if (sType.equalsIgnoreAsciiCase("real") || sType.equalsIgnoreAsciiCase("float"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"real") || o3tl::equalsIgnoreAsciiCase(sType, u"float"))
         return css::sdbc::DataType::REAL;
-    if (sType.equalsIgnoreAsciiCase("double"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"double"))
         return css::sdbc::DataType::DOUBLE;
-    if (sType.equalsIgnoreAsciiCase("bit"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"bit"))
         return css::sdbc::DataType::BIT;
-    if (sType.equalsIgnoreAsciiCase("bool") || sType.equalsIgnoreAsciiCase("boolean"))
+    if (o3tl::equalsIgnoreAsciiCase(sType, u"bool")
+        || o3tl::equalsIgnoreAsciiCase(sType, u"boolean"))
         return css::sdbc::DataType::BOOLEAN;
     OSL_FAIL("Unknown type name from string, failing back to varchar.");
     return css::sdbc::DataType::VARCHAR;
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_general.hxx b/connectivity/source/drivers/mysqlc/mysqlc_general.hxx
index 2a78c7628879..16236e1530ed 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_general.hxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_general.hxx
@@ -108,7 +108,7 @@ sal_Int32 mysqlToOOOType(int eType, int charsetnr) noexcept;
 
 OUString mysqlTypeToStr(unsigned mysql_type, unsigned mysql_flags);
 
-sal_Int32 mysqlStrToOOOType(const OUString& sType);
+sal_Int32 mysqlStrToOOOType(std::u16string_view sType);
 
 OUString convert(const ::std::string& _string, const rtl_TextEncoding encoding);
 }
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx b/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx
index 182e74b7fcb9..2feb2d2688d1 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_resultset.cxx
@@ -30,6 +30,7 @@
 #include <cppuhelper/supportsservice.hxx>
 #include <cppuhelper/typeprovider.hxx>
 #include <comphelper/seqstream.hxx>
+#include <o3tl/string_view.hxx>
 
 using namespace rtl;
 
@@ -51,14 +52,13 @@ namespace
 {
 // copied from string misc, it should be replaced when library is not an
 // extension anymore
-std::vector<OString> lcl_split(const OString& rStr, char cSeparator)
+std::vector<OString> lcl_split(std::string_view rStr, char cSeparator)
 {
     std::vector<OString> vec;
     sal_Int32 idx = 0;
     do
     {
-        OString kw = rStr.getToken(0, cSeparator, idx);
-        kw = kw.trim();
+        OString kw(o3tl::trim(o3tl::getToken(rStr, 0, cSeparator, idx)));
         if (!kw.isEmpty())
         {
             vec.push_back(kw);
@@ -507,7 +507,7 @@ DateTime SAL_CALL OResultSet::getTimestamp(sal_Int32 column)
 
     // YY-MM-DD HH:MM:SS
     std::vector<OString> dateAndTime
-        = lcl_split(OString{ sVal.getStr(), getDataLength(column) }, ' ');
+        = lcl_split(std::string_view(sVal.getStr(), getDataLength(column)), ' ');
 
     auto dateParts = lcl_split(dateAndTime.at(0), '-');
     auto timeParts = lcl_split(dateAndTime.at(1), ':');
diff --git a/connectivity/source/drivers/postgresql/pq_xcolumns.cxx b/connectivity/source/drivers/postgresql/pq_xcolumns.cxx
index 82d595628db3..95c4db003314 100644
--- a/connectivity/source/drivers/postgresql/pq_xcolumns.cxx
+++ b/connectivity/source/drivers/postgresql/pq_xcolumns.cxx
@@ -75,9 +75,9 @@ using com::sun::star::sdbc::SQLException;
 namespace pq_sdbc_driver
 {
 
-static Any isCurrency( const OUString & typeName )
+static Any isCurrency( std::u16string_view typeName )
 {
-    return Any( typeName.equalsIgnoreAsciiCase("money") );
+    return Any( o3tl::equalsIgnoreAsciiCase(typeName, u"money") );
 }
 
 // static sal_Bool isAutoIncrement8( const OUString & typeName )