loplugin:oncevar (clang-cl): connectivity

Change-Id: I76dcc99c29302b49a1d66fa22db8b28714421a98

3 files changed, 5 insertions, 8 deletions

diff --git a/connectivity/source/drivers/ado/ADatabaseMetaData.cxx b/connectivity/source/drivers/ado/ADatabaseMetaData.cxx
index f0a6165f8e8b..93376f97196c 100644
--- a/connectivity/source/drivers/ado/ADatabaseMetaData.cxx
+++ b/connectivity/source/drivers/ado/ADatabaseMetaData.cxx
@@ -910,13 +910,13 @@ OUString SAL_CALL ODatabaseMetaData::getSQLKeywords(  )
 
         aRecordset.MoveFirst();
         OLEVariant  aValue;
-        OUString aRet, aComma(",");
+        OUString aRet;
         while(!aRecordset.IsAtEOF())
         {
             WpOLEAppendCollection<ADOFields, ADOField, WpADOField>  aFields(aRecordset.GetFields());
             WpADOField aField(aFields.GetItem(0));
             aField.get_Value(aValue);
-            aRet = aRet + aValue.getString() + aComma;
+            aRet = aRet + aValue.getString() + ",";
             aRecordset.MoveNext();
         }
         aRecordset.Close();
diff --git a/connectivity/source/drivers/ado/APreparedStatement.cxx b/connectivity/source/drivers/ado/APreparedStatement.cxx
index 8f4ef082aed4..97f2f615deb0 100644
--- a/connectivity/source/drivers/ado/APreparedStatement.cxx
+++ b/connectivity/source/drivers/ado/APreparedStatement.cxx
@@ -66,8 +66,7 @@ OPreparedStatement::OPreparedStatement( OConnection* _pConnection, const OUStrin
         //  we recursive replace all occurrences of ? in the statement and
         //  replace them with name like "parame" */
         sal_Int32 nParameterCount = 0;
-        OUString sDefaultName( "parame" );
-        replaceParameterNodeName(pNode,sDefaultName,nParameterCount);
+        replaceParameterNodeName(pNode,"parame",nParameterCount);
         pNode->parseNodeToStr( sNewSql, _pConnection );
         delete pNode;
     }
diff --git a/connectivity/source/drivers/ado/Awrapado.cxx b/connectivity/source/drivers/ado/Awrapado.cxx
index 44383f4ec132..34e5ea8a9692 100644
--- a/connectivity/source/drivers/ado/Awrapado.cxx
+++ b/connectivity/source/drivers/ado/Awrapado.cxx
@@ -480,9 +480,8 @@ sal_Int32 WpADOField::GetAttributes() const
 sal_Int32 WpADOField::GetStatus() const
 {
     assert(pInterface);
-    sal_Int32 eADOSFieldAttributes=0;
     //  pInterface->get_Status(&eADOSFieldAttributes);
-    return eADOSFieldAttributes;
+    return 0;
 }
 
 sal_Int32 WpADOField::GetDefinedSize() const
@@ -1978,13 +1977,12 @@ ADORecordset* WpADOConnection::getTables( const css::uno::Any& catalog,
 
     ++nPos;
     OUStringBuffer aTypes;
-    OUString aComma( "," );
     const OUString* pIter = types.getConstArray();
     const OUString* pEnd = pIter + types.getLength();
     for( ; pIter != pEnd ; ++pIter)
     {
         if ( aTypes.getLength() )
-            aTypes.append(aComma);
+            aTypes.append(",");
         aTypes.append(*pIter);
     }