diff options
| author | Noel <noel.grandin@collabora.co.uk> | 2021-03-26 16:15:11 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-03-28 10:26:06 +0200 |
| commit | c7483d48df1b9ae70335346846d02a4fc53b4558 (patch) | |
| tree | 6cca794ebcdd0b9a81733836fa154658d083f173 /cppcanvas | |
| parent | 2ac95bccba859b7dd117e135d7c4f7a35017d9f9 (diff) | |
drop operator bool and operator! from Bitmap and BitmapEx
IRC chat:
<quikee[m]> noelgrandin: doesn't adding operator bool to Bitmap
has the same problem as Graphic and the reason why you dropped that
commit 7334034ae93b49fc93b5859a3c047a319d138282
"drop Graphic::operator bool"
<noelgrandin> quikee[m], hmmm, good point
<noelgrandin> maybe I should just drop both operator bool and
operator! in favor of IsEmpty
<quikee[m]> noelgrandin: I don't remember what the problem is I just
remembered we dropped it Graphic :) sure, dropping everything for
IsEmpty is probably the best
Change-Id: Ieae289cda64f0b8d8fdecd5ea9e6f2bb874ff4cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113163
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cppcanvas')
| -rw-r--r-- | cppcanvas/qa/unit/test.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cppcanvas/qa/unit/test.cxx b/cppcanvas/qa/unit/test.cxx index fbf6caf39147..c02d466dfedd 100644 --- a/cppcanvas/qa/unit/test.cxx +++ b/cppcanvas/qa/unit/test.cxx @@ -56,7 +56,7 @@ void CanvasTest::testComposite() xBitmapCanvas->clear(); CPPUNIT_ASSERT( aBitmapEx.Create( xBitmapCanvas, aSize ) ); CPPUNIT_ASSERT( aBitmapEx.IsAlpha() ); - CPPUNIT_ASSERT( aBitmapEx.GetAlpha() ); + CPPUNIT_ASSERT( !aBitmapEx.GetAlpha().IsEmpty() ); } { |