diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-06-14 08:43:54 +0100 |
|---|---|---|
| committer | Xisco Fauli <xiscofauli@libreoffice.org> | 2022-06-15 06:26:28 +0200 |
| commit | 519e296e4fe2f2587d3faf236dd8172101f7f7df (patch) | |
| tree | 7cd1a429951c014811586a1989eeb30a3c02a87a /cppcanvas | |
| parent | 650c3477aa4120cafcb9f0e77b341b1ac70de048 (diff) | |
cid#1504592 Big parameter passed by value
and
cid#1504665 Big parameter passed by value
cid#1505368 Big parameter passed by value
revert the clang-tidy modernize-pass-by-value changes that coverity
warns about
Change-Id: Id92fdc8d1caeed9eaf7ff1e9e745938e5a971a34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135803
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
(cherry picked from commit 8b6c8e624b1257a2221e8f98ba71112eae86c795)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135753
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'cppcanvas')
| -rw-r--r-- | cppcanvas/source/mtfrenderer/polypolyaction.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/cppcanvas/source/mtfrenderer/polypolyaction.cxx b/cppcanvas/source/mtfrenderer/polypolyaction.cxx index 14ae52d8b2cf..7f499be1ebe0 100644 --- a/cppcanvas/source/mtfrenderer/polypolyaction.cxx +++ b/cppcanvas/source/mtfrenderer/polypolyaction.cxx @@ -227,7 +227,7 @@ namespace cppcanvas::internal TexturedPolyPolyAction( const ::basegfx::B2DPolyPolygon& rPoly, const CanvasSharedPtr& rCanvas, const OutDevState& rState, - rendering::Texture aTexture ); + const rendering::Texture& rTexture ); virtual bool renderSubset( const ::basegfx::B2DHomMatrix& rTransformation, const Subset& rSubset ) const override; @@ -255,12 +255,12 @@ namespace cppcanvas::internal TexturedPolyPolyAction::TexturedPolyPolyAction( const ::basegfx::B2DPolyPolygon& rPolyPoly, const CanvasSharedPtr& rCanvas, const OutDevState& rState, - rendering::Texture aTexture ) : + const rendering::Texture& rTexture ) : CachedPrimitiveBase( rCanvas, true ), mxPolyPoly( ::basegfx::unotools::xPolyPolygonFromB2DPolyPolygon( rCanvas->getUNOCanvas()->getDevice(), rPolyPoly) ), maBounds( ::basegfx::utils::getRange(rPolyPoly) ), mpCanvas( rCanvas ), - maTexture(std::move( aTexture )) + maTexture( rTexture ) { tools::initRenderState(maState,rState); } |