diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-06 20:01:50 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-11 11:58:37 +0100 |
| commit | 93c64a61f2c84e684050294a1391cd32425b7837 (patch) | |
| tree | 00aad2cb8f3ee29ba4ac99e159e26fb8d71d2f33 /cppu | |
| parent | 1fde62018c8d3344a3408c7b6317120aefc778fb (diff) | |
loplugin:stringview
Add new methods "subView" to O(U)String to return substring views
of the underlying data.
Add a clang plugin to warn when replacing existing calls to copy()
would be better to use subView().
Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cppu')
| -rw-r--r-- | cppu/source/uno/cascade_mapping.cxx | 4 | ||||
| -rw-r--r-- | cppu/source/uno/lbenv.cxx | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/cppu/source/uno/cascade_mapping.cxx b/cppu/source/uno/cascade_mapping.cxx index f57f7dc0ac87..e19173bcff4c 100644 --- a/cppu/source/uno/cascade_mapping.cxx +++ b/cppu/source/uno/cascade_mapping.cxx @@ -250,7 +250,7 @@ void getCascadeMapping(uno_Mapping ** ppMapping, return; } - uno_envDcp += rest.copy(0, index); + uno_envDcp += rest.subView(0, index); } else if (to_envPurpose == purpose) { @@ -263,7 +263,7 @@ void getCascadeMapping(uno_Mapping ** ppMapping, return; } - uno_envDcp += rest.copy(0, index); + uno_envDcp += rest.subView(0, index); } uno_getEnvironment(&pInterm, uno_envDcp.pData, nullptr); diff --git a/cppu/source/uno/lbenv.cxx b/cppu/source/uno/lbenv.cxx index c67d47dc948a..32529b8e4564 100644 --- a/cppu/source/uno/lbenv.cxx +++ b/cppu/source/uno/lbenv.cxx @@ -1078,7 +1078,7 @@ static uno_Environment * initDefaultEnvironment( if (!envPurpose.isEmpty()) { OUString libStem( - envPurpose.copy(envPurpose.lastIndexOf(':') + 1) + "_uno_uno"); + OUString::Concat(envPurpose.subView(envPurpose.lastIndexOf(':') + 1)) + "_uno_uno"); if(!loadEnv(libStem, pEnv)) { pEnv->release(pEnv); |