diff options
author | Luboš Luňák <l.lunak@collabora.com> | 2020-02-27 12:07:42 +0100 |
---|---|---|
committer | Luboš Luňák <l.lunak@collabora.com> | 2020-02-27 16:02:11 +0100 |
commit | 853a058ca6b75b0fb14e232911eb9f9553574736 (patch) | |
tree | e8efa89aae59d92be759d421c68dfb3cad9effc6 /cppuhelper | |
parent | e8c07076689d593b9d2863d166b1933ecb6f480a (diff) |
avoid memory leak in win32 sal::backtrace_get()
Running a presentation with OpenGL transitions with Skia+Vulkan
as the VCL drawing very quickly runs out of memory in dbgutil
builds. The trigger is svl/source/notify/lstner.cxx calling
sal::backtrace_get() quite often. And that function calls
SymInitialize() repeatedly even though its docs say not to do it,
and that is also actually not necessary for CaptureStackBackTrace(),
only for the symbol resolving Sym* functions.
It actually still eventually aborts if called often enough,
but this way it is triggered only by printing the backtrace and
not just getting it.
I have no idea why the problem is triggered only in these rather
specific circumstances, e.g. Skia+raster seems to be fine.
Also avoid the needless copy&paste while I'm at it.
Change-Id: I50f9e0689b9b9b10bf54308db654aed6433085db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89626
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
Diffstat (limited to 'cppuhelper')
0 files changed, 0 insertions, 0 deletions