diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2020-06-03 09:20:49 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-06-04 10:34:24 +0200 |
| commit | 354aefec42de856b4ab6201ada54a3a3c630b4bd (patch) | |
| tree | ad01bdd049feb4c3b115b57836d3c535e8f749f2 /cui/source/customize | |
| parent | c9bc4f1eec5d66db36b6f9d845eb1a2d46e732bb (diff) | |
Upcoming loplugin:elidestringvar: cui
Change-Id: I48c4f69a1fb2e4591eab81c2b0019d7d7d43947b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95395
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'cui/source/customize')
| -rw-r--r-- | cui/source/customize/SvxConfigPageHelper.cxx | 4 | ||||
| -rw-r--r-- | cui/source/customize/SvxNotebookbarConfigPage.cxx | 3 | ||||
| -rw-r--r-- | cui/source/customize/cfg.cxx | 6 |
3 files changed, 4 insertions, 9 deletions
diff --git a/cui/source/customize/SvxConfigPageHelper.cxx b/cui/source/customize/SvxConfigPageHelper.cxx index 3ac1ca9e479f..ffe288506508 100644 --- a/cui/source/customize/SvxConfigPageHelper.cxx +++ b/cui/source/customize/SvxConfigPageHelper.cxx @@ -50,9 +50,7 @@ void SvxConfigPageHelper::RemoveEntry( SvxEntries* pEntries, SvxConfigEntry cons OUString SvxConfigPageHelper::replaceSaveInName( const OUString& rMessage, const OUString& rSaveInName ) { - const OUString placeholder("%SAVE IN SELECTION%" ); - - OUString name = rMessage.replaceFirst(placeholder, rSaveInName); + OUString name = rMessage.replaceFirst("%SAVE IN SELECTION%", rSaveInName); return name; } diff --git a/cui/source/customize/SvxNotebookbarConfigPage.cxx b/cui/source/customize/SvxNotebookbarConfigPage.cxx index 3903a3366eb6..b8c3a8d72a49 100644 --- a/cui/source/customize/SvxNotebookbarConfigPage.cxx +++ b/cui/source/customize/SvxNotebookbarConfigPage.cxx @@ -249,8 +249,7 @@ void SvxConfigPage::InsertEntryIntoNotebookbarTabUI(const OUString& sClassId, if (sClassId == "GtkSeparatorMenuItem" || sClassId == "GtkSeparator") { - OUString sDataInTree = "--------------------------------------------"; - rTreeView.set_text(rIter, sDataInTree, nStartCol + 1); + rTreeView.set_text(rIter, "--------------------------------------------", nStartCol + 1); } else { diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx index 60b1e2efcddf..412ecf3fe5f6 100644 --- a/cui/source/customize/cfg.cxx +++ b/cui/source/customize/cfg.cxx @@ -382,8 +382,7 @@ MenuSaveInData::MenuSaveInData( { try { - OUString url( ITEM_MENUBAR_URL ); - m_xMenuSettings = GetConfigManager()->getSettings( url, false ); + m_xMenuSettings = GetConfigManager()->getSettings( ITEM_MENUBAR_URL, false ); } catch ( container::NoSuchElementException& ) { @@ -2152,8 +2151,7 @@ SvxEntries* ToolbarSaveInData::GetEntries() // insert into std::unordered_map to filter duplicates from the parent aToolbarInfo.emplace( systemname, true ); - OUString custom(CUSTOM_TOOLBAR_STR); - if ( systemname.startsWith( custom ) ) + if ( systemname.startsWith( CUSTOM_TOOLBAR_STR ) ) { pEntry->SetUserDefined(); } |