loplugin:expandablemethodds in cui

Change-Id: I7b2321d45171f9b73965efea32832a3789f0dee7
Reviewed-on: https://gerrit.libreoffice.org/30011
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

4 files changed, 3 insertions, 18 deletions

diff --git a/cui/source/options/optcolor.cxx b/cui/source/options/optcolor.cxx
index e41c82a09e07..cda0df95648f 100644
--- a/cui/source/options/optcolor.cxx
+++ b/cui/source/options/optcolor.cxx
@@ -198,10 +198,8 @@ private:
         Chapter(vcl::Window *pGrid, unsigned nYPos, const OUString& sDisplayName);
         ~Chapter();
         void dispose() { m_pText.disposeAndClear(); }
-    public:
         void SetBackground(const Wallpaper& W) { m_pText->SetBackground(W); }
         void Show(const Wallpaper& rBackWall);
-        void Hide();
     };
 
     // Entry -- a color config entry:
@@ -290,7 +288,7 @@ ColorConfigWindow_Impl::Chapter::Chapter(FixedText* pText, bool bShow)
     : m_pText(pText)
 {
     if (!bShow)
-        Hide();
+        m_pText->Hide();
 }
 
 // ctor for extended groups
@@ -318,11 +316,6 @@ void ColorConfigWindow_Impl::Chapter::Show(Wallpaper const& rBackWall)
     m_pText->Show();
 }
 
-void ColorConfigWindow_Impl::Chapter::Hide ()
-{
-    m_pText->Hide();
-}
-
 
 // ColorConfigWindow_Impl::Entry
 
diff --git a/cui/source/options/optjsearch.cxx b/cui/source/options/optjsearch.cxx
index 60fd15bbdea8..ce5f61aecd2a 100644
--- a/cui/source/options/optjsearch.cxx
+++ b/cui/source/options/optjsearch.cxx
@@ -238,7 +238,7 @@ bool SvxJSearchOptionsPage::FillItemSet( SfxItemSet* )
     nTransliterationFlags = GetTransliterationFlags_Impl();
     bool bModified = nOldVal != nTransliterationFlags;
 
-    if (!IsSaveOptions())
+    if (!bSaveOptions)
         return bModified;
 
     bModified = false;
diff --git a/cui/source/options/optjsearch.hxx b/cui/source/options/optjsearch.hxx
index 2695c140e2b7..542e1c1a9b9f 100644
--- a/cui/source/options/optjsearch.hxx
+++ b/cui/source/options/optjsearch.hxx
@@ -66,7 +66,6 @@ public:
     virtual void        Reset( const SfxItemSet* rSet ) override;
     virtual bool        FillItemSet( SfxItemSet* rSet ) override;
 
-    bool                IsSaveOptions() const           { return bSaveOptions; }
     void                EnableSaveOptions( bool bVal )  { bSaveOptions = bVal; }
 
     sal_Int32               GetTransliterationFlags() const { return nTransliterationFlags; }
diff --git a/cui/source/options/optlingu.cxx b/cui/source/options/optlingu.cxx
index 6e3c09993cff..1901cc60bdb5 100644
--- a/cui/source/options/optlingu.cxx
+++ b/cui/source/options/optlingu.cxx
@@ -384,8 +384,6 @@ class OptionsUserData
 {
     sal_uLong   nVal;
 
-    void    SetModified();
-
 public:
     explicit OptionsUserData( sal_uLong nUserData ) : nVal( nUserData ) {}
     OptionsUserData( sal_uInt16 nEID,
@@ -421,15 +419,10 @@ void OptionsUserData::SetNumericValue( sal_uInt8 nNumVal )
     {
         nVal &= 0xffffff00;
         nVal |= (nNumVal);
-        SetModified();
+        nVal |= (sal_uLong)1 << 11; // mark as modified
     }
 }
 
-void OptionsUserData::SetModified()
-{
-    nVal |=  (sal_uLong)1 << 11;
-}
-
 // class BrwString_Impl -------------------------------------------------
 
 class BrwString_Impl : public SvLBoxString