diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 07:46:34 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-23 09:44:09 +0200 |
| commit | a8a461b2fba27f1a729e2b9b28426286617892a9 (patch) | |
| tree | 8e05dfae5ef9b070dc54fcbd344ad591cf6e229c /cui/source/tabpages | |
| parent | f806a2832aee62efc0e0404f7c24d53aaaf814d0 (diff) | |
clang-tidy performance-unnecessary-copy-init in canvas..cui
Change-Id: I08c137d852b5f1f817c171ee4f1cee7971417dc4
Reviewed-on: https://gerrit.libreoffice.org/62214
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cui/source/tabpages')
| -rw-r--r-- | cui/source/tabpages/autocdlg.cxx | 4 | ||||
| -rw-r--r-- | cui/source/tabpages/macroass.cxx | 2 | ||||
| -rw-r--r-- | cui/source/tabpages/numpages.cxx | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx index 20e8429ba0ec..b754fd31c378 100644 --- a/cui/source/tabpages/autocdlg.cxx +++ b/cui/source/tabpages/autocdlg.cxx @@ -731,7 +731,7 @@ IMPL_LINK_NOARG(OfaSwAutoFmtOptionsPage, EditHdl, Button*, void) aMapDlg.SetChar( (*pUserData->pString)[0] ); if (RET_OK == aMapDlg.execute()) { - vcl::Font aFont(aMapDlg.GetCharFont()); + const vcl::Font& aFont(aMapDlg.GetCharFont()); *pUserData->pFont = aFont; sal_UCS4 aChar = aMapDlg.GetChar(); // using the UCS4 constructor @@ -2525,7 +2525,7 @@ void OfaSmartTagOptionsTabPage::FillListBox( const SmartTagMgr& rSmartTagMgr ) for ( sal_uInt32 i = 0; i < nNumberOfRecognizers; ++i ) { - uno::Reference< smarttags::XSmartTagRecognizer > xRec = rSmartTagMgr.GetRecognizer(i); + const uno::Reference< smarttags::XSmartTagRecognizer >& xRec = rSmartTagMgr.GetRecognizer(i); const OUString aName = xRec->getName( aLocale ); const sal_Int32 nNumberOfSupportedSmartTags = xRec->getSmartTagCount(); diff --git a/cui/source/tabpages/macroass.cxx b/cui/source/tabpages/macroass.cxx index eb0dfa26c40a..9bd6a00f7d71 100644 --- a/cui/source/tabpages/macroass.cxx +++ b/cui/source/tabpages/macroass.cxx @@ -424,7 +424,7 @@ void SfxMacroTabPage::FillEvents() SvLBoxString& rLItem = static_cast<SvLBoxString&>( pE->GetItem( LB_MACROS_ITEMPOS ) ); DBG_ASSERT( SvLBoxItemType::String == rLItem.GetType(), "SfxMacroTabPage::FillEvents(): no LBoxString" ); - OUString sOld( rLItem.GetText() ); + const OUString& sOld( rLItem.GetText() ); OUString sNew; SvMacroItemId nEventId = static_cast<SvMacroItemId>(reinterpret_cast<sal_uLong>( pE->GetUserData() )); if( aTbl.IsKeyValid( nEventId ) ) diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx index 557065396065..59e5862a98e5 100644 --- a/cui/source/tabpages/numpages.cxx +++ b/cui/source/tabpages/numpages.cxx @@ -3275,7 +3275,7 @@ IMPL_LINK_NOARG(SvxNumPositionTabPage, StandardHdl_Impl, weld::Button&, void) if(nActNumLvl & nMask) { SvxNumberFormat aNumFmt( pActNum->GetLevel( i ) ); - SvxNumberFormat aTempFmt(aTmpNumRule.GetLevel( i )); + const SvxNumberFormat& aTempFmt(aTmpNumRule.GetLevel( i )); aNumFmt.SetPositionAndSpaceMode( aTempFmt.GetPositionAndSpaceMode() ); if ( aTempFmt.GetPositionAndSpaceMode() == SvxNumberFormat::LABEL_WIDTH_AND_POSITION ) { |