diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-08-06 13:32:43 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-08-14 18:03:06 +0200 |
| commit | e67657d5211f6e95ddf8bd621108608573b00d5d (patch) | |
| tree | 66724101dbd95721714bd40fcb4861663432774c /cui/source | |
| parent | 186def8f48e273c3a3b4d23b3ab2efd0d8664731 (diff) | |
loplugin:simplifybool more
look for expressions like
!(a && !b)
which can be expanded out
Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cui/source')
| -rw-r--r-- | cui/source/dialogs/SpellDialog.cxx | 2 | ||||
| -rw-r--r-- | cui/source/dialogs/hldocntp.cxx | 2 | ||||
| -rw-r--r-- | cui/source/tabpages/autocdlg.cxx | 2 | ||||
| -rw-r--r-- | cui/source/tabpages/tpline.cxx | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/cui/source/dialogs/SpellDialog.cxx b/cui/source/dialogs/SpellDialog.cxx index 1a0a08624761..29bf889ec6fd 100644 --- a/cui/source/dialogs/SpellDialog.cxx +++ b/cui/source/dialogs/SpellDialog.cxx @@ -917,7 +917,7 @@ void SpellDialog::ToplevelFocusChanged() * The only sensible thing would be to call the new Method differently, * e.g. DialogGot/LostFocus or so. */ - if (!(m_xDialog->get_visible() && !bFocusLocked)) + if (!m_xDialog->get_visible() || bFocusLocked) return; if (m_xDialog->has_toplevel_focus()) diff --git a/cui/source/dialogs/hldocntp.cxx b/cui/source/dialogs/hldocntp.cxx index 50d7131ad8fa..1a201f8421c3 100644 --- a/cui/source/dialogs/hldocntp.cxx +++ b/cui/source/dialogs/hldocntp.cxx @@ -385,7 +385,7 @@ void SvxHyperlinkNewDocTp::DoApply() { } - if (!(bCreate && !aStrNewName.isEmpty())) + if (!bCreate || aStrNewName.isEmpty()) return; ExecuteInfo* pExecuteInfo = new ExecuteInfo; diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx index ef413c52d54d..c82875ece77d 100644 --- a/cui/source/tabpages/autocdlg.cxx +++ b/cui/source/tabpages/autocdlg.cxx @@ -2094,7 +2094,7 @@ IMPL_LINK(OfaAutoCompleteTabPage, CheckHdl, weld::ToggleButton&, rBox, void) void OfaAutoCompleteTabPage::CopyToClipboard() const { auto rows = m_xLBEntries->get_selected_rows(); - if (!(m_pAutoCompleteList && !rows.empty())) + if (!m_pAutoCompleteList || rows.empty()) return; rtl::Reference<TransferDataContainer> pCntnr = new TransferDataContainer; diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx index 6079adcd5790..522bab7789a4 100644 --- a/cui/source/tabpages/tpline.cxx +++ b/cui/source/tabpages/tpline.cxx @@ -1428,7 +1428,7 @@ IMPL_LINK_NOARG(SvxLineTabPage, MenuCreateHdl_Impl, weld::ToggleButton&, void) m_xSymbolMB->set_item_sensitive("gallery", false); } - if (!(!m_xSymbolsMenu && m_pSymbolList)) + if (m_xSymbolsMenu || !m_pSymbolList) return; m_xSymbolsMenu = m_xBuilder->weld_menu("symbolssubmenu"); |