improve loplugin passparamsbyref

I think I managed to disable this when I converted it to
use the shared plugin infrastructure.

So fix that, and then make it much smarter to avoid various
false positives.

Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 10 insertions, 7 deletions

diff --git a/cui/source/customize/CustomNotebookbarGenerator.cxx b/cui/source/customize/CustomNotebookbarGenerator.cxx
index 7b26d36a68b8..ac2c18d5c238 100644
--- a/cui/source/customize/CustomNotebookbarGenerator.cxx
+++ b/cui/source/customize/CustomNotebookbarGenerator.cxx
@@ -252,7 +252,8 @@ void CustomNotebookbarGenerator::createCustomizedUIFile()
                  "Cannot copy the file or file was present :" << sCustomizedUIPath);
 }
 
-Sequence<OUString> CustomNotebookbarGenerator::getCustomizedUIItem(OUString sNotebookbarConfigType)
+Sequence<OUString>
+CustomNotebookbarGenerator::getCustomizedUIItem(const OUString& sNotebookbarConfigType)
 {
     OUString aPath = getAppNameRegistryPath();
     const utl::OConfigurationTreeRoot aAppNode(::comphelper::getProcessComponentContext(), aPath,
diff --git a/cui/source/dialogs/GraphicTestsDialog.cxx b/cui/source/dialogs/GraphicTestsDialog.cxx
index 49525d71bb62..25dfe17cc15d 100644
--- a/cui/source/dialogs/GraphicTestsDialog.cxx
+++ b/cui/source/dialogs/GraphicTestsDialog.cxx
@@ -24,7 +24,8 @@
 #include <ImageViewerDialog.hxx>
 
 GraphicTestEntry::GraphicTestEntry(weld::Container* pParent, weld::Dialog* pDialog,
-                                   OUString aTestName, OUString aTestStatus, Bitmap aTestBitmap)
+                                   const OUString& aTestName, const OUString& aTestStatus,
+                                   Bitmap aTestBitmap)
     : m_xBuilder(Application::CreateBuilder(pParent, u"cui/ui/graphictestentry.ui"_ustr))
     , m_xContainer(m_xBuilder->weld_container(u"gptestbox"_ustr))
     , m_xTestLabel(m_xBuilder->weld_label(u"gptestlabel"_ustr))
diff --git a/cui/source/dialogs/ImageViewerDialog.cxx b/cui/source/dialogs/ImageViewerDialog.cxx
index d15960193d0f..1c0f537715d7 100644
--- a/cui/source/dialogs/ImageViewerDialog.cxx
+++ b/cui/source/dialogs/ImageViewerDialog.cxx
@@ -10,7 +10,8 @@
 #include <vcl/virdev.hxx>
 #include <ImageViewerDialog.hxx>
 
-ImageViewerDialog::ImageViewerDialog(weld::Dialog* pParent, BitmapEx aBitmap, OUString atitle)
+ImageViewerDialog::ImageViewerDialog(weld::Dialog* pParent, BitmapEx aBitmap,
+                                     const OUString& atitle)
     : GenericDialogController(pParent, u"cui/ui/imageviewer.ui"_ustr, u"ImageViewerDialog"_ustr)
     , m_xDisplayImage(m_xBuilder->weld_image(u"ImgVW_mainImage"_ustr))
 {
diff --git a/cui/source/inc/CustomNotebookbarGenerator.hxx b/cui/source/inc/CustomNotebookbarGenerator.hxx
index a7149879aef0..53c1c4b3e85e 100644
--- a/cui/source/inc/CustomNotebookbarGenerator.hxx
+++ b/cui/source/inc/CustomNotebookbarGenerator.hxx
@@ -31,7 +31,7 @@ public:
     static OUString getCustomizedUIPath();
     static OUString getOriginalUIPath();
     static OString getSystemPath(OUString const& sURL);
-    static Sequence<OUString> getCustomizedUIItem(OUString sNotebookbarConfigType);
+    static Sequence<OUString> getCustomizedUIItem(const OUString& sNotebookbarConfigType);
     static void getFileNameAndAppName(OUString& sAppName, OUString& sNotebookbarUIFileName);
     static void modifyCustomizedUIFile(const Sequence<OUString>& sUIItemProperties);
     static void createCustomizedUIFile();
diff --git a/cui/source/inc/GraphicsTestsDialog.hxx b/cui/source/inc/GraphicsTestsDialog.hxx
index 2bf18de5dde7..841715575ca1 100644
--- a/cui/source/inc/GraphicsTestsDialog.hxx
+++ b/cui/source/inc/GraphicsTestsDialog.hxx
@@ -28,8 +28,8 @@ private:
 
 public:
     DECL_LINK(HandleResultViewRequest, weld::Button&, void);
-    GraphicTestEntry(weld::Container* pParent, weld::Dialog* pDialog, OUString aTestName,
-                     OUString aTestStatus, Bitmap aTestBitmap);
+    GraphicTestEntry(weld::Container* pParent, weld::Dialog* pDialog, const OUString& aTestName,
+                     const OUString& aTestStatus, Bitmap aTestBitmap);
     weld::Widget* get_widget() const { return m_xContainer.get(); }
 };
 
diff --git a/cui/source/inc/ImageViewerDialog.hxx b/cui/source/inc/ImageViewerDialog.hxx
index 884deb18d4a7..c6c763552310 100644
--- a/cui/source/inc/ImageViewerDialog.hxx
+++ b/cui/source/inc/ImageViewerDialog.hxx
@@ -16,5 +16,5 @@ class ImageViewerDialog : public weld::GenericDialogController
     std::unique_ptr<weld::Image> m_xDisplayImage;
 
 public:
-    ImageViewerDialog(weld::Dialog* pParent, BitmapEx aBitmap, OUString atitle);
+    ImageViewerDialog(weld::Dialog* pParent, BitmapEx aBitmap, const OUString& atitle);
 };