diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-09-28 10:59:43 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-09-28 19:35:13 +0200 |
commit | d72511eda923c827a6175bec9b8f24c237f82730 (patch) | |
tree | 2f0173ce3a9ff08b9cfccad0313db9a142f1a6ba /cui/source | |
parent | 0bcc4b55d723f73b2fb7a86fcfebeca49905079e (diff) |
gives names to all the Idles and Tasks
enforce it by making the constructor parameter non-default.
Change-Id: I321543e4dcf15ea0a43ad8cce91d2f8dc22df6ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122766
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cui/source')
-rw-r--r-- | cui/source/customize/acccfg.cxx | 5 | ||||
-rw-r--r-- | cui/source/customize/cfg.cxx | 3 | ||||
-rw-r--r-- | cui/source/dialogs/AdditionsDialog.cxx | 3 | ||||
-rw-r--r-- | cui/source/dialogs/cuigaldlg.cxx | 1 | ||||
-rw-r--r-- | cui/source/dialogs/cuigrfflt.cxx | 1 | ||||
-rw-r--r-- | cui/source/dialogs/hltpbase.cxx | 1 | ||||
-rw-r--r-- | cui/source/tabpages/chardlg.cxx | 2 | ||||
-rw-r--r-- | cui/source/tabpages/macroass.cxx | 3 | ||||
-rw-r--r-- | cui/source/tabpages/numpages.cxx | 1 |
9 files changed, 10 insertions, 10 deletions
diff --git a/cui/source/customize/acccfg.cxx b/cui/source/customize/acccfg.cxx index 98f965a6ce9e..dbe8eff7c832 100644 --- a/cui/source/customize/acccfg.cxx +++ b/cui/source/customize/acccfg.cxx @@ -834,7 +834,8 @@ SfxAcceleratorConfigPage::SfxAcceleratorConfigPage(weld::Container* pPage, , aFilterAllStr(SfxResId(STR_SFX_FILTERNAME_ALL)) , aFilterCfgStr(CuiResId(RID_SVXSTR_FILTERNAME_CFG)) , m_bStylesInfoInitialized(false) - , m_aUpdateDataTimer("UpdateDataTimer") + , m_aUpdateDataTimer("SfxAcceleratorConfigPage UpdateDataTimer") + , m_aFillGroupIdle("SfxAcceleratorConfigPage m_aFillGroupIdle") , m_xEntriesBox(m_xBuilder->weld_tree_view("shortcuts")) , m_xOfficeButton(m_xBuilder->weld_radio_button("office")) , m_xModuleButton(m_xBuilder->weld_radio_button("module")) @@ -904,12 +905,10 @@ SfxAcceleratorConfigPage::SfxAcceleratorConfigPage(weld::Container* pPage, m_xKeyBox->make_sorted(); m_aUpdateDataTimer.SetInvokeHandler(LINK(this, SfxAcceleratorConfigPage, ImplUpdateDataHdl)); - m_aUpdateDataTimer.SetDebugName("SfxAcceleratorConfigPage UpdateDataTimer"); m_aUpdateDataTimer.SetTimeout(EDIT_UPDATEDATA_TIMEOUT); m_aFillGroupIdle.SetInvokeHandler(LINK(this, SfxAcceleratorConfigPage, TimeOut_Impl)); m_aFillGroupIdle.SetPriority(TaskPriority::HIGHEST); - m_aFillGroupIdle.SetDebugName("SfxAcceleratorConfigPage m_aFillGroupIdle"); } SfxAcceleratorConfigPage::~SfxAcceleratorConfigPage() diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx index 57f6a467bc43..eb7f4ce17c62 100644 --- a/cui/source/customize/cfg.cxx +++ b/cui/source/customize/cfg.cxx @@ -970,7 +970,7 @@ IMPL_LINK(SvxMenuEntriesListBox, KeyInputHdl, const KeyEvent&, rKeyEvent, bool) *****************************************************************************/ SvxConfigPage::SvxConfigPage(weld::Container* pPage, weld::DialogController* pController, const SfxItemSet& rSet) : SfxTabPage(pPage, pController, "cui/ui/menuassignpage.ui", "MenuAssignPage", &rSet) - , m_aUpdateDataTimer("UpdateDataTimer") + , m_aUpdateDataTimer( "SvxConfigPage UpdateDataTimer" ) , bInitialised(false) , pCurrentSaveInData(nullptr) , m_xCommandCategoryListBox(new CommandCategoryListBox(m_xBuilder->weld_combo_box("commandcategorylist"))) @@ -1002,7 +1002,6 @@ SvxConfigPage::SvxConfigPage(weld::Container* pPage, weld::DialogController* pCo m_xDescriptionField->set_size_request(aSize.Width(), m_xDescriptionField->get_height_rows(3)); m_aUpdateDataTimer.SetInvokeHandler(LINK(this, SvxConfigPage, ImplUpdateDataHdl)); - m_aUpdateDataTimer.SetDebugName( "SvxConfigPage UpdateDataTimer" ); m_aUpdateDataTimer.SetTimeout(EDIT_UPDATEDATA_TIMEOUT); m_xSearchEdit->connect_changed(LINK(this, SvxConfigPage, SearchUpdateHdl)); diff --git a/cui/source/dialogs/AdditionsDialog.cxx b/cui/source/dialogs/AdditionsDialog.cxx index 5ca2d10051ec..d1a2ee2388cd 100644 --- a/cui/source/dialogs/AdditionsDialog.cxx +++ b/cui/source/dialogs/AdditionsDialog.cxx @@ -451,7 +451,7 @@ void SearchAndParseThread::execute() AdditionsDialog::AdditionsDialog(weld::Window* pParent, const OUString& sAdditionsTag) : GenericDialogController(pParent, "cui/ui/additionsdialog.ui", "AdditionsDialog") - , m_aSearchDataTimer("SearchDataTimer") + , m_aSearchDataTimer("AdditionsDialog SearchDataTimer") , m_xEntrySearch(m_xBuilder->weld_entry("entrySearch")) , m_xButtonClose(m_xBuilder->weld_button("buttonClose")) , m_xMenuButtonSettings(m_xBuilder->weld_menu_button("buttonGear")) @@ -464,7 +464,6 @@ AdditionsDialog::AdditionsDialog(weld::Window* pParent, const OUString& sAdditio m_xGearBtn->set_item_active("gear_sort_voting", true); m_aSearchDataTimer.SetInvokeHandler(LINK(this, AdditionsDialog, ImplUpdateDataHdl)); - m_aSearchDataTimer.SetDebugName("AdditionsDialog SearchDataTimer"); m_aSearchDataTimer.SetTimeout(EDIT_UPDATEDATA_TIMEOUT); m_xEntrySearch->connect_changed(LINK(this, AdditionsDialog, SearchUpdateHdl)); diff --git a/cui/source/dialogs/cuigaldlg.cxx b/cui/source/dialogs/cuigaldlg.cxx index 6e8e590d107c..1d1c1429399a 100644 --- a/cui/source/dialogs/cuigaldlg.cxx +++ b/cui/source/dialogs/cuigaldlg.cxx @@ -583,6 +583,7 @@ std::unique_ptr<SfxTabPage> TPGalleryThemeGeneral::Create(weld::Container* pPage TPGalleryThemeProperties::TPGalleryThemeProperties(weld::Container* pPage, weld::DialogController* pController, const SfxItemSet& rSet) : SfxTabPage(pPage, pController, "cui/ui/galleryfilespage.ui", "GalleryFilesPage", &rSet) , pData(nullptr) + , aPreviewTimer("cui TPGalleryThemeProperties aPreviewTimer") , bEntriesFound(false) , bInputAllowed(true) , bTakeAll(false) diff --git a/cui/source/dialogs/cuigrfflt.cxx b/cui/source/dialogs/cuigrfflt.cxx index 4f86d6e1a186..c67ee92d141c 100644 --- a/cui/source/dialogs/cuigrfflt.cxx +++ b/cui/source/dialogs/cuigrfflt.cxx @@ -127,6 +127,7 @@ GraphicFilterDialog::GraphicFilterDialog(weld::Window* pParent, const OUString& rUIXMLDescription, const OString& rID, const Graphic& rGraphic) : GenericDialogController(pParent, rUIXMLDescription, rID) + , maTimer("cui GraphicFilterDialog maTimer") , maModifyHdl(LINK(this, GraphicFilterDialog, ImplModifyHdl)) , mxPreview(new weld::CustomWeld(*m_xBuilder, "preview", maPreview)) { diff --git a/cui/source/dialogs/hltpbase.cxx b/cui/source/dialogs/hltpbase.cxx index 3f20145aafac..987cf97514a9 100644 --- a/cui/source/dialogs/hltpbase.cxx +++ b/cui/source/dialogs/hltpbase.cxx @@ -118,6 +118,7 @@ SvxHyperlinkTabPageBase::SvxHyperlinkTabPageBase(weld::Container* pParent, , mbIsCloseDisabled( false ) , mpDialog( pDlg ) , mbStdControlsInit( false ) + , maTimer("cui SvxHyperlinkTabPageBase maTimer") { // create bookmark-window } diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index e75db5fe5183..fef7b46fb537 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -170,7 +170,7 @@ void SvxCharBasePage::SetPrevFontEscapement( sal_uInt8 nProp, sal_uInt8 nEscProp struct SvxCharNamePage_Impl { - Idle m_aUpdateIdle; + Idle m_aUpdateIdle { "cui SvxCharNamePage_Impl m_aUpdateIdle" }; OUString m_aNoStyleText; std::unique_ptr<FontList> m_pFontList; int m_nExtraEntryPos; diff --git a/cui/source/tabpages/macroass.cxx b/cui/source/tabpages/macroass.cxx index df3e47bf489b..9d4c176810d2 100644 --- a/cui/source/tabpages/macroass.cxx +++ b/cui/source/tabpages/macroass.cxx @@ -47,7 +47,7 @@ public: std::unique_ptr<weld::Frame> m_xMacroFrame; std::unique_ptr<CuiConfigFunctionListBox> m_xMacroLB; - Idle m_aFillGroupIdle; + Idle m_aFillGroupIdle { "cui SfxMacroTabPage m_aFillGroupIdle" }; bool m_bGotEvents; }; @@ -105,7 +105,6 @@ SfxMacroTabPage::SfxMacroTabPage(weld::Container* pPage, weld::DialogController* mpImpl->m_aFillGroupIdle.SetInvokeHandler( LINK( this, SfxMacroTabPage, TimeOut_Impl ) ); mpImpl->m_aFillGroupIdle.SetPriority( TaskPriority::HIGHEST ); - mpImpl->m_aFillGroupIdle.SetDebugName( "SfxMacroTabPage m_aFillGroupIdle" ); mpImpl->m_xEventLB.reset(new MacroEventListBox(m_xBuilder->weld_tree_view("assignments"))); mpImpl->m_xAssignPB = m_xBuilder->weld_button("assign"); diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx index 59093e572c89..2761d418fa5c 100644 --- a/cui/source/tabpages/numpages.cxx +++ b/cui/source/tabpages/numpages.cxx @@ -1011,6 +1011,7 @@ IMPL_LINK_NOARG(SvxBitmapPickTabPage, ClickAddBrowseHdl_Impl, weld::Button&, voi SvxNumOptionsTabPage::SvxNumOptionsTabPage(weld::Container* pPage, weld::DialogController* pController, const SfxItemSet& rSet) : SfxTabPage(pPage, pController, "cui/ui/numberingoptionspage.ui", "NumberingOptionsPage", &rSet) + , aInvalidateTimer("cui SvxNumOptionsTabPage aInvalidateTimer") , m_pLevelHdlEvent(nullptr) , bLastWidthModified(false) , bModified(false) |