diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-04-01 13:05:01 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-04-01 14:05:37 +0200 |
| commit | b57d04083a807c96e03d75655c206d4f2c415104 (patch) | |
| tree | acb5b971f255e6b2d4e1fb213e97aa55dc5ef361 /cui | |
| parent | 0e3023564f58c70af47155675a43c1540d20ad65 (diff) | |
fix ubsan after 7d6c67d323a87f1006d84c2a95b45dfbfb03c0c8
ubsan exposed some bugs in
commit 7d6c67d323a87f1006d84c2a95b45dfbfb03c0c8
Date: Mon Mar 30 15:11:55 2020 +0200
convert enum to scoped in SvBaseLink
where I had converted the bit operations incorrectly
Change-Id: I85bc0f0d69c34d9d714f983f82d4d26dd967f892
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91484
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cui')
| -rw-r--r-- | cui/source/dialogs/linkdlg.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/cui/source/dialogs/linkdlg.cxx b/cui/source/dialogs/linkdlg.cxx index 6a830e5580c1..bd6225ac89a1 100644 --- a/cui/source/dialogs/linkdlg.cxx +++ b/cui/source/dialogs/linkdlg.cxx @@ -184,7 +184,7 @@ void SvBaseLinksDlg::LinksSelectHdl(weld::TreeView* pSvTabListBox) OUString sType, sLink; OUString *pLinkNm = &sLink, *pFilter = nullptr; - if( isClientType(pLink->GetObjType()) ) + if( isClientFileType(pLink->GetObjType()) ) { m_xRbAutomatic->set_sensitive(false); m_xRbManual->set_active(true); @@ -226,7 +226,7 @@ IMPL_LINK_NOARG( SvBaseLinksDlg, AutomaticClickHdl, weld::Button&, void ) { int nPos; SvBaseLink* pLink = GetSelEntry( &nPos ); - if( pLink && !isClientType( pLink->GetObjType() ) && + if( pLink && !isClientFileType( pLink->GetObjType() ) && SfxLinkUpdateMode::ALWAYS != pLink->GetUpdateMode() ) SetType( *pLink, nPos, SfxLinkUpdateMode::ALWAYS ); } @@ -235,7 +235,7 @@ IMPL_LINK_NOARG( SvBaseLinksDlg, ManualClickHdl, weld::Button&, void ) { int nPos; SvBaseLink* pLink = GetSelEntry( &nPos ); - if( pLink && !isClientType( pLink->GetObjType() ) && + if( pLink && !isClientFileType( pLink->GetObjType() ) && SfxLinkUpdateMode::ONCALL != pLink->GetUpdateMode()) SetType( *pLink, nPos, SfxLinkUpdateMode::ONCALL ); } |