clang-tidy performance-unnecessary-copy-initialization

probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>

8 files changed, 10 insertions, 13 deletions

diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 8f5c1c4c5395..f995d46017ce 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -1520,7 +1520,7 @@ bool ContextMenuSaveInData::Apply()
             css::uno::Reference< css::lang::XSingleComponentFactory > xFactory( xIndexContainer, css::uno::UNO_QUERY );
             ApplyMenu( xIndexContainer, xFactory, pEntry );
 
-            OUString aUrl = pEntry->GetCommand();
+            const OUString& aUrl = pEntry->GetCommand();
             try
             {
                 if ( GetConfigManager()->hasSettings( aUrl ) )
diff --git a/cui/source/customize/macropg.cxx b/cui/source/customize/macropg.cxx
index efffa6716992..cbeb45adba8c 100644
--- a/cui/source/customize/macropg.cxx
+++ b/cui/source/customize/macropg.cxx
@@ -466,10 +466,9 @@ IconLBoxString::IconLBoxString( const OUString& sText,
 void IconLBoxString::Paint(const Point& aPos, SvTreeListBox& /*aDevice*/, vcl::RenderContext& rRenderContext,
                            const SvViewDataEntry* /*pView*/, const SvTreeListEntry& /*rEntry*/)
 {
-    OUString aTxt(GetText());
-    if (!aTxt.isEmpty())
+    OUString aURL(GetText());
+    if (!aURL.isEmpty())
     {
-        OUString aURL(aTxt);
         sal_Int32 nIndex = aURL.indexOf(aVndSunStarUNO);
         bool bUNO = nIndex == 0;
 
diff --git a/cui/source/dialogs/about.cxx b/cui/source/dialogs/about.cxx
index f26a1761ca2a..de838b0d2bf5 100644
--- a/cui/source/dialogs/about.cxx
+++ b/cui/source/dialogs/about.cxx
@@ -160,7 +160,7 @@ void AboutDialog::StyleControls()
 
     const StyleSettings& rStyleSettings = Application::GetSettings().GetStyleSettings();
 
-    vcl::Font aLabelFont = rStyleSettings.GetLabelFont();
+    const vcl::Font& aLabelFont = rStyleSettings.GetLabelFont();
     vcl::Font aLargeFont = aLabelFont;
     aLargeFont.SetFontSize(Size( 0, aLabelFont.GetFontSize().Height() * 3));
 
diff --git a/cui/source/dialogs/cuigaldlg.cxx b/cui/source/dialogs/cuigaldlg.cxx
index 92d542389383..6175603eccdc 100644
--- a/cui/source/dialogs/cuigaldlg.cxx
+++ b/cui/source/dialogs/cuigaldlg.cxx
@@ -831,9 +831,8 @@ OUString TPGalleryThemeProperties::addExtension( const OUString& _rDisplayText,
 
     if ( sRet.indexOf( sAllFilter ) == -1 )
     {
-        OUString sExt = _rExtension;
         sRet += sOpenBracket;
-        sRet += sExt;
+        sRet += _rExtension;
         sRet += sCloseBracket;
     }
     return sRet;
diff --git a/cui/source/options/optopencl.cxx b/cui/source/options/optopencl.cxx
index db1470e290c7..250cae9b6ad5 100644
--- a/cui/source/options/optopencl.cxx
+++ b/cui/source/options/optopencl.cxx
@@ -373,7 +373,7 @@ long SvxOpenCLTabPage::DeleteHdl(SvSimpleTable* pListBox, OpenCLConfig::ImplMatc
     if (!pListBox->FirstSelected())
         return 0;
 
-    OpenCLConfig::ImplMatcher rEntry(findCurrentEntry(rSet, pListBox));
+    const OpenCLConfig::ImplMatcher& rEntry(findCurrentEntry(rSet, pListBox));
     rSet.erase(rEntry);
     fillListBox(pListBox, rSet);
 
diff --git a/cui/source/options/treeopt.cxx b/cui/source/options/treeopt.cxx
index 8357b71482c4..536f0b45894c 100644
--- a/cui/source/options/treeopt.cxx
+++ b/cui/source/options/treeopt.cxx
@@ -2068,7 +2068,6 @@ VectorOfNodes OfaTreeOptionsDialog::LoadNodes(
 
 static sal_uInt16 lcl_getGroupId( const OUString& rGroupName, const SvTreeListBox& rTreeLB )
 {
-    OUString sGroupName( rGroupName );
     sal_uInt16 nRet = 0;
     SvTreeListEntry* pEntry = rTreeLB.First();
     while( pEntry )
@@ -2076,7 +2075,7 @@ static sal_uInt16 lcl_getGroupId( const OUString& rGroupName, const SvTreeListBo
         if ( !rTreeLB.GetParent( pEntry ) )
         {
             OUString sTemp( rTreeLB.GetEntryText( pEntry ) );
-            if ( sTemp == sGroupName )
+            if ( sTemp == rGroupName )
                 return nRet;
             nRet++;
         }
diff --git a/cui/source/tabpages/backgrnd.cxx b/cui/source/tabpages/backgrnd.cxx
index 2256096cd2bc..aa9c595d3eb2 100644
--- a/cui/source/tabpages/backgrnd.cxx
+++ b/cui/source/tabpages/backgrnd.cxx
@@ -1443,8 +1443,8 @@ void SvxBackgroundTabPage::FillControls_Impl( const SvxBrushItem& rBgdAttr,
     }
     else
     {
-        const OUString  aStrLink   = rBgdAttr.GetGraphicLink();
-        const OUString  aStrFilter = rBgdAttr.GetGraphicFilter();
+        const OUString&  aStrLink   = rBgdAttr.GetGraphicLink();
+        const OUString&  aStrFilter = rBgdAttr.GetGraphicFilter();
 
         lcl_setFillStyle(m_pLbSelect, drawing::FillStyle_BITMAP);
         ShowBitmapUI_Impl();
diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx
index 49bbfeb5c99c..a85ec88437d0 100644
--- a/cui/source/tabpages/paragrph.cxx
+++ b/cui/source/tabpages/paragrph.cxx
@@ -1615,7 +1615,7 @@ void SvxExtParagraphTabPage::Reset( const SfxItemSet* rSet )
 
             const SvxPageModelItem& rModel =
                 static_cast<const SvxPageModelItem&>(rSet->Get( _nWhich ));
-            OUString aStr( rModel.GetValue() );
+            const OUString& aStr( rModel.GetValue() );
 
             if ( !aStr.isEmpty() &&
                  m_pApplyCollBox->GetEntryPos( aStr ) != LISTBOX_ENTRY_NOTFOUND )