Related tdf#119931 - Fix accessibility warnings

Change-Id: I69787778f11217a55daa1489c142561db5efce19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121139
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

4 files changed, 126 insertions, 148 deletions

diff --git a/cui/uiconfig/ui/bulletandposition.ui b/cui/uiconfig/ui/bulletandposition.ui
index c3c2b5c7f5db..573babf76084 100644
--- a/cui/uiconfig/ui/bulletandposition.ui
+++ b/cui/uiconfig/ui/bulletandposition.ui
@@ -917,6 +917,7 @@
                             <property name="visible">True</property>
                             <property name="can-focus">False</property>
                             <property name="label" translatable="yes" context="bulletandposition|ALlabel">Alignment:</property>
+                            <property name="mnemonic-widget">left</property>
                             <property name="xalign">0</property>
                           </object>
                           <packing>
diff --git a/cui/uiconfig/ui/menuassignpage.ui b/cui/uiconfig/ui/menuassignpage.ui
index 70aab7c577c2..ab63ddb15578 100644
--- a/cui/uiconfig/ui/menuassignpage.ui
+++ b/cui/uiconfig/ui/menuassignpage.ui
@@ -283,9 +283,6 @@
                 <property name="wrap_mode">word</property>
                 <property name="cursor_visible">False</property>
                 <property name="accepts_tab">False</property>
-                <accessibility>
-                  <relation type="labelled-by" target="descriptionlabel"/>
-                </accessibility>
                 <child internal-child="accessible">
                   <object class="AtkObject" id="desc-atkobject">
                     <property name="AtkObject::accessible-description" translatable="yes" context="menuassignpage|extended_tip|desc">The text box contains a short description of the selected command.</property>
@@ -308,9 +305,6 @@
             <property name="label" translatable="yes" context="menuassignpage|label33">D_escription</property>
             <property name="use_underline">True</property>
             <property name="mnemonic_widget">desc</property>
-            <accessibility>
-              <relation type="label-for" target="desc"/>
-            </accessibility>
           </object>
           <packing>
             <property name="left_attach">0</property>
diff --git a/cui/uiconfig/ui/pageformatpage.ui b/cui/uiconfig/ui/pageformatpage.ui
index 68bd5a10ab0e..8adcba3e944b 100644
--- a/cui/uiconfig/ui/pageformatpage.ui
+++ b/cui/uiconfig/ui/pageformatpage.ui
@@ -455,11 +455,8 @@
                     <property name="can_focus">False</property>
                     <property name="label" translatable="yes" context="pageformatpage|labelGutterMargin">Gutter:</property>
                     <property name="use_underline">True</property>
-                    <property name="mnemonic_widget">spinMargBot</property>
+                    <property name="mnemonic_widget">spinMargGut</property>
                     <property name="xalign">0</property>
-                    <accessibility>
-                      <relation type="label-for" target="spinMargGut"/>
-                    </accessibility>
                   </object>
                   <packing>
                     <property name="left_attach">0</property>
@@ -472,9 +469,6 @@
                     <property name="can_focus">True</property>
                     <property name="activates_default">True</property>
                     <property name="truncate_multiline">True</property>
-                    <accessibility>
-                      <relation type="labelled-by" target="labelGutterMargin"/>
-                    </accessibility>
                   </object>
                   <packing>
                     <property name="left_attach">1</property>
diff --git a/cui/uiconfig/ui/password.ui b/cui/uiconfig/ui/password.ui
index a1ba1599c05a..447968f7fce0 100644
--- a/cui/uiconfig/ui/password.ui
+++ b/cui/uiconfig/ui/password.ui
@@ -1,33 +1,33 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated with glade 3.36.0 -->
+<!-- Generated with glade 3.38.2 -->
 <interface domain="cui">
   <requires lib="gtk+" version="3.20"/>
   <object class="GtkDialog" id="PasswordDialog">
-    <property name="can_focus">False</property>
-    <property name="border_width">6</property>
+    <property name="can-focus">False</property>
+    <property name="border-width">6</property>
     <property name="title" translatable="yes" context="password|PasswordDialog">Set Password</property>
     <property name="modal">True</property>
-    <property name="window_position">center</property>
-    <property name="default_width">0</property>
-    <property name="default_height">0</property>
-    <property name="type_hint">normal</property>
+    <property name="window-position">center</property>
+    <property name="default-width">0</property>
+    <property name="default-height">0</property>
+    <property name="type-hint">normal</property>
     <child internal-child="vbox">
       <object class="GtkBox" id="dialog-vbox1">
-        <property name="can_focus">False</property>
+        <property name="can-focus">False</property>
         <property name="orientation">vertical</property>
         <property name="spacing">12</property>
         <child internal-child="action_area">
           <object class="GtkButtonBox" id="dialog-action_area1">
-            <property name="can_focus">False</property>
-            <property name="layout_style">end</property>
+            <property name="can-focus">False</property>
+            <property name="layout-style">end</property>
             <child>
               <object class="GtkButton" id="ok">
                 <property name="label" translatable="yes" context="stock">_OK</property>
                 <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="can_default">True</property>
-                <property name="has_default">True</property>
-                <property name="receives_default">True</property>
+                <property name="can-focus">True</property>
+                <property name="can-default">True</property>
+                <property name="has-default">True</property>
+                <property name="receives-default">True</property>
                 <property name="use-underline">True</property>
               </object>
               <packing>
@@ -40,8 +40,8 @@
               <object class="GtkButton" id="cancel">
                 <property name="label" translatable="yes" context="stock">_Cancel</property>
                 <property name="visible">True</property>
-                <property name="can_focus">True</property>
-                <property name="receives_default">True</property>
+                <property name="can-focus">True</property>
+                <property name="receives-default">True</property>
                 <property name="use-underline">True</property>
               </object>
               <packing>
@@ -54,44 +54,44 @@
           <packing>
             <property name="expand">False</property>
             <property name="fill">True</property>
-            <property name="pack_type">end</property>
+            <property name="pack-type">end</property>
             <property name="position">0</property>
           </packing>
         </child>
         <child>
           <object class="GtkBox" id="box1">
             <property name="visible">True</property>
-            <property name="can_focus">False</property>
+            <property name="can-focus">False</property>
             <property name="hexpand">True</property>
             <property name="orientation">vertical</property>
             <property name="spacing">12</property>
             <child>
               <object class="GtkFrame" id="frame2">
                 <property name="visible">True</property>
-                <property name="can_focus">False</property>
+                <property name="can-focus">False</property>
                 <property name="hexpand">True</property>
-                <property name="label_xalign">0</property>
-                <property name="shadow_type">none</property>
+                <property name="label-xalign">0</property>
+                <property name="shadow-type">none</property>
                 <child>
-                  <!-- n-columns=1 n-rows=1 -->
+                  <!-- n-columns=1 n-rows=6 -->
                   <object class="GtkGrid" id="grid1">
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
-                    <property name="hexpand">True</property>
-                    <property name="row_spacing">6</property>
-                    <property name="column_spacing">12</property>
+                    <property name="can-focus">False</property>
                     <property name="margin-start">12</property>
                     <property name="margin-top">6</property>
+                    <property name="hexpand">True</property>
+                    <property name="row-spacing">6</property>
+                    <property name="column-spacing">12</property>
                     <child>
                       <object class="GtkEntry" id="newpassEntry">
                         <property name="visible">True</property>
-                        <property name="can_focus">True</property>
+                        <property name="can-focus">True</property>
                         <property name="hexpand">True</property>
                         <property name="visibility">False</property>
-                        <property name="activates_default">True</property>
-                        <property name="width_chars">50</property>
-                        <property name="input_purpose">password</property>
+                        <property name="activates-default">True</property>
+                        <property name="width-chars">50</property>
                         <property name="truncate-multiline">True</property>
+                        <property name="input-purpose">password</property>
                         <child internal-child="accessible">
                           <object class="AtkObject" id="newpassEntry-atkobject">
                             <property name="AtkObject::accessible-description" translatable="yes" context="password|extended_tip|newpassEntry">Type a password. A password is case sensitive.</property>
@@ -99,19 +99,19 @@
                         </child>
                       </object>
                       <packing>
-                        <property name="left_attach">0</property>
-                        <property name="top_attach">1</property>
+                        <property name="left-attach">0</property>
+                        <property name="top-attach">1</property>
                       </packing>
                     </child>
                     <child>
                       <object class="GtkEntry" id="confirmpassEntry">
                         <property name="visible">True</property>
-                        <property name="can_focus">True</property>
+                        <property name="can-focus">True</property>
                         <property name="hexpand">True</property>
                         <property name="visibility">False</property>
-                        <property name="activates_default">True</property>
-                        <property name="input_purpose">password</property>
+                        <property name="activates-default">True</property>
                         <property name="truncate-multiline">True</property>
+                        <property name="input-purpose">password</property>
                         <child internal-child="accessible">
                           <object class="AtkObject" id="confirmpassEntry-atkobject">
                             <property name="AtkObject::accessible-description" translatable="yes" context="password|extended_tip|confirmpassEntry">Re-enter the password.</property>
@@ -119,115 +119,113 @@
                         </child>
                       </object>
                       <packing>
-                        <property name="left_attach">0</property>
-                        <property name="top_attach">3</property>
+                        <property name="left-attach">0</property>
+                        <property name="top-attach">3</property>
                       </packing>
                     </child>
                     <child>
                       <object class="GtkLabel" id="label1">
                         <property name="visible">True</property>
-                        <property name="can_focus">False</property>
+                        <property name="can-focus">False</property>
                         <property name="label" translatable="yes" context="password|label1">Note: After a password has been set, the document will only open with the password. Should you lose the password, there will be no way to recover the document. Please also note that this password is case-sensitive.</property>
                         <property name="wrap">True</property>
-                        <property name="max_width_chars">60</property>
+                        <property name="max-width-chars">60</property>
                         <property name="xalign">0</property>
                       </object>
                       <packing>
-                        <property name="left_attach">0</property>
-                        <property name="top_attach">4</property>
+                        <property name="left-attach">0</property>
+                        <property name="top-attach">4</property>
                       </packing>
                     </child>
                     <child>
                       <object class="GtkExpander" id="expander">
                         <property name="visible">True</property>
-                        <property name="can_focus">True</property>
-                        <property name="resize_toplevel">True</property>
+                        <property name="can-focus">True</property>
+                        <property name="resize-toplevel">True</property>
                         <child>
                           <object class="GtkFrame" id="frame1">
                             <property name="visible">True</property>
-                            <property name="can_focus">False</property>
-                            <property name="margin_top">12</property>
-                            <property name="label_xalign">0</property>
-                            <property name="shadow_type">none</property>
+                            <property name="can-focus">False</property>
+                            <property name="margin-top">12</property>
+                            <property name="label-xalign">0</property>
+                            <property name="shadow-type">none</property>
                             <child>
-                              <!-- n-columns=1 n-rows=1 -->
+                              <!-- n-columns=1 n-rows=5 -->
                               <object class="GtkGrid" id="grid3">
                                 <property name="visible">True</property>
-                                <property name="can_focus">False</property>
-                                <property name="row_spacing">6</property>
+                                <property name="can-focus">False</property>
                                 <property name="margin-start">12</property>
                                 <property name="margin-top">6</property>
+                                <property name="row-spacing">6</property>
                                 <child>
                                   <object class="GtkCheckButton" id="readonly">
                                     <property name="label" translatable="yes" context="password|readonly">Open file read-only</property>
                                     <property name="visible">True</property>
-                                    <property name="can_focus">True</property>
-                                    <property name="receives_default">False</property>
-                                    <property name="use_underline">True</property>
-                                    <property name="draw_indicator">True</property>
+                                    <property name="can-focus">True</property>
+                                    <property name="receives-default">False</property>
+                                    <property name="use-underline">True</property>
+                                    <property name="draw-indicator">True</property>
                                   </object>
                                   <packing>
-                                    <property name="left_attach">0</property>
-                                    <property name="top_attach">0</property>
+                                    <property name="left-attach">0</property>
+                                    <property name="top-attach">0</property>
                                   </packing>
                                 </child>
                                 <child>
                                   <object class="GtkEntry" id="newpassroEntry">
                                     <property name="visible">True</property>
-                                    <property name="can_focus">True</property>
+                                    <property name="can-focus">True</property>
                                     <property name="hexpand">True</property>
                                     <property name="visibility">False</property>
-                                    <property name="activates_default">True</property>
+                                    <property name="activates-default">True</property>
                                     <property name="truncate-multiline">True</property>
-                                    <property name="input_purpose">password</property>
+                                    <property name="input-purpose">password</property>
                                   </object>
                                   <packing>
-                                    <property name="left_attach">0</property>
-                                    <property name="top_attach">2</property>
+                                    <property name="left-attach">0</property>
+                                    <property name="top-attach">2</property>
                                   </packing>
                                 </child>
                                 <child>
                                   <object class="GtkEntry" id="confirmropassEntry">
                                     <property name="visible">True</property>
-                                    <property name="can_focus">True</property>
+                                    <property name="can-focus">True</property>
                                     <property name="hexpand">True</property>
                                     <property name="visibility">False</property>
-                                    <property name="activates_default">True</property>
+                                    <property name="activates-default">True</property>
                                     <property name="truncate-multiline">True</property>
-                                    <property name="input_purpose">password</property>
+                                    <property name="input-purpose">password</property>
                                   </object>
                                   <packing>
-                                    <property name="left_attach">0</property>
-                                    <property name="top_attach">4</property>
+                                    <property name="left-attach">0</property>
+                                    <property name="top-attach">4</property>
                                   </packing>
                                 </child>
                                 <child>
-                                  <!-- n-columns=1 n-rows=1 -->
+                                  <!-- n-columns=2 n-rows=1 -->
                                   <object class="GtkGrid">
                                     <property name="visible">True</property>
-                                    <property name="can_focus">False</property>
+                                    <property name="can-focus">False</property>
                                     <child>
                                       <object class="GtkLabel" id="label7">
                                         <property name="visible">True</property>
-                                        <property name="can_focus">False</property>
+                                        <property name="can-focus">False</property>
                                         <property name="label" translatable="yes" context="password|label7">Enter password to allow editing</property>
-                                        <property name="use_underline">True</property>
-                                        <property name="mnemonic_widget">newpassroEntry</property>
+                                        <property name="use-underline">True</property>
+                                        <property name="mnemonic-widget">newpassroEntry</property>
                                         <property name="xalign">0</property>
                                       </object>
                                       <packing>
-                                        <property name="left_attach">0</property>
-                                        <property name="top_attach">0</property>
+                                        <property name="left-attach">0</property>
+                                        <property name="top-attach">0</property>
                                       </packing>
                                     </child>
                                     <child>
                                       <object class="GtkLabel" id="newpassroIndicator">
-                                        <property name="can_focus">False</property>
-                                        <property name="no_show_all">True</property>
+                                        <property name="can-focus">False</property>
+                                        <property name="no-show-all">True</property>
                                         <property name="halign">end</property>
                                         <property name="hexpand">True</property>
-                                        <property name="use_underline">True</property>
-                                        <property name="mnemonic_widget">newpassEntry</property>
                                         <property name="xalign">0</property>
                                         <child internal-child="accessible">
                                           <object class="AtkObject" id="newpassroIndicator-atkobject">
@@ -236,43 +234,41 @@
                                         </child>
                                       </object>
                                       <packing>
-                                        <property name="left_attach">1</property>
-                                        <property name="top_attach">0</property>
+                                        <property name="left-attach">1</property>
+                                        <property name="top-attach">0</property>
                                       </packing>
                                     </child>
                                   </object>
                                   <packing>
-                                    <property name="left_attach">0</property>
-                                    <property name="top_attach">1</property>
+                                    <property name="left-attach">0</property>
+                                    <property name="top-attach">1</property>
                                   </packing>
                                 </child>
                                 <child>
-                                  <!-- n-columns=1 n-rows=1 -->
+                                  <!-- n-columns=2 n-rows=1 -->
                                   <object class="GtkGrid">
                                     <property name="visible">True</property>
-                                    <property name="can_focus">False</property>
+                                    <property name="can-focus">False</property>
                                     <child>
                                       <object class="GtkLabel" id="label8">
                                         <property name="visible">True</property>
-                                        <property name="can_focus">False</property>
+                                        <property name="can-focus">False</property>
                                         <property name="label" translatable="yes" context="password|label8">Confirm password</property>
-                                        <property name="use_underline">True</property>
-                                        <property name="mnemonic_widget">confirmropassEntry</property>
+                                        <property name="use-underline">True</property>
+                                        <property name="mnemonic-widget">confirmropassEntry</property>
                                         <property name="xalign">0</property>
                                       </object>
                                       <packing>
-                                        <property name="left_attach">0</property>
-                                        <property name="top_attach">0</property>
+                                        <property name="left-attach">0</property>
+                                        <property name="top-attach">0</property>
                                       </packing>
                                     </child>
                                     <child>
                                       <object class="GtkLabel" id="confirmropassIndicator">
-                                        <property name="can_focus">False</property>
-                                        <property name="no_show_all">True</property>
+                                        <property name="can-focus">False</property>
+                                        <property name="no-show-all">True</property>
                                         <property name="halign">end</property>
                                         <property name="hexpand">True</property>
-                                        <property name="use_underline">True</property>
-                                        <property name="mnemonic_widget">newpassEntry</property>
                                         <property name="xalign">0</property>
                                         <child internal-child="accessible">
                                           <object class="AtkObject" id="confirmropassIndicator-atkobject">
@@ -281,14 +277,14 @@
                                         </child>
                                       </object>
                                       <packing>
-                                        <property name="left_attach">1</property>
-                                        <property name="top_attach">0</property>
+                                        <property name="left-attach">1</property>
+                                        <property name="top-attach">0</property>
                                       </packing>
                                     </child>
                                   </object>
                                   <packing>
-                                    <property name="left_attach">0</property>
-                                    <property name="top_attach">3</property>
+                                    <property name="left-attach">0</property>
+                                    <property name="top-attach">3</property>
                                   </packing>
                                 </child>
                               </object>
@@ -296,7 +292,7 @@
                             <child type="label">
                               <object class="GtkLabel" id="label6">
                                 <property name="visible">True</property>
-                                <property name="can_focus">False</property>
+                                <property name="can-focus">False</property>
                                 <property name="label" translatable="yes" context="password|label6">File Sharing Password</property>
                                 <attributes>
                                   <attribute name="weight" value="bold"/>
@@ -308,9 +304,9 @@
                         <child type="label">
                           <object class="GtkLabel" id="label3">
                             <property name="visible">True</property>
-                            <property name="can_focus">False</property>
+                            <property name="can-focus">False</property>
                             <property name="label" translatable="yes" context="password|label3">_Options</property>
-                            <property name="use_underline">True</property>
+                            <property name="use-underline">True</property>
                           </object>
                         </child>
                         <child internal-child="accessible">
@@ -320,37 +316,35 @@
                         </child>
                       </object>
                       <packing>
-                        <property name="left_attach">0</property>
-                        <property name="top_attach">5</property>
+                        <property name="left-attach">0</property>
+                        <property name="top-attach">5</property>
                       </packing>
                     </child>
                     <child>
-                      <!-- n-columns=1 n-rows=1 -->
+                      <!-- n-columns=2 n-rows=1 -->
                       <object class="GtkGrid">
                         <property name="visible">True</property>
-                        <property name="can_focus">False</property>
+                        <property name="can-focus">False</property>
                         <child>
                           <object class="GtkLabel" id="label4">
                             <property name="visible">True</property>
-                            <property name="can_focus">False</property>
+                            <property name="can-focus">False</property>
                             <property name="label" translatable="yes" context="password|label4">_Enter password to open</property>
-                            <property name="use_underline">True</property>
-                            <property name="mnemonic_widget">newpassEntry</property>
+                            <property name="use-underline">True</property>
+                            <property name="mnemonic-widget">newpassEntry</property>
                             <property name="xalign">0</property>
                           </object>
                           <packing>
-                            <property name="left_attach">0</property>
-                            <property name="top_attach">0</property>
+                            <property name="left-attach">0</property>
+                            <property name="top-attach">0</property>
                           </packing>
                         </child>
                         <child>
                           <object class="GtkLabel" id="newpassIndicator">
-                            <property name="can_focus">False</property>
-                            <property name="no_show_all">True</property>
+                            <property name="can-focus">False</property>
+                            <property name="no-show-all">True</property>
                             <property name="halign">end</property>
                             <property name="hexpand">True</property>
-                            <property name="use_underline">True</property>
-                            <property name="mnemonic_widget">newpassEntry</property>
                             <property name="xalign">0</property>
                             <child internal-child="accessible">
                               <object class="AtkObject" id="newpassIndicator-atkobject">
@@ -359,43 +353,41 @@
                             </child>
                           </object>
                           <packing>
-                            <property name="left_attach">1</property>
-                            <property name="top_attach">0</property>
+                            <property name="left-attach">1</property>
+                            <property name="top-attach">0</property>
                           </packing>
                         </child>
                       </object>
                       <packing>
-                        <property name="left_attach">0</property>
-                        <property name="top_attach">0</property>
+                        <property name="left-attach">0</property>
+                        <property name="top-attach">0</property>
                       </packing>
                     </child>
                     <child>
-                      <!-- n-columns=1 n-rows=1 -->
+                      <!-- n-columns=2 n-rows=1 -->
                       <object class="GtkGrid">
                         <property name="visible">True</property>
-                        <property name="can_focus">False</property>
+                        <property name="can-focus">False</property>
                         <child>
                           <object class="GtkLabel" id="label5">
                             <property name="visible">True</property>
-                            <property name="can_focus">False</property>
+                            <property name="can-focus">False</property>
                             <property name="label" translatable="yes" context="password|label5">Confirm password</property>
-                            <property name="use_underline">True</property>
-                            <property name="mnemonic_widget">confirmpassEntry</property>
+                            <property name="use-underline">True</property>
+                            <property name="mnemonic-widget">confirmpassEntry</property>
                             <property name="xalign">0</property>
                           </object>
                           <packing>
-                            <property name="left_attach">0</property>
-                            <property name="top_attach">0</property>
+                            <property name="left-attach">0</property>
+                            <property name="top-attach">0</property>
                           </packing>
                         </child>
                         <child>
                           <object class="GtkLabel" id="confirmpassIndicator">
-                            <property name="can_focus">False</property>
-                            <property name="no_show_all">True</property>
+                            <property name="can-focus">False</property>
+                            <property name="no-show-all">True</property>
                             <property name="halign">end</property>
                             <property name="hexpand">True</property>
-                            <property name="use_underline">True</property>
-                            <property name="mnemonic_widget">newpassEntry</property>
                             <property name="xalign">0</property>
                             <child internal-child="accessible">
                               <object class="AtkObject" id="confirmpassIndicator-atkobject">
@@ -404,14 +396,14 @@
                             </child>
                           </object>
                           <packing>
-                            <property name="left_attach">1</property>
-                            <property name="top_attach">0</property>
+                            <property name="left-attach">1</property>
+                            <property name="top-attach">0</property>
                           </packing>
                         </child>
                       </object>
                       <packing>
-                        <property name="left_attach">0</property>
-                        <property name="top_attach">2</property>
+                        <property name="left-attach">0</property>
+                        <property name="top-attach">2</property>
                       </packing>
                     </child>
                   </object>
@@ -419,7 +411,7 @@
                 <child type="label">
                   <object class="GtkLabel" id="label2">
                     <property name="visible">True</property>
-                    <property name="can_focus">False</property>
+                    <property name="can-focus">False</property>
                     <property name="label" translatable="yes" context="password|label2">File Encryption Password</property>
                     <attributes>
                       <attribute name="weight" value="bold"/>
@@ -446,9 +438,6 @@
       <action-widget response="-5">ok</action-widget>
       <action-widget response="-6">cancel</action-widget>
     </action-widgets>
-    <child type="titlebar">
-      <placeholder/>
-    </child>
   </object>
   <object class="GtkSizeGroup" id="sizegroup1"/>
 </interface>