diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-30 09:20:58 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-30 10:57:04 +0100 |
commit | a4b60b78ea36d55a2abf0e5efccd8530568d2209 (patch) | |
tree | 9468dc489d37b11e14e190502816f3ed55edd0c9 /cui | |
parent | 034a462475c2878e1eba13f10b2fcaf8c1755c4a (diff) |
loplugin:returnconstant
Change-Id: I5b859de6ccd908eee4356acbe1f12b441ab36df3
Reviewed-on: https://gerrit.libreoffice.org/62539
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cui')
-rw-r--r-- | cui/source/inc/autocdlg.hxx | 2 | ||||
-rw-r--r-- | cui/source/inc/macroass.hxx | 2 | ||||
-rw-r--r-- | cui/source/tabpages/autocdlg.cxx | 6 | ||||
-rw-r--r-- | cui/source/tabpages/macroass.cxx | 8 |
4 files changed, 9 insertions, 9 deletions
diff --git a/cui/source/inc/autocdlg.hxx b/cui/source/inc/autocdlg.hxx index 82a937484aba..d021827ddb55 100644 --- a/cui/source/inc/autocdlg.hxx +++ b/cui/source/inc/autocdlg.hxx @@ -326,7 +326,7 @@ private: DECL_LINK(NewDelActionHdl, AutoCorrEdit&, bool); DECL_LINK(SelectHdl, ListBox&, void); DECL_LINK(ModifyHdl, Edit&, void); - bool NewDelHdl(void const *); + void NewDelHdl(void const *); /// Box filled with new language void RefillReplaceBoxes(bool bFromReset, LanguageType eOldLanguage, diff --git a/cui/source/inc/macroass.hxx b/cui/source/inc/macroass.hxx index 1ed414b37182..3a37af149639 100644 --- a/cui/source/inc/macroass.hxx +++ b/cui/source/inc/macroass.hxx @@ -42,7 +42,7 @@ class SfxMacroTabPage final : public SfxTabPage DECL_LINK( AssignDeleteHdl_Impl, SvTreeListBox*, bool ); DECL_LINK( AssignDeleteClickHdl_Impl, Button *, void ); - bool AssignDeleteHdl(Control const *); + void AssignDeleteHdl(Control const *); DECL_LINK( TimeOut_Impl, Timer*, void ); std::unique_ptr<SfxMacroTabPage_Impl> mpImpl; diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx index 2a08fa616064..1bc9ffc4b780 100644 --- a/cui/source/tabpages/autocdlg.cxx +++ b/cui/source/tabpages/autocdlg.cxx @@ -1652,10 +1652,11 @@ IMPL_LINK(OfaAutocorrExceptPage, NewDelButtonHdl, Button*, pBtn, void) IMPL_LINK(OfaAutocorrExceptPage, NewDelActionHdl, AutoCorrEdit&, rEdit, bool) { - return NewDelHdl(&rEdit); + NewDelHdl(&rEdit); + return false; } -bool OfaAutocorrExceptPage::NewDelHdl(void const * pBtn) +void OfaAutocorrExceptPage::NewDelHdl(void const * pBtn) { if((pBtn == m_pNewAbbrevPB || pBtn == m_pAbbrevED.get() ) && !m_pAbbrevED->GetText().isEmpty()) @@ -1679,7 +1680,6 @@ bool OfaAutocorrExceptPage::NewDelHdl(void const * pBtn) m_pDoubleCapsLB->RemoveEntry(m_pDoubleCapsED->GetText()); ModifyHdl(*m_pDoubleCapsED); } - return false; } IMPL_LINK(OfaAutocorrExceptPage, SelectHdl, ListBox&, rBox, void) diff --git a/cui/source/tabpages/macroass.cxx b/cui/source/tabpages/macroass.cxx index 9bd6a00f7d71..8f46be227a44 100644 --- a/cui/source/tabpages/macroass.cxx +++ b/cui/source/tabpages/macroass.cxx @@ -307,17 +307,18 @@ IMPL_LINK( SfxMacroTabPage, AssignDeleteClickHdl_Impl, Button*, pBtn, void ) IMPL_LINK( SfxMacroTabPage, AssignDeleteHdl_Impl, SvTreeListBox*, pBtn, bool ) { - return AssignDeleteHdl(pBtn); + AssignDeleteHdl(pBtn); + return false; } -bool SfxMacroTabPage::AssignDeleteHdl(Control const * pBtn) +void SfxMacroTabPage::AssignDeleteHdl(Control const * pBtn) { SvHeaderTabListBox& rListBox = mpImpl->pEventLB->GetListBox(); SvTreeListEntry* pE = rListBox.FirstSelected(); if( !pE || LISTBOX_ENTRY_NOTFOUND == rListBox.GetModel()->GetAbsPos( pE ) ) { DBG_ASSERT( pE, "Where does the empty entry come from?" ); - return false; + return; } const bool bAssEnabled = pBtn != mpImpl->pDeletePB && mpImpl->pAssignPB->IsEnabled(); @@ -351,7 +352,6 @@ bool SfxMacroTabPage::AssignDeleteHdl(Control const * pBtn) rListBox.SetUpdateMode( true ); EnableButtons(); - return false; } IMPL_LINK( SfxMacroTabPage, TimeOut_Impl, Timer*,, void ) |