teach redundantcast plugin about functional casts

Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 9 insertions, 12 deletions

diff --git a/cui/source/dialogs/hangulhanjadlg.cxx b/cui/source/dialogs/hangulhanjadlg.cxx
index dc33da086b0b..9ef0d6f6261b 100644
--- a/cui/source/dialogs/hangulhanjadlg.cxx
+++ b/cui/source/dialogs/hangulhanjadlg.cxx
@@ -1003,13 +1003,13 @@ namespace svx
         aTmp <<= aActiveDics;
         aLngCfg.SetProperty( UPH_ACTIVE_CONVERSION_DICTIONARIES, aTmp );
 
-        aTmp <<= bool( m_pIgnorepostCB->IsChecked() );
+        aTmp <<= m_pIgnorepostCB->IsChecked();
         aLngCfg.SetProperty( UPH_IS_IGNORE_POST_POSITIONAL_WORD, aTmp );
 
-        aTmp <<= bool( m_pShowrecentlyfirstCB->IsChecked() );
+        aTmp <<= m_pShowrecentlyfirstCB->IsChecked();
         aLngCfg.SetProperty( UPH_IS_SHOW_ENTRIES_RECENTLY_USED_FIRST, aTmp );
 
-        aTmp <<= bool( m_pAutoreplaceuniqueCB->IsChecked() );
+        aTmp <<= m_pAutoreplaceuniqueCB->IsChecked();
         aLngCfg.SetProperty( UPH_IS_AUTO_REPLACE_UNIQUE_ENTRIES, aTmp );
 
         EndDialog( RET_OK );
diff --git a/cui/source/options/optjava.cxx b/cui/source/options/optjava.cxx
index 0c5d3877bf20..c0eb29c13eee 100644
--- a/cui/source/options/optjava.cxx
+++ b/cui/source/options/optjava.cxx
@@ -650,7 +650,7 @@ bool SvxJavaOptionsPage::FillItemSet( SfxItemSet* /*rCoreSet*/ )
     eErr = jfw_getEnabled( &bEnabled );
     DBG_ASSERT( JFW_E_NONE == eErr,
                 "SvxJavaOptionsPage::FillItemSet(): error in jfw_getEnabled" ); (void)eErr;
-    if ( bool(bEnabled) != m_pJavaEnableCB->IsChecked() )
+    if ( bEnabled != m_pJavaEnableCB->IsChecked() )
     {
         eErr = jfw_setEnabled( m_pJavaEnableCB->IsChecked() );
         DBG_ASSERT( JFW_E_NONE == eErr,
diff --git a/cui/source/tabpages/border.cxx b/cui/source/tabpages/border.cxx
index 606e66309205..eebd2eb35a8c 100644
--- a/cui/source/tabpages/border.cxx
+++ b/cui/source/tabpages/border.cxx
@@ -918,7 +918,7 @@ IMPL_LINK_NOARG(SvxBorderTabPage, ModifyWidthHdl_Impl, Edit&, void)
     m_pLbLineStyle->SetWidth( nVal );
 
     m_pFrameSel->SetStyleToSelection( nVal,
-        SvxBorderLineStyle( m_pLbLineStyle->GetSelectEntryStyle() ) );
+        m_pLbLineStyle->GetSelectEntryStyle() );
 }
 
 
@@ -931,7 +931,7 @@ IMPL_LINK( SvxBorderTabPage, SelStyleHdl_Impl, ListBox&, rLb, void )
                     m_pLineWidthMF->GetDecimalDigits( ),
                     m_pLineWidthMF->GetUnit(), MapUnit::MapTwip ));
         m_pFrameSel->SetStyleToSelection ( nVal,
-            SvxBorderLineStyle( m_pLbLineStyle->GetSelectEntryStyle() ) );
+            m_pLbLineStyle->GetSelectEntryStyle() );
     }
 }
 
diff --git a/cui/source/tabpages/tpline.cxx b/cui/source/tabpages/tpline.cxx
index 52830e93919f..319442e2cb1a 100644
--- a/cui/source/tabpages/tpline.cxx
+++ b/cui/source/tabpages/tpline.cxx
@@ -1657,9 +1657,8 @@ void SvxLineTabPage::ChangeEndHdl_Impl( void * p )
 IMPL_LINK_NOARG(SvxLineTabPage, ChangeTransparentHdl_Impl, Edit&, void)
 {
     sal_uInt16 nVal = (sal_uInt16)m_pMtrTransparent->GetValue();
-    XLineTransparenceItem aItem( nVal );
 
-    m_rXLSet.Put( XLineTransparenceItem( aItem ) );
+    m_rXLSet.Put( XLineTransparenceItem( nVal ) );
 
     FillXLSet_Impl();
 
diff --git a/cui/source/tabpages/tpshadow.cxx b/cui/source/tabpages/tpshadow.cxx
index 999cb1eb0eee..76ae22b242b9 100644
--- a/cui/source/tabpages/tpshadow.cxx
+++ b/cui/source/tabpages/tpshadow.cxx
@@ -478,8 +478,7 @@ IMPL_LINK_NOARG(SvxShadowTabPage, ModifyShadowHdl_Impl, Edit&, void)
 
     m_rXFSet.Put( XFillColorItem( OUString(), m_pLbShadowColor->GetSelectEntryColor() ) );
     sal_uInt16 nVal = (sal_uInt16)m_pMtrTransparent->GetValue();
-    XFillTransparenceItem aItem( nVal );
-    m_rXFSet.Put( XFillTransparenceItem( aItem ) );
+    m_rXFSet.Put( XFillTransparenceItem( nVal ) );
 
     // shadow removal
     sal_Int32 nX = 0L, nY = 0L;
diff --git a/cui/source/tabpages/tptrans.cxx b/cui/source/tabpages/tptrans.cxx
index 5b1ce71a644a..6a0cee181285 100644
--- a/cui/source/tabpages/tptrans.cxx
+++ b/cui/source/tabpages/tptrans.cxx
@@ -133,8 +133,7 @@ void SvxTransparenceTabPage::ActivateLinear(bool bActivate)
 IMPL_LINK_NOARG(SvxTransparenceTabPage, ModifyTransparentHdl_Impl, Edit&, void)
 {
     sal_uInt16 nPos = (sal_uInt16)m_pMtrTransparent->GetValue();
-    XFillTransparenceItem aItem(nPos);
-    rXFSet.Put(XFillTransparenceItem(aItem));
+    rXFSet.Put(XFillTransparenceItem(nPos));
 
     // preview
     InvalidatePreview();