update unusedmethods plugin to deal with constructors

and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

10 files changed, 3 insertions, 85 deletions

diff --git a/cui/source/dialogs/SpellAttrib.hxx b/cui/source/dialogs/SpellAttrib.hxx
index 4069af899875..8578914890d0 100644
--- a/cui/source/dialogs/SpellAttrib.hxx
+++ b/cui/source/dialogs/SpellAttrib.hxx
@@ -44,9 +44,6 @@ struct SpellErrorDescription
     css::uno::Sequence< OUString >  aSuggestions;
     OUString                                     sRuleId;
 
-    SpellErrorDescription() :
-        bIsGrammarError( false ){}
-
     SpellErrorDescription( bool bGrammar,
                       const OUString& rText,
                       const css::lang::Locale& rLocale,
@@ -99,8 +96,7 @@ public:
 private:
     SpellErrorDescription        m_aSpellErrorDescription;
 
-                            //not accessible
-                            SpellErrorAttrib();
+                            SpellErrorAttrib() = delete;
 public:
                             SpellErrorAttrib( const SpellErrorDescription& );
                             SpellErrorAttrib( const SpellErrorAttrib& rAttr );
@@ -119,8 +115,7 @@ class SpellLanguageAttrib : public TextAttrib
 {
     LanguageType m_eLanguage;
 
-                            //not accessible
-                            SpellLanguageAttrib();
+                            SpellLanguageAttrib() = delete;
 
 public:
                             SpellLanguageAttrib(LanguageType eLanguage);
@@ -139,8 +134,7 @@ class SpellBackgroundAttrib : public TextAttrib
 {
     Color   m_aBackgroundColor;
 
-                            //not accessible
-                            SpellBackgroundAttrib();
+                            SpellBackgroundAttrib() = delete;
 
 public:
                             SpellBackgroundAttrib(const Color& rCol);
diff --git a/cui/source/inc/autocdlg.hxx b/cui/source/inc/autocdlg.hxx
index 8ea2d9a5ce74..1d3fae0f1cf5 100644
--- a/cui/source/inc/autocdlg.hxx
+++ b/cui/source/inc/autocdlg.hxx
@@ -191,13 +191,6 @@ class AutoCorrEdit : public Edit
     void dispose() override;
 
 public:
-    AutoCorrEdit(vcl::Window* pParent, const ResId& rResId)
-        : Edit(pParent, rResId)
-        , m_nCol(0)
-        , bSpaces(false)
-    {
-    }
-
     AutoCorrEdit(vcl::Window* pParent)
         : Edit(pParent)
         , m_nCol(0)
diff --git a/cui/source/inc/cuihyperdlg.hxx b/cui/source/inc/cuihyperdlg.hxx
index 2c56294ab676..41dcd1bd769e 100644
--- a/cui/source/inc/cuihyperdlg.hxx
+++ b/cui/source/inc/cuihyperdlg.hxx
@@ -88,7 +88,6 @@ public:
     void                    SetReadOnlyMode( bool bReadOnly );
     inline bool             IsHTMLDoc() const { return mbIsHTMLDoc; }
 
-    inline SfxBindings*     GetBindings() const { return mpBindings; };
     inline SfxDispatcher*   GetDispatcher() const { return mpBindings->GetDispatcher(); }
 };
 
diff --git a/cui/source/inc/insdlg.hxx b/cui/source/inc/insdlg.hxx
index c4624a6f70be..58e79ad7fe10 100644
--- a/cui/source/inc/insdlg.hxx
+++ b/cui/source/inc/insdlg.hxx
@@ -94,19 +94,6 @@ public:
     css::uno::Reference< css::io::XInputStream > GetIconIfIconified( OUString* pGraphicMediaType ) override;
 };
 
-class SvInsertPlugInDialog : public InsertObjectDialog_Impl
-{
-private:
-    DECL_LINK_TYPED(BrowseHdl, Button*, void);
-
-public:
-    SvInsertPlugInDialog(vcl::Window* pParent,
-        const css::uno::Reference < css::embed::XStorage >& xStorage);
-    virtual ~SvInsertPlugInDialog();
-    virtual void dispose() override;
-    virtual short Execute() override;
-};
-
 class SfxInsertFloatingFrameDialog : public InsertObjectDialog_Impl
 {
 private:
diff --git a/cui/source/inc/macropg.hxx b/cui/source/inc/macropg.hxx
index 2d3d11985f79..e78045bca74a 100644
--- a/cui/source/inc/macropg.hxx
+++ b/cui/source/inc/macropg.hxx
@@ -42,7 +42,6 @@ struct EventDisplayName
 {
     const sal_Char* pAsciiEventName;
     sal_uInt16          nEventResourceID;
-    EventDisplayName() : pAsciiEventName( nullptr ), nEventResourceID(0) { }
     EventDisplayName( const sal_Char* _pAsciiName, const sal_uInt16 _nResId )
         : pAsciiEventName( _pAsciiName )
         , nEventResourceID( _nResId )
diff --git a/cui/source/inc/optdict.hxx b/cui/source/inc/optdict.hxx
index ad46c19a9b32..670d3b4342e8 100644
--- a/cui/source/inc/optdict.hxx
+++ b/cui/source/inc/optdict.hxx
@@ -78,8 +78,6 @@ class SvxDictEdit : public Edit
     bool                     bSpaces;
 
     public:
-                    SvxDictEdit(vcl::Window* pParent, const ResId& rResId) :
-                        Edit(pParent, rResId), bSpaces(false){}
                     SvxDictEdit(vcl::Window* pParent, WinBits aWB) :
                         Edit(pParent, aWB), bSpaces(false){}
 
diff --git a/cui/source/inc/scriptdlg.hxx b/cui/source/inc/scriptdlg.hxx
index 54b659e9b81b..dd588601a33f 100644
--- a/cui/source/inc/scriptdlg.hxx
+++ b/cui/source/inc/scriptdlg.hxx
@@ -117,9 +117,7 @@ private:
     bool            loaded;
         css::uno::Reference< css::script::browse::XBrowseNode > nodes;
         css::uno::Reference< css::frame::XModel > model;
-    SFEntry(){}
 public:
-                    SFEntry( sal_uInt8 nT )             { nType = nT; loaded=false; }
                     SFEntry( sal_uInt8 nT,
                             const css::uno::Reference< css::script::browse::XBrowseNode >& entryNodes ,
                             const css::uno::Reference< css::frame::XModel >& entryModel) { nType = nT; nodes = entryNodes; loaded=false; model = entryModel; }
diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx
index 9ca93fca9231..2dc815a8d8a7 100644
--- a/cui/source/options/optinet2.cxx
+++ b/cui/source/options/optinet2.cxx
@@ -551,40 +551,6 @@ IMPL_STATIC_LINK_TYPED( SvxProxyTabPage, LoseFocusHdl_Impl, Control&, rControl,
 }
 
 
-void SvxScriptExecListBox::RequestHelp( const HelpEvent& rHEvt )
-{   // try to show tips just like as on toolbars
-    sal_Int32 nPos=LISTBOX_ENTRY_NOTFOUND;
-    sal_Int32 nTop = GetTopEntry();
-    sal_uInt16 nCount = GetDisplayLineCount(); // Attention: Not GetLineCount()
-    Point aPt = ScreenToOutputPixel( rHEvt.GetMousePosPixel() );
-    Rectangle aItemRect;
-    if( nCount > 0 ) // if there're some entries, find it.
-         for( nPos = nTop ; nPos <= nTop+nCount-1 ; nPos++ ) {
-            aItemRect = GetBoundingRectangle(nPos);
-            if( aPt.Y() < aItemRect.Top() || aPt.Y() > aItemRect.Bottom() )
-                continue;
-            else
-                break;
-        }
-     else // if not, nothing happens.
-         return;
-     OUString aHelpText;
-     if( nPos <= nTop+nCount-1 ) // if find the matching entry, get its content.
-         aHelpText = GetEntry(nPos);
-    if( aHelpText.getLength() && GetTextWidth(aHelpText)<GetOutputSizePixel().Width() )
-        aHelpText.clear(); // if the entry is quite short, clear the helping tip content.
-    aItemRect = Rectangle(Point(0,0),GetSizePixel());
-    aPt = Point(OutputToScreenPixel( aItemRect.TopLeft() ));
-    aItemRect.Left()   = aPt.X();
-    aItemRect.Top()    = aPt.Y();
-    aPt = OutputToScreenPixel( aItemRect.BottomRight() );
-    aItemRect.Right()  = aPt.X();
-    aItemRect.Bottom() = aPt.Y();
-    if( rHEvt.GetMode() == HelpEventMode::BALLOON )
-        Help::ShowBalloon( this, aItemRect.Center(), aItemRect, aHelpText);
-    else
-        Help::ShowQuickHelp( this, aItemRect, aHelpText );
-}
 
 /********************************************************************/
 /*                                                                  */
diff --git a/cui/source/options/optinet2.hxx b/cui/source/options/optinet2.hxx
index 16fc4c94aaf6..a34eccce80eb 100644
--- a/cui/source/options/optinet2.hxx
+++ b/cui/source/options/optinet2.hxx
@@ -98,19 +98,6 @@ public:
     virtual void        Reset( const SfxItemSet* rSet ) override;
 };
 
-// #98647# class SvxScriptExecListBox ------------------------------------
-class SvxScriptExecListBox : public ListBox
-{ // for adding tooltips to ListBox
-public:
-    SvxScriptExecListBox( vcl::Window* pParent, WinBits nStyle = WB_BORDER )
-            :ListBox(pParent, nStyle) {}
-    SvxScriptExecListBox( vcl::Window* pParent, const ResId& rResId )
-            :ListBox(pParent, rResId) {}
-
-protected:
-    virtual void RequestHelp( const HelpEvent& rHEvt ) override;
-};
-
 // class SvxSecurityTabPage ---------------------------------------------
 
 class SvtSecurityOptions;
diff --git a/cui/source/options/optjava.hxx b/cui/source/options/optjava.hxx
index 85905df10641..bee68940ce50 100644
--- a/cui/source/options/optjava.hxx
+++ b/cui/source/options/optjava.hxx
@@ -148,9 +148,6 @@ private:
                                     m_pAssignedList->GetSelectEntryPos()
                                     != LISTBOX_ENTRY_NOTFOUND ); }
 
-    inline void             EnableAssignButton()
-                                { m_pAssignBtn->Enable(); }
-
     inline void             DisableAssignButton()
                                 { m_pAssignBtn->Disable(); }