diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-01-31 14:46:38 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-02-01 12:15:22 +0000 |
| commit | 2489000d3fd66319a8355fd4e37cfdfda47296d0 (patch) | |
| tree | caad79e7b5bec3863604b20190b682c0d73d2b25 /cui | |
| parent | 595848c85acc2609fcc48a40c7a9f216a2722cd8 (diff) | |
loplugin:useuniqueptr extend to check local vars
just the simple and obvious case for now, of a local var being allocated
and deleted inside a single local block, and the delete happening at the
end of the block
Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625
Reviewed-on: https://gerrit.libreoffice.org/33749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cui')
| -rw-r--r-- | cui/source/dialogs/hltpbase.cxx | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/cui/source/dialogs/hltpbase.cxx b/cui/source/dialogs/hltpbase.cxx index d8cfadf9e5cf..7fefb04ddcb3 100644 --- a/cui/source/dialogs/hltpbase.cxx +++ b/cui/source/dialogs/hltpbase.cxx @@ -320,9 +320,9 @@ IMPL_LINK_NOARG(SvxHyperlinkTabPageBase, ClickScriptHdl_Impl, Button*, void) aItem.SetMacroTable( *pMacroTbl ); // create empty itemset for macro-dlg - SfxItemSet* pItemSet = new SfxItemSet(SfxGetpApp()->GetPool(), + std::unique_ptr<SfxItemSet> pItemSet( new SfxItemSet(SfxGetpApp()->GetPool(), SID_ATTR_MACROITEM, - SID_ATTR_MACROITEM ); + SID_ATTR_MACROITEM ) ); pItemSet->Put ( aItem ); /* disable HyperLinkDlg for input while the MacroAssignDlg is working @@ -362,7 +362,6 @@ IMPL_LINK_NOARG(SvxHyperlinkTabPageBase, ClickScriptHdl_Impl, Button*, void) pHyperlinkItem->SetMacroTable( static_cast<const SvxMacroItem*>(pItem)->GetMacroTable() ); } } - delete pItemSet; } } |