fdo#60148 Clean up warnings from the Clang compiler plugin

Change-Id: I08d755677c46c476710ecbd067ed9f7e2f54a671
loplugin: clean warnings: unused variables, incorrect indentation and log area.
Reviewed-on: https://gerrit.libreoffice.org/2544
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

5 files changed, 2 insertions, 9 deletions

diff --git a/cui/source/dialogs/cuigaldlg.cxx b/cui/source/dialogs/cuigaldlg.cxx
index b2d44eab527f..31af615160fa 100644
--- a/cui/source/dialogs/cuigaldlg.cxx
+++ b/cui/source/dialogs/cuigaldlg.cxx
@@ -504,8 +504,8 @@ IMPL_LINK( ActualizeProgress, TimeoutHdl, Timer*, _pTimer )
 
 IMPL_LINK( ActualizeProgress, ActualizeHdl, INetURLObject*, pURL )
 {
-  for( long i = 0; i < 128; i++ )
-    Application::Reschedule();
+    for( long i = 0; i < 128; i++ )
+        Application::Reschedule();
 
     Flush();
     Sync();
diff --git a/cui/source/tabpages/tpbitmap.cxx b/cui/source/tabpages/tpbitmap.cxx
index e4ae1453ff7e..6a4b74b139f0 100644
--- a/cui/source/tabpages/tpbitmap.cxx
+++ b/cui/source/tabpages/tpbitmap.cxx
@@ -515,8 +515,6 @@ long SvxBitmapTabPage::CheckChanges_Impl()
     sal_uInt16 nPos = aLbBitmaps.GetSelectEntryPos();
     if( nPos != LISTBOX_ENTRY_NOTFOUND )
     {
-        String aString = aLbBitmaps.GetSelectEntry();
-
         if( bBmpChanged )
         {
             ResMgr& rMgr = CUI_MGR();
@@ -789,7 +787,6 @@ IMPL_LINK_NOARG(SvxBitmapTabPage, ClickModifyHdl_Impl)
     if ( nPos != LISTBOX_ENTRY_NOTFOUND )
     {
         ResMgr& rMgr = CUI_MGR();
-        String aNewName( SVX_RES( RID_SVXSTR_BITMAP ) );
         String aDesc( ResId( RID_SVXSTR_DESC_NEW_BITMAP, rMgr ) );
         String aName( pBitmapList->GetBitmap( nPos )->GetName() );
         String aOldName = aName;
diff --git a/cui/source/tabpages/tpgradnt.cxx b/cui/source/tabpages/tpgradnt.cxx
index 2e26f3c5362a..6dc090221f02 100644
--- a/cui/source/tabpages/tpgradnt.cxx
+++ b/cui/source/tabpages/tpgradnt.cxx
@@ -259,7 +259,6 @@ long SvxGradientTabPage::CheckChanges_Impl()
     if( nPos != LISTBOX_ENTRY_NOTFOUND )
     {
         XGradient aGradient = pGradientList->GetGradient( nPos )->GetGradient();
-        String aString = m_pLbGradients->GetSelectEntry();
 
         if( !( aTmpGradient == aGradient ) )
         {
@@ -520,7 +519,6 @@ IMPL_LINK_NOARG(SvxGradientTabPage, ClickModifyHdl_Impl)
     if ( nPos != LISTBOX_ENTRY_NOTFOUND )
     {
         ResMgr& rMgr = CUI_MGR();
-        String aNewName( SVX_RES( RID_SVXSTR_GRADIENT ) );
         String aDesc( CUI_RES( RID_SVXSTR_DESC_GRADIENT ) );
         String aName( pGradientList->GetGradient( nPos )->GetName() );
         String aOldName = aName;
diff --git a/cui/source/tabpages/tphatch.cxx b/cui/source/tabpages/tphatch.cxx
index 5970907ad9c2..cb880278dae3 100644
--- a/cui/source/tabpages/tphatch.cxx
+++ b/cui/source/tabpages/tphatch.cxx
@@ -568,7 +568,6 @@ IMPL_LINK_NOARG(SvxHatchTabPage, ClickModifyHdl_Impl)
     if ( nPos != LISTBOX_ENTRY_NOTFOUND )
     {
         ResMgr& rMgr = CUI_MGR();
-        String aNewName( SVX_RES( RID_SVXSTR_HATCH ) );
         String aDesc( CUI_RES( RID_SVXSTR_DESC_HATCH ) );
         String aName( pHatchingList->GetHatch( nPos )->GetName() );
         String aOldName = aName;
diff --git a/cui/source/tabpages/tplnedef.cxx b/cui/source/tabpages/tplnedef.cxx
index d707364a53a8..dd880830295d 100644
--- a/cui/source/tabpages/tplnedef.cxx
+++ b/cui/source/tabpages/tplnedef.cxx
@@ -632,7 +632,6 @@ IMPL_LINK_NOARG(SvxLineDefTabPage, ClickModifyHdl_Impl)
     if( nPos != LISTBOX_ENTRY_NOTFOUND )
     {
         ResMgr& rMgr = CUI_MGR();
-        String aNewName( SVX_RES( RID_SVXSTR_LINESTYLE ) );
         String aDesc( ResId( RID_SVXSTR_DESC_LINESTYLE, rMgr ) );
         String aName( pDashList->GetDash( nPos )->GetName() );
         String aOldName = aName;